Update changelog as on 3.35 branch#176216
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md to include entries for version 3.35.5. My review focuses on improving the clarity and consistency of these new entries to align with the project's documentation best practices. I've suggested rephrasing the descriptions to focus on the problem being solved and correcting minor formatting inconsistencies.
| - [flutter/172105](https://github.com/flutter/flutter/issues/172105) Flutter view no longer hangs after multiple transitions on iOS add-to-app. | ||
| - [flutter/173106](https://github.com/flutter/flutter/issues/173106) Multiple cursors display correctly. |
There was a problem hiding this comment.
These changelog entries could be improved for clarity and consistency.
- They describe the fix rather than the problem. According to the project's
docs/releases/Hotfix-Documentation-Best-Practices.mdguide, entries should describe the problem to help users quickly assess relevance. 1 - The descriptions are a bit vague. For example, for issue 173106, it's not clear what the context for "multiple cursors" is.
- There's an extra leading space before the hyphen on each line, which is inconsistent with other entries in this file.
Here's a suggested improvement to make the entries more informative and consistent:
| - [flutter/172105](https://github.com/flutter/flutter/issues/172105) Flutter view no longer hangs after multiple transitions on iOS add-to-app. | |
| - [flutter/173106](https://github.com/flutter/flutter/issues/173106) Multiple cursors display correctly. | |
| - [flutter/172105](https://github.com/flutter/flutter/issues/172105) The Flutter view may hang after multiple transitions on iOS when using add-to-app. | |
| - [flutter/173106](https://github.com/flutter/flutter/issues/173106) When a text field has multiple cursors, only one is displayed. |
Style Guide References
Footnotes
-
According to the
docs/releases/Hotfix-Documentation-Best-Practices.mdfile in this repository, hotfix summaries should be clear, succinct, and describe the problem (not the fix) including scenario and platform if possible. This helps users quickly determine if a fix is relevant to them. The recommended format is 'When $scenario [on $platform], $problem_description'. ↩
Manual roll requested by [email protected] flutter/flutter@96fe3b3...c9608e2 2025-09-30 [email protected] Implement framework interface for the dialog window archetype (flutter/flutter#176202) 2025-09-30 [email protected] Update flutter test to use SemanticsFlags (flutter/flutter#175987) 2025-09-30 [email protected] Set minimum supported java version to 17 (flutter/flutter#176226) 2025-09-30 [email protected] Reduce timeout for Linux web_tool_tests back to 60 (flutter/flutter#176286) 2025-09-30 [email protected] Roll Packages from 34eec78 to 287739d (9 revisions) (flutter/flutter#176284) 2025-09-30 [email protected] [web] Bump Firefox to 143.0 (flutter/flutter#176110) 2025-09-30 [email protected] Migrate to `WidgetStateBorderSide` (flutter/flutter#176164) 2025-09-30 [email protected] Enhance input decorator padding logic for character counter in text f… (flutter/flutter#175706) 2025-09-30 [email protected] Update the test package for the web engine unit test bits. (flutter/flutter#176241) 2025-09-30 [email protected] Warn if embedder API calls don't return success (flutter/flutter#176184) 2025-09-30 [email protected] Roll Fuchsia Test Scripts from APSBP-sS-3FX69Ihf... to JUeFbA8y0E-_pj-bg... (flutter/flutter#176243) 2025-09-30 [email protected] Roll GN to 81b24e01 (flutter/flutter#176119) 2025-09-29 [email protected] Rename DisplayMonitor to DisplayManager on Win32 (flutter/flutter#175619) 2025-09-29 [email protected] [Android] Use headingLevel for heading accessibility property (flutter/flutter#175416) 2025-09-29 [email protected] BUILD.gn: Support LTO build on Linux (flutter/flutter#176191) 2025-09-29 [email protected] fix `assertEquals` arguments are in wrong order in `FlutterJNITest.java` (flutter/flutter#175728) 2025-09-29 [email protected] Add tests for `Project` getters (flutter/flutter#175994) 2025-09-29 [email protected] Roll Fuchsia Linux SDK from 8zjcJic_DtvB2Bo2x... to rcOl0yxJb4znJ903Y... (flutter/flutter#176215) 2025-09-29 [email protected] Clean up typos in `PlatformViewsControllerTest.java` (flutter/flutter#175725) 2025-09-29 [email protected] Migrate java 11 usage to java 17 usage for templates (flutter/flutter#176203) 2025-09-29 [email protected] User Invoke-Expression instead of call operator for nested Powershell scripts invocations (on Windows) (flutter/flutter#175941) 2025-09-29 [email protected] Update changelog as on 3.35 branch (flutter/flutter#176216) 2025-09-29 [email protected] fix typo in `Crashes.md` (flutter/flutter#175959) 2025-09-29 [email protected] Add scene plugin lifecycle events (flutter/flutter#175866) 2025-09-29 [email protected] Migrate tests and documentation to set java version to 17 (flutter/flutter#176204) 2025-09-29 [email protected] Update Engine CI to use NDK r28c (flutter/flutter#175870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
I accidentally only made the changelog updates on the release branch (flutter#176103), but it seems it should have been done on master.
I accidentally only made the changelog updates on the release branch (flutter#176103), but it seems it should have been done on master.
I accidentally only made the changelog updates on the release branch (#176103), but it seems it should have been done on master.