[CP] Flutter analyze --suggestions update for 3.35#176359
Merged
auto-submit[bot] merged 5 commits intoflutter-3.35-candidate.0from Oct 7, 2025
Merged
[CP] Flutter analyze --suggestions update for 3.35#176359auto-submit[bot] merged 5 commits intoflutter-3.35-candidate.0from
auto-submit[bot] merged 5 commits intoflutter-3.35-candidate.0from
Conversation
Gradle 9.1.0 was released on 2025-09-18. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].
…175808) Update the maxKnownAndSupported versions of Java (now 26), AGP (from 8.9.1 to 8.13), and Gradle (now 9.1). Add tests for new codepaths and expand existing test coverage. Some typos and changes to aid debugging included as well. AGP 9 was made available for preview last week https://developer.android.com/build/releases/agp-preview. Fixes: #175669 Commits: - **update max known and supported java, gradle and agp** - **make tests in a loop and add testing for get java version for and validate java and agp** - **move some tests to gradle_utils, make debugging easier** - **Migrated gradle_utils tests from gradle_test to gradle_utils_test** --------- Co-authored-by: Camille Simon <[email protected]>
This pr assumes #176049 lands first. - **Update java version ranges with the top end limitation for java pre 17** - **change default for unknown agp version to true for java support** - **Add kotlin 2.2* support for analyze --suggestions** - Related to #175669 and #176027 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
#176049) Related to #175669 and #176027 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
github-actions
bot
added
a: tests
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
removed
a: tests
github-actions
bot
removed
f: material design
mboetger
approved these changes
Oct 1, 2025
camsim99
approved these changes
Oct 7, 2025
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
LGTM let's get this in a hotfix :)
camsim99
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
Updates `CHANGELOG` to include the two cherry picks in the 3.35.6 hotfix stable release: #176520 #176359 **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
IslamHossamHO
pushed a commit
to IslamHossamHO/Assesment-Flutter
that referenced
this pull request
Nov 24, 2025
Updates `CHANGELOG` to include the two cherry picks in the 3.35.6 hotfix stable release: flutter/flutter#176520 flutter/flutter#176359 **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175669
Changelog entry
flutter analyze --suggestionsinclude compatibility info for Gradle 9.1, AGP 9.0, Java 25 and Kotlin 2.2.20 and below.Cherry pick the following prs.
Cherry pick info:
Yes this is covered by tests.
Risk: low, this code is run as part of a seldom used command and any bugs are likely better than false negatives.
Pre-launch Checklist
///).