Conversation
Changes to the Dart IO require picking up newer version of watcher.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades three package dependencies: watcher to 1.1.4, native_toolchain_c to 0.17.2, and video_player_android to 2.8.14. The changes are reflected in the pubspec.yaml and pubspec.lock files, and the updates are applied consistently. For better maintainability, I recommend expanding the pull request description to include all updated packages, as this provides a more complete context for the change.
flutter-dashboard
bot
removed
the
autosubmit
|
test-exempt: rolling dependencies (@aam In the future, if there's a time-critical reason to land a PR without following normal process, please comment in the issue to explain the reason for bypassing the process.) |
@stuartmorgan-g not sure I understand - which aspect of this PR didn't follow normal process? It's a roll dependency PR, it relies on CI tests, it was reviewed, approved and I added 'autosubmit' label for it to get merged in. |
|
This one, from the bot comment above:
See https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests for details. In particular:
@mraleph requseted an exemption in Discord, following the process, but the PR shouldn't have landed until it actually had one. |
Manual roll requested by [email protected] flutter/flutter@65aca36...5c0c9e9 2025-10-03 [email protected] Roll Packages from 5fd5f74 to e401aeb (4 revisions) (flutter/flutter#176466) 2025-10-03 [email protected] Roll Dart SDK from fdd90f38d6a0 to 0009748aed50 (3 revisions) (flutter/flutter#176461) 2025-10-03 [email protected] Roll Skia from f86ae4113254 to b842026480e0 (3 revisions) (flutter/flutter#176458) 2025-10-03 [email protected] Roll Skia from 1720a85a507e to f86ae4113254 (1 revision) (flutter/flutter#176443) 2025-10-03 [email protected] Roll Fuchsia Linux SDK from Vnoygds8HtDUvGLCK... to HUhTcRn-LUXa2Salu... (flutter/flutter#176442) 2025-10-03 [email protected] Roll Skia from cf339ab390c2 to 1720a85a507e (4 revisions) (flutter/flutter#176439) 2025-10-03 [email protected] Roll Dart SDK from 4f90a06328cb to fdd90f38d6a0 (7 revisions) (flutter/flutter#176431) 2025-10-02 [email protected] Roll Skia from 05c1f5803415 to cf339ab390c2 (11 revisions) (flutter/flutter#176426) 2025-10-02 [email protected] Add deeplinking for UIScene migration (flutter/flutter#176303) 2025-10-02 [email protected] Upgrade packages (flutter/flutter#176411) 2025-10-02 [email protected] Update localization from translation console (flutter/flutter#176324) 2025-10-02 [email protected] Update Framework CI to Use NDK r28c (flutter/flutter#176214) 2025-10-02 [email protected] Remove references to dart:js_util (flutter/flutter#176323) 2025-10-02 [email protected] Roll Packages from 321a584 to 5fd5f74 (6 revisions) (flutter/flutter#176409) 2025-10-02 [email protected] Windowing integration tests now await change futures if a changes is expected + commenting our erroneous icon in Runner.rc for win32 (flutter/flutter#176312) 2025-10-02 [email protected] Fix platform specific semantics for time picker buttons (flutter/flutter#176373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changes to the Dart IO require picking up newer version of `package:watcher`.
Changes to the Dart IO require picking up newer version of `package:watcher`.
Changes to the Dart IO require picking up newer version of `package:watcher`.
4 participants
Changes to the Dart IO require picking up newer version of
package:watcher.