Use dart::bin::SetupDartIo to setup dart:io#176714
Use dart::bin::SetupDartIo to setup dart:io#176714auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the dart:io setup to use the centralized dart::bin::SetupDartIoLibrary function, which is a good simplification. I've found one issue regarding an unused parameter that seems important for network security. Please see my detailed comment.
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Greetings from stale PR triage! 👋 |
mraleph
force-pushed
the
reduce-duplication-in-embedder
branch
5 times, most recently
from
1ef8cdd to
aafeab2
Compare
mraleph
force-pushed
the
reduce-duplication-in-embedder
branch
from
aafeab2 to
978015d
Compare
mraleph
force-pushed
the
reduce-duplication-in-embedder
branch
from
978015d to
174de9e
Compare
There was a problem hiding this comment.
Code Review
This pull request refactors the dart:io initialization to use the centralized dart::bin::SetupDartIoLibrary function. This simplifies the engine code by removing manual setup of native resolvers, hooks, and other properties, delegating this responsibility to the Dart SDK. The changes look good and improve code maintainability. I've found one minor issue regarding an unused parameter after the refactoring.
| void DartIO::InitForIsolate(bool may_insecurely_connect_to_all_domains, | ||
| const std::string& domain_network_policy) { | ||
| // TODO(https://dartbug.com/61694): move this code into dart_io_api.h | ||
| Dart_Handle io_lib = Dart_LookupLibrary(ToDart("dart:io")); | ||
| Dart_Handle result = Dart_SetNativeResolver(io_lib, dart::bin::LookupIONative, | ||
| dart::bin::LookupIONativeSymbol); | ||
| FML_CHECK(!CheckAndHandleError(result)); | ||
| result = Dart_SetFfiNativeResolver(io_lib, dart::bin::LookupIOFfiNative); | ||
| FML_CHECK(!CheckAndHandleError(result)); | ||
|
|
||
| const std::string& domain_network_policy, | ||
| const std::string& script_uri) { |
There was a problem hiding this comment.
The domain_network_policy parameter is unused within this function following the refactoring. It should be removed to keep the API clean and avoid confusion.
This change will require corresponding updates to:
- The function declaration in
engine/src/flutter/lib/io/dart_io.h. - The call site in
engine/src/flutter/runtime/dart_isolate.cc.
void DartIO::InitForIsolate(bool may_insecurely_connect_to_all_domains,
const std::string& script_uri) {References
- The repository style guide (line 43) mandates following the Google C++ Style Guide, which recommends removing unused function parameters. (link)
flutter-dashboard
bot
removed
the
autosubmit
Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) flutter/flutter@46fb721...d3dd774 2026-03-04 [email protected] Show warning when plugins do not support SwiftPM (flutter/flutter#182506) 2026-03-04 [email protected] Give guided message when project is not compatible with SwiftPM (flutter/flutter#182394) 2026-03-04 [email protected] Pass --web-define through to web runner when using --machine mode (flutter/flutter#183228) 2026-03-04 [email protected] Improve SwiftPM minimum platform mismatch diagnostics (flutter/flutter#182375) 2026-03-04 [email protected] Use dart::bin::SetupDartIo to setup dart:io (flutter/flutter#176714) 2026-03-04 [email protected] Roll Skia from 3197848b14ad to ada0b7628c79 (5 revisions) (flutter/flutter#183221) 2026-03-04 [email protected] Roll Skia from fe9e9f22c531 to 3197848b14ad (15 revisions) (flutter/flutter#183198) 2026-03-04 [email protected] refactor: remove material in reorderable_list_test, scroll_notification_test, scroll_physics_test, shortcuts_test, sliver_floating_header_test, snapshot_widget_test (flutter/flutter#182698) 2026-03-04 [email protected] refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699) 2026-03-04 [email protected] Add dev/benchmarks/README.md (flutter/flutter#182976) 2026-03-03 [email protected] Roll RapidJSON to a branch based on the current upstream head (flutter/flutter#183048) 2026-03-03 [email protected] [Impeller] Update comments to reflect new info about 2-pass rendering (flutter/flutter#183050) 2026-03-03 [email protected] Add vmservices for accessibilityEvaluation (flutter/flutter#182791) 2026-03-03 [email protected] Roll Fuchsia Linux SDK from 0dCDM2oORHwDf_pyb... to JJw5EJ87vLGqFVl4h... (flutter/flutter#183177) 2026-03-03 [email protected] Support mixed color spaces in `Color.lerp` (flutter/flutter#182934) 2026-03-03 [email protected] Add warning when there is a widget with color between `Material` and `ListTile` (flutter/flutter#181402) 2026-03-03 [email protected] [ios]uitest for admob banner in scrollable list gesture issue (flutter/flutter#183128) 2026-03-03 [email protected] Roll Packages from faa4e22 to 9083bc9 (4 revisions) (flutter/flutter#183164) 2026-03-03 [email protected] Build App and native asset frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183136) 2026-03-03 [email protected] Roll Skia from f886711f180d to fe9e9f22c531 (4 revisions) (flutter/flutter#183155) 2026-03-03 [email protected] Roll Dart SDK from e86dbe9aa742 to c597ef90d2dc (2 revisions) (flutter/flutter#183147) 2026-03-03 [email protected] fix: bump matcher (flutter/flutter#183167) 2026-03-02 [email protected] Use isA to test for exceptions (flutter/flutter#183129) 2026-03-02 [email protected] [two_dimensional_scrollables] Fix tableview janks when first row/column pinned (flutter/flutter#180563) 2026-03-02 [email protected] Add await to callsites of BasicMessageChannel.send (flutter/flutter#182868) 2026-03-02 [email protected] Roll pub packages (flutter/flutter#183133) 2026-03-02 [email protected] Improve FFI code for windowing (flutter/flutter#183098) 2026-03-02 [email protected] [workflow] Update the changelog merge action to fetch the stable branch (flutter/flutter#183132) 2026-03-02 [email protected] Roll Skia from e180358b7a7a to f886711f180d (2 revisions) (flutter/flutter#183130) 2026-03-02 [email protected] Merge changelog from 3.41.3. (flutter/flutter#183131) 2026-03-02 [email protected] Make TextDecoration final and unify maskValue across platforms (flutter/flutter#183070) 2026-03-02 [email protected] Roll pub packages (flutter/flutter#182640) 2026-03-02 [email protected] Enable SwiftPM by default on master and beta (flutter/flutter#182923) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...
3 participants
WIP