Update engine.version#176799
Update engine.version#176799auto-submit[bot] merged 2 commits intoflutter:flutter-3.38-candidate.0from
engine.version#176799Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Hmm the release builder ran on this commit so I thought the test would pass? |
|
In the meantime, running postsubmits on the previous commit. I did this by accident but there are actual errors, e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20verify_binaries_codesigned/628/overview and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1305670/overview I may need to dig into this first. |
|
Release builder is required to build all the binaries? I can't see the results, but |
|
59c4900 is not a valid githash... 404: 59c4900 curl --head https://storage.googleapis.com/flutter_infra_release/flutter/59c4900ce5d1ecf691330e7e6abc7d5821feffd2/flutter-web-sdk.zip
HTTP/2 404
content-type: application/xml; charset=UTF-8
x-guploader-uploadid: AAwnv3J44F-ZcuoS1vzDq4kYfDbpL8z_h0f3gCl3XGNlYS9YkiOKn9mGRrmaKnKym7xiyo4gL6V94AI
content-length: 252
access-control-allow-origin: *
access-control-expose-headers: Content-Type
date: Thu, 09 Oct 2025 19:54:10 GMT
expires: Thu, 09 Oct 2025 19:54:10 GMT
cache-control: private, max-age=0
server: UploadServer
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000 |
|
Looks like you're talking about https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1305670/overview. Do you know where that commit is even coming from? |
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
I was able to push a commit to update the hash 👍
justinmc
added
the
autosubmit
auto-submit
bot
merged commit 2d15161
into
flutter:flutter-3.38-candidate.0
The version I set in #176799 was incorrect so the release build failed. This updates it to the correct engine version.
3 participants
Sets
engine.versionto release build from 3eead6b. Part of #176744Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.