Some cleanup of cross library test imports by justinmc · Pull Request #177029 · flutter/flutter

justinmc · 2025-10-14T20:30:47Z

There is a lot of cross-library importing in the framework unit tests that I'd like to clean up, see the design doc for more: https://docs.google.com/document/d/1UHxALQqCbmgjnM1RNV9xE2pK3IGyx-UktGX1D7hYCjs/edit?tab=t.0

This PR cleans up a few obvious instances and adds TODOs for others. I created this while doing an investigation for the design doc linked above. I hope that we'll be able to follow up with fixes for all of the problematic tests (tracked in the issue below).

Part of #177028

flutter-dashboard · 2025-12-25T18:03:53Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

huycozy · 2025-12-30T10:47:34Z

I only want to inform that I'm looking at the umbrella issue (and its sub-issues too) and would like to give a hand to complete the remaining work. Hope this PR can be merged more quickly. This will help to determine the remaining tasks for the sub-issues outlined in #177028. It would be appreciated if completed items can be marked as done there, so that we can check the status of the list better. Thank you! 🙏

This PR adds a lint rule to catch imports between Material, Cupertino, and Widgets in tests. Spun out of #177029 and the [Decoupling Tests design doc](https://docs.google.com/document/d/1UHxALQqCbmgjnM1RNV9xE2pK3IGyx-UktGX1D7hYCjs/edit?pli=1&tab=t.0). For now, Material will be the place to put tests that need to import both Material and Cupertino. See #178693 (comment). I used #130523 as a reference to create this PR. --------- Co-authored-by: Loïc Sharma <[email protected]>

justinmc · 2025-12-30T20:53:33Z

Thank you for the support @huycozy! I just landed the lint PR #178693 that was blocking this. I'm going to update this PR and make sure it works with the lint, then everyone should be good to start working on #177028.

However, there are some test helpers that I would love to get written to make some of these tests easier. For example, @Renzo-Olivares was looking at writing a test helper wrapping EditableText to make it easier to use. The same thing is probably needed for WidgetsApp.

I'll respond on #177028 and the sub-issues with more details.

justinmc · 2026-01-02T18:06:15Z

Indeed the analyzer has failed due to the lint I added in #178693. The cross imports that I fixed in this PR now need to be removed from the allowlist. I'll do that now and then it should pass.

Analyzer error

╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ Huzzah! The following tests in Widgets no longer contain cross imports!
║   packages/flutter/test/widgets/async_lifecycle_test.dart
║   packages/flutter/test/widgets/multi_view_parent_data_test.dart
║   packages/flutter/test/widgets/view_test.dart
║   packages/flutter/test/widgets/slotted_render_object_widget_test.dart
║   packages/flutter/test/widgets/semantics_2_test.dart
║   packages/flutter/test/widgets/reparent_state_test.dart
║   packages/flutter/test/widgets/transitions_test.dart
║   packages/flutter/test/widgets/parent_data_test.dart
║   packages/flutter/test/widgets/binding_live_test.dart
║   packages/flutter/test/widgets/list_view_fling_test.dart
║   packages/flutter/test/widgets/selectable_text_test.dart
║   packages/flutter/test/widgets/semantics_7_test.dart
║   packages/flutter/test/widgets/opacity_repaint_test.dart
║   packages/flutter/test/widgets/list_view_relayout_test.dart
║   packages/flutter/test/widgets/semantics_4_test.dart
║   packages/flutter/test/widgets/multi_view_binding_test.dart
║   packages/flutter/test/widgets/binding_deferred_first_frame_test.dart
║   packages/flutter/test/widgets/scroll_delegate_test.dart
║   packages/flutter/test/widgets/list_view_correction_test.dart
║   packages/flutter/test/widgets/semantics_zero_surface_size_test.dart
║   packages/flutter/test/widgets/semantics_9_test.dart
║   packages/flutter/test/widgets/icon_data_test.dart
║   packages/flutter/test/widgets/semantics_refactor_regression_test.dart
║   packages/flutter/test/widgets/animated_opacity_repaint_test.dart
║   packages/flutter/test/widgets/semantics_6_test.dart
║   packages/flutter/test/widgets/animated_image_filtered_repaint_test.dart
║   packages/flutter/test/widgets/tree_shape_test.dart
║   packages/flutter/test/widgets/rich_text_test.dart
║   packages/flutter/test/widgets/sensitive_content_error_handling_test.dart
║   packages/flutter/test/widgets/drag_boundary_test.dart
║   packages/flutter/test/widgets/semantics_traversal_test.dart
║   packages/flutter/test/widgets/sensitive_content_unknown_test.dart
║   packages/flutter/test/widgets/overlay_test.dart
║   packages/flutter/test/widgets/semantics_8_test.dart
║   packages/flutter/test/widgets/sliver_fill_viewport_test.dart
║   packages/flutter/test/widgets/wrap_test.dart
║   packages/flutter/test/widgets/overlay_portal_test.dart
║   packages/flutter/test/widgets/semantics_11_test.dart
║   packages/flutter/test/widgets/binding_first_frame_rasterized_test.dart
║   packages/flutter/test/widgets/router_restoration_test.dart
║   packages/flutter/test/widgets/error_widget_test.dart
║   packages/flutter/test/widgets/semantics_checks_test.dart
║   packages/flutter/test/widgets/sensitive_content_test.dart
║   packages/flutter/test/widgets/semantics_10_test.dart
║   packages/flutter/test/widgets/semantics_1_test.dart
║   packages/flutter/test/widgets/sensitive_content_host_test.dart
║   packages/flutter/test/widgets/default_colors_test.dart
║   packages/flutter/test/widgets/multi_view_tree_updates_test.dart
║   packages/flutter/test/widgets/semantics_5_test.dart
║   packages/flutter/test/widgets/clip_test.dart
║   packages/flutter/test/widgets/independent_widget_layout_test.dart
║   packages/flutter/test/widgets/binding_first_frame_developer_test.dart
║   packages/flutter/test/widgets/multi_view_no_implicit_view_binding_test.dart
║   packages/flutter/test/widgets/reparent_state_with_layout_builder_test.dart
║   packages/flutter/test/widgets/semantics_3_test.dart
║   packages/flutter/test/widgets/sliver_appbar_opacity_test.dart
║   packages/flutter/test/widgets/sliver_constrained_cross_axis_test.dart
║   packages/flutter/test/widgets/focus_manager_test.dart
║   packages/flutter/test/widgets/implicit_semantics_test.dart
║   packages/flutter/test/widgets/shrink_wrapping_viewport_test.dart
║ However, they now need to be removed from the
║ knownWidgetsCrossImports list in the script /dev/bots/check_tests_cross_imports.dart.
╚═══════════════════════════════════════════════════════════════════════════════
╔═╡ERROR #2╞════════════════════════════════════════════════════════════════════
║ Huzzah! The following tests in Cupertino no longer contain cross imports!
║   packages/flutter/test/cupertino/action_sheet_test.dart
║ However, they now need to be removed from the
║ knownCupertinoCrossImports list in the script /dev/bots/check_tests_cross_imports.dart.
╚═══════════════════════════════════════════════════════════════════════════════

…77029)

@OverRide

Roll Flutter from 60d8165 to 13b2b91 (34 revisions) flutter/flutter@60d8165...13b2b91 2026-01-03 [email protected] Roll Skia from 229239fde9e9 to 2f257bbea23a (1 revision) (flutter/flutter#180461) 2026-01-03 [email protected] Roll Dart SDK from be125a188f41 to 8e711d05b844 (1 revision) (flutter/flutter#180460) 2026-01-03 [email protected] Roll Dart SDK from 0e6419d14382 to be125a188f41 (1 revision) (flutter/flutter#180454) 2026-01-02 [email protected] Roll Dart SDK from 5e4b7dc3a134 to 0e6419d14382 (4 revisions) (flutter/flutter#180449) 2026-01-02 [email protected] Roll Skia from 5a8d480365e2 to 229239fde9e9 (9 revisions) (flutter/flutter#180448) 2026-01-02 [email protected] Relands "Feat: Add a11y for loading indicators (#165173)" (flutter/flutter#178402) 2026-01-02 [email protected] Add SK_SUPPORT_LEGACY_UNSPANNED_GRADIENTS to SkUserConfig.h (flutter/flutter#180443) 2026-01-02 [email protected] Some cleanup of cross library test imports (flutter/flutter#177029) 2026-01-02 [email protected] Roll Dart SDK from df175c998021 to 5e4b7dc3a134 (1 revision) (flutter/flutter#180366) 2026-01-02 [email protected] Roll Fuchsia Linux SDK from nzgy72aZ9kvHxTDM6... to 1pPgo5DrQ5ITdz3Uy... (flutter/flutter#180438) 2026-01-01 [email protected] Roll Fuchsia Linux SDK from 23suNuzNQCwRbDrys... to nzgy72aZ9kvHxTDM6... (flutter/flutter#180424) 2025-12-31 [email protected] Remove @OverRide annotations from things which are not overrides (flutter/flutter#180417) 2025-12-31 [email protected] Roll Fuchsia Linux SDK from t1eBl_kzKGV5K28OU... to 23suNuzNQCwRbDrys... (flutter/flutter#180409) 2025-12-31 [email protected] Roll Skia from 8851d5318c9d to 5a8d480365e2 (1 revision) (flutter/flutter#180400) 2025-12-31 [email protected] Make sure that a DecoratedBox doesn't crash in 0x0 environment (flutter/flutter#180329) 2025-12-31 [email protected] Roll Skia from d0e12d575173 to 8851d5318c9d (2 revisions) (flutter/flutter#180399) 2025-12-31 [email protected] Improve Container color/decoration error message clarity (flutter/flutter#178823) 2025-12-30 [email protected] Make sure that a CheckedModeBanner doesn't crash in 0x0 environment (flutter/flutter#180280) 2025-12-30 [email protected] Roll Skia from 32c27424accb to d0e12d575173 (1 revision) (flutter/flutter#180394) 2025-12-30 [email protected] [Framework] iOS style blurring and `ImageFilterConfig` (flutter/flutter#175473) 2025-12-30 [email protected] Fix issue with getUniformFloat crashing with hot reload (flutter/flutter#180138) 2025-12-30 [email protected] Test cross import lint (flutter/flutter#178693) 2025-12-30 [email protected] Roll Skia from d64da765cee6 to 32c27424accb (1 revision) (flutter/flutter#180393) 2025-12-30 [email protected] Roll Skia from 4c438e0537fc to d64da765cee6 (1 revision) (flutter/flutter#180390) 2025-12-30 [email protected] Roll Packages from b3c3ca8 to 30dd810 (1 revision) (flutter/flutter#180388) 2025-12-30 [email protected] Roll Skia from 27b587c4b160 to 4c438e0537fc (1 revision) (flutter/flutter#180384) 2025-12-30 [email protected] Roll Fuchsia Linux SDK from DdllqZRZYriOd7Q8v... to t1eBl_kzKGV5K28OU... (flutter/flutter#180378) 2025-12-30 [email protected] Roll Skia from 11690456a90d to 27b587c4b160 (1 revision) (flutter/flutter#180377) 2025-12-30 [email protected] Allow setting vector uniforms by name. (flutter/flutter#179927) 2025-12-30 [email protected] Roll Skia from 7abf754bce14 to 11690456a90d (6 revisions) (flutter/flutter#180374) 2025-12-29 [email protected] Add support for Shift-Delete, Ctrl-Insert and Shift-Insert (flutter/flutter#178561) 2025-12-29 [email protected] Roll Skia from c85d3e2b12d7 to 7abf754bce14 (1 revision) (flutter/flutter#180371) 2025-12-29 [email protected] Roll Packages from 2164da9 to b3c3ca8 (2 revisions) (flutter/flutter#180365) 2025-12-29 [email protected] Roll Skia from c29a475066f5 to c85d3e2b12d7 (1 revision) (flutter/flutter#180363) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

…77029)

@OverRide

Roll Flutter from 60d8165 to 13b2b91 (34 revisions) flutter/flutter@60d8165...13b2b91 2026-01-03 [email protected] Roll Skia from 229239fde9e9 to 2f257bbea23a (1 revision) (flutter/flutter#180461) 2026-01-03 [email protected] Roll Dart SDK from be125a188f41 to 8e711d05b844 (1 revision) (flutter/flutter#180460) 2026-01-03 [email protected] Roll Dart SDK from 0e6419d14382 to be125a188f41 (1 revision) (flutter/flutter#180454) 2026-01-02 [email protected] Roll Dart SDK from 5e4b7dc3a134 to 0e6419d14382 (4 revisions) (flutter/flutter#180449) 2026-01-02 [email protected] Roll Skia from 5a8d480365e2 to 229239fde9e9 (9 revisions) (flutter/flutter#180448) 2026-01-02 [email protected] Relands "Feat: Add a11y for loading indicators (#165173)" (flutter/flutter#178402) 2026-01-02 [email protected] Add SK_SUPPORT_LEGACY_UNSPANNED_GRADIENTS to SkUserConfig.h (flutter/flutter#180443) 2026-01-02 [email protected] Some cleanup of cross library test imports (flutter/flutter#177029) 2026-01-02 [email protected] Roll Dart SDK from df175c998021 to 5e4b7dc3a134 (1 revision) (flutter/flutter#180366) 2026-01-02 [email protected] Roll Fuchsia Linux SDK from nzgy72aZ9kvHxTDM6... to 1pPgo5DrQ5ITdz3Uy... (flutter/flutter#180438) 2026-01-01 [email protected] Roll Fuchsia Linux SDK from 23suNuzNQCwRbDrys... to nzgy72aZ9kvHxTDM6... (flutter/flutter#180424) 2025-12-31 [email protected] Remove @OverRide annotations from things which are not overrides (flutter/flutter#180417) 2025-12-31 [email protected] Roll Fuchsia Linux SDK from t1eBl_kzKGV5K28OU... to 23suNuzNQCwRbDrys... (flutter/flutter#180409) 2025-12-31 [email protected] Roll Skia from 8851d5318c9d to 5a8d480365e2 (1 revision) (flutter/flutter#180400) 2025-12-31 [email protected] Make sure that a DecoratedBox doesn't crash in 0x0 environment (flutter/flutter#180329) 2025-12-31 [email protected] Roll Skia from d0e12d575173 to 8851d5318c9d (2 revisions) (flutter/flutter#180399) 2025-12-31 [email protected] Improve Container color/decoration error message clarity (flutter/flutter#178823) 2025-12-30 [email protected] Make sure that a CheckedModeBanner doesn't crash in 0x0 environment (flutter/flutter#180280) 2025-12-30 [email protected] Roll Skia from 32c27424accb to d0e12d575173 (1 revision) (flutter/flutter#180394) 2025-12-30 [email protected] [Framework] iOS style blurring and `ImageFilterConfig` (flutter/flutter#175473) 2025-12-30 [email protected] Fix issue with getUniformFloat crashing with hot reload (flutter/flutter#180138) 2025-12-30 [email protected] Test cross import lint (flutter/flutter#178693) 2025-12-30 [email protected] Roll Skia from d64da765cee6 to 32c27424accb (1 revision) (flutter/flutter#180393) 2025-12-30 [email protected] Roll Skia from 4c438e0537fc to d64da765cee6 (1 revision) (flutter/flutter#180390) 2025-12-30 [email protected] Roll Packages from b3c3ca8 to 30dd810 (1 revision) (flutter/flutter#180388) 2025-12-30 [email protected] Roll Skia from 27b587c4b160 to 4c438e0537fc (1 revision) (flutter/flutter#180384) 2025-12-30 [email protected] Roll Fuchsia Linux SDK from DdllqZRZYriOd7Q8v... to t1eBl_kzKGV5K28OU... (flutter/flutter#180378) 2025-12-30 [email protected] Roll Skia from 11690456a90d to 27b587c4b160 (1 revision) (flutter/flutter#180377) 2025-12-30 [email protected] Allow setting vector uniforms by name. (flutter/flutter#179927) 2025-12-30 [email protected] Roll Skia from 7abf754bce14 to 11690456a90d (6 revisions) (flutter/flutter#180374) 2025-12-29 [email protected] Add support for Shift-Delete, Ctrl-Insert and Shift-Insert (flutter/flutter#178561) 2025-12-29 [email protected] Roll Skia from c85d3e2b12d7 to 7abf754bce14 (1 revision) (flutter/flutter#180371) 2025-12-29 [email protected] Roll Packages from 2164da9 to b3c3ca8 (2 revisions) (flutter/flutter#180365) 2025-12-29 [email protected] Roll Skia from c29a475066f5 to c85d3e2b12d7 (1 revision) (flutter/flutter#180363) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

…77029)

justinmc added 5 commits October 14, 2025 11:37

Unnecessary use of Material localizations

ad58371

This will never build a Material Scrollbar

e548e5d

TODOs

d04d64f

This will never build a Material Scrollbar, either.

a2077ff

Rest of Cupertino TODOs

b0cc0c8

justinmc self-assigned this Oct 14, 2025

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Oct 14, 2025

No need for cupertino, probably a result of copying

fff08f6

github-actions bot added the f: material design flutter/packages/flutter/material repository. label Oct 14, 2025

justinmc added 2 commits October 14, 2025 14:35

Some Widgets todos

76006ba

SelectableText is a Material widget

1591a92

github-actions bot added the f: routes Navigator, Router, and related APIs. label Oct 14, 2025

justinmc added 16 commits October 15, 2025 09:30

Unused Cupertino

9564156

TODO for Cupertino in Widgets

5e1eed6

Unnecessary Material imports

cb82095

Should have been in Material

9bd4e61

Colors => Color

7834b6a

Unnecessary Material imports

7d3d533

Colors => Color

4eb73c6

Unnecessary Material import(s)

e95aeca

I guess I messed up that comment at some point...

6ae4df8

Unnecessary Material imports

9e204ea

Green

31217cb

Unnecessary Material imports

e2642bb

Unnecessary Material imports

92fc96e

Colors

df3f430

Unnecessary Material import

702a220

Colors.green

1fd07b7

justinmc added 3 commits December 30, 2025 14:38

Merge branch 'master' into cross-library-test-imports

9de6595

Merge branch 'master' into cross-library-test-imports

40c1548

Analyzer

3f6451e

justinmc added 2 commits January 2, 2026 10:09

Remove tests from allowlist whose cross import is fixed

e5acd9e

Now that typing lint has changed, update types on my Colors.

ec436ca

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2026

auto-submit bot added this pull request to the merge queue Jan 2, 2026

This was referenced Jan 2, 2026

(Test cross-imports) Tests should go in the library that they're testing #177414

Open

(Test cross-imports) Don't import Material in tests for convenience #177415

Open

Merged via the queue into flutter:master with commit bef11d2 Jan 2, 2026
149 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2026

justinmc deleted the cross-library-test-imports branch January 2, 2026 22:00

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2026

bef11d2 Some cleanup of cross library test imports (flutter/flutter#1…

d386a62

…77029)

This was referenced Jan 3, 2026

Roll Flutter from 60d8165b11e2 to 13b2b912c909 (34 revisions) flutter/packages#10708

Closed

Roll Flutter from 60d8165b11e2 to 13b2b912c909 (34 revisions) flutter/packages#10709

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2026

bef11d2 Some cleanup of cross library test imports (flutter/flutter#1…

cabef27

…77029)

engine-flutter-autoroll mentioned this pull request Jan 4, 2026

Roll Flutter from 60d8165b11e2 to 89791c381ae9 (36 revisions) flutter/packages#10710

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2026

bef11d2 Some cleanup of cross library test imports (flutter/flutter#1…

ff9c64d

…77029)

Piinks added this to Test cross-imports Review Queue Feb 10, 2026

github-project-automation bot moved this to Todo in Test cross-imports Review Queue Feb 10, 2026

github-project-automation bot moved this from Todo to Done in Test cross-imports Review Queue Feb 10, 2026

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

bef11d2 Some cleanup of cross library test imports (flutter/flutter#1…

6a2ce0f

…77029)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some cleanup of cross library test imports#177029

Some cleanup of cross library test imports#177029
auto-submit[bot] merged 52 commits intoflutter:masterfrom
justinmc:cross-library-test-imports

justinmc commented Oct 14, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Dec 25, 2025

Uh oh!

huycozy commented Dec 30, 2025

Uh oh!

justinmc commented Dec 30, 2025

Uh oh!

justinmc commented Jan 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

justinmc commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Dec 25, 2025

Uh oh!

huycozy commented Dec 30, 2025

Uh oh!

justinmc commented Dec 30, 2025

Uh oh!

justinmc commented Jan 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

justinmc commented Oct 14, 2025 •

edited

Loading