Fix create_updated_flutter_deps.py#177067
Conversation
Make sure that perfetto dependency is in Dart section. Fix the logic in the script which produced incorrectly quoted strings.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in create_updated_flutter_deps.py where dependency strings were not being quoted correctly. The change introduces logic to prepend a quote to dependency values that are not modified to use a Var() expression, fixing the issue of generating invalid DEPS file content. The fix is correct and well-contained. I have no further comments.
|
test-exempt: utility script whose output is validated as part of the build |
3 participants
I am not entirely sure who still uses this script. Dart monorepo has a custom copy, which I am going to fix as well.