feat(table): add support for colSpan and rowSpan in TableCell by hm21 · Pull Request #177102 · flutter/flutter

hm21 · 2025-10-16T15:37:33Z

Description

This PR adds support for colSpan and rowSpan to the TableCell widget.
With this change, each TableCell can now span multiple columns and/or rows, similar to how HTML tables work.

This allows developers to create more flexible and complex table layouts without manually merging cells or resorting to nested tables.

Examples

Example 1

Table(
  border: TableBorder.all(color: Colors.grey),
  columnWidths: const <int, TableColumnWidth>{
    0: FixedColumnWidth(120),
    1: FlexColumnWidth(),
    2: FlexColumnWidth(),
  },
  children: <TableRow>[
    const TableRow(
      decoration: BoxDecoration(color: Color(0xFFE0E0E0)),
      children: <Widget>[
        TableCell(
          colSpan: 3,
          child: Padding(
            padding: EdgeInsets.all(8),
            child: Text(
              'Invoice Summary',
              style: TextStyle(fontSize: 18, fontWeight: FontWeight.bold),
              textAlign: TextAlign.center,
            ),
          ),
        ),
        TableCell.none,
        TableCell.none,
      ],
    ),
    const TableRow(
      decoration: BoxDecoration(color: Color(0xFFF5F5F5)),
      children: <Widget>[
        Padding(padding: EdgeInsets.all(8), child: Text('Customer')),
        TableCell(
          colSpan: 2,
          child: Padding(padding: EdgeInsets.all(8), child: Text('Alex Frei')),
        ),
        TableCell.none,
      ],
    ),
    const TableRow(
      children: <Widget>[
        Padding(padding: EdgeInsets.all(8), child: Text('Date')),
        Padding(padding: EdgeInsets.all(8), child: Text('16 Oct 2025')),
        Padding(padding: EdgeInsets.all(8), child: Text('Invoice #1024')),
      ],
    ),
    const TableRow(
      decoration: BoxDecoration(color: Color(0xFFE0E0E0)),
      children: <Widget>[
        TableCell(
          colSpan: 3,
          child: Padding(
            padding: EdgeInsets.all(8),
            child: Text('Items', style: TextStyle(fontWeight: FontWeight.bold)),
          ),
        ),
        TableCell.none,
        TableCell.none,
      ],
    ),
    const TableRow(
      children: <Widget>[
        Padding(padding: EdgeInsets.all(8), child: Text('Development Work')),
        Padding(padding: EdgeInsets.all(8), child: Text('10 hours')),
        Padding(padding: EdgeInsets.all(8), child: Text(r'$500')),
      ],
    ),
    const TableRow(
      children: <Widget>[
        Padding(padding: EdgeInsets.all(8), child: Text('Design Work')),
        Padding(padding: EdgeInsets.all(8), child: Text('5 hours')),
        Padding(padding: EdgeInsets.all(8), child: Text(r'$250')),
      ],
    ),
    TableRow(
      children: <Widget>[
        TableCell(
          rowSpan: 2,
          verticalAlignment: TableCellVerticalAlignment.fill,
          child: Container(
            color: const Color(0xFFF5F5F5),
            padding: const EdgeInsets.all(8),
            child: const Text('Notes'),
          ),
        ),
        const TableCell(
          colSpan: 2,
          child: Padding(
            padding: EdgeInsets.all(8),
            child: Text('Thank you for your business!'),
          ),
        ),
        TableCell.none,
      ],
    ),
    const TableRow(
      children: <Widget>[
        TableCell.none,
        TableCell(
          colSpan: 2,
          child: Padding(padding: EdgeInsets.all(8), child: Text('Payment due in 14 days.')),
        ),
        TableCell.none,
      ],
    ),
  ],
)

Example 2

Table(
  border: TableBorder.all(),
  children: <TableRow>[
    TableRow(
      children: <Widget>[
        TableCell(
          rowSpan: 3,
          verticalAlignment: TableCellVerticalAlignment.fill,
          child: Container(color: Colors.blue),
        ),
        TableCell(colSpan: 2, child: Container(color: Colors.pink, height: 50)),
        TableCell.none,
      ],
    ),
    TableRow(
      children: <Widget>[
        TableCell.none,
        TableCell(child: Container(color: Colors.green, height: 50)),
        TableCell(
          verticalAlignment: TableCellVerticalAlignment.bottom,
          rowSpan: 2,
          child: Container(color: Colors.orange, height: 75),
        ),
      ],
    ),
    TableRow(
      children: <Widget>[
        TableCell.none,
        TableCell(child: Container(color: Colors.purple, height: 50)),
        TableCell.none,
      ],
    ),
  ],
);

Issues Fixed

Fixes #21594

Questions for Reviewers

This PR introduces the static constant TableCell.none to represent a skipped cell (for when another cell uses rowSpan or colSpan). I’m not sure if none is the best name, alternatives like placeholder or skipped might also fit. I avoided empty since DataCell.empty already exists with different semantics.
Should this feature also be considered for DataTable? I initially didn’t include it cuz the Material Design table doesn’t normally support rowSpan or colSpan.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request introduces a significant and well-implemented feature, adding colSpan and rowSpan support to the Table widget. The changes are comprehensive, covering rendering logic, widget API, border painting, and extensive testing. The implementation includes thoughtful performance optimizations, such as caching span information and using typed data lists. Additionally, the new assertions and detailed error messages will greatly improve the developer experience when working with complex table layouts. Overall, this is a high-quality contribution.

packages/flutter/lib/src/rendering/table.dart

- Enhanced TableCell to include colSpan and rowSpan properties, allowing cells to span multiple columns and rows. - Updated Table widget to validate colSpan and rowSpan values, ensuring they do not exceed table dimensions. - Improved error handling for irregular row lengths and empty TableRow scenarios. - Added tests for colSpan and rowSpan functionality, including edge cases and layout validation. - Updated documentation to reflect new features and usage guidelines for TableCell. refactor(RenderTable): improve comments for column and row span logic

Piinks

Hey @hm21 thanks for contributing! This is a big change, to help facilitate review, would you be willing to draft an outline of your changes and the motivations behind the decisions you made here? We usually do these using this template: https://github.com/flutter/flutter/blob/master/docs/contributing/Design-Documents.md

Piinks · 2025-10-24T22:32:16Z

I am not sure what the implications might be on performance here, have you see the TableView widget that supports cell merging with lazy loading for children?

hm21 · 2025-10-25T11:07:32Z

Hey @Piinks, thanks for the fast response to that PR, really appreciate it cuz I thought it would take way longer for someone to take a look, as my other older PR #176393 is still waiting, but maybe that one’s not very interesting for you guys😅🙈

...would you be willing to draft an outline of your changes and the motivations behind the decisions you made here?

Sure, I can fill it out but not sure I’ll have time this weekend, but definitely next week I should find a bit of time.

I am not sure what the implications might be on performance here, have you see the TableView widget that supports cell merging with lazy loading for children?

I'm not sure, but I guess you're referring to the TableView from the two_dimensional_scrollables package, right? If that's the case, then yes, I know that package. However, I still think there are a few reasons why it makes sense to implement it the way it's done in the PR.

Reasons for that PR

Dependencies: two_dimensional_scrollables is a package on pub.dev and not directly part of Flutter. I think new Flutter devs will expect the Table widget to support that out of the box, without needing to search for an extra package. As seen in Table > TableRow > TableCell colspan #21594, a few hundred people gave a thumbs up to that feature, so it seems like expected behavior should be internal. Also, when we compare it to other popular frameworks like MAUI, Ionic, or NativeScript, that kind of functionality is built-in without any extra dependencies.
Complexity: I think for simple tables, most devs will expect a structure like Table > TableRow > TableCell, since that’s exactly how it works in HTML. In contrast, TableView works differently, the rowBuilder is separated from the cells, which could makes the widget tree harder to understand. Also, in TableViewCell, you have to set both columnMergeSpan and columnMergeStart. That makes sense when using the builder, but for a simple table, it feels a bit off or unnecessarily complicated. In most other frameworks, and even in standard HTML tables, you just set colSpan and rowSpan without needing to define a start position.
Built-in RTL: I'm not 100% sure, but it seems that TableView.builder doesn't handle RTL correctly, or at least in my example, switching to RTL still keeps cell 0,0 on the top-left. Btw the existing Table widget already supports RTL, and the PR just extends that to also respect it for cell spanning.
TableCellVerticalAlignment: Also, not 100% sure, but it seems like verticalAlignment isn’t supported in TableView. In this PR, verticalAlignment still works as expected and it also works correctly with colSpan and rowSpan for each individual cell.
Performance: That's a good point you mentioned. For large tables with many offscreen cells that can be lazy-loaded, TableView.builder will definitely perform better. But for small tables where all cells are visible, I’m pretty sure it’s faster than TableView, though I doubt users would notice any difference. Comparing the original Table code to my changes, there’s a minimal impact on performance, but I don’t think that’s something end users would feel, especially since the Table widget isn’t designed for massive cell counts anyway. I tested it with 10k cells, and it was about 16ms slower, details are in the “Compare-Performance” section below. FYI: if performance is your top priority and readability is less important, I could also rewrite _computeSpanInformation to run directly within the same loop in performLayout. And also the loop inside table_border.dart could I merge.

Compare-Performance

To measure the average render duration, I repeatedly called setState() 100 times.

Test 1: Very Large (10,000 cells: 500 rows × 20 columns)

Version	Avg (ms)	Min (ms)	Max (ms)
Original	351.09	275.40	469.32
PR	367.22	289.07	452.91

Test 2: Large (500 cells: 50 rows × 10 columns)

Version	Avg (ms)	Min (ms)	Max (ms)
Original	42.18	20.29	96.12
PR	49.89	21.50	80.72

Btw, I hope you didn’t get me wrong TableView from two_dimensional_scrollables is definitely an awesome package, and I saw in the commits that you’re also working on it. Still, as I mentioned above, I believe there are valid reasons why it could make sense to support colSpan/rowSpan in the default Table as well. Anyway, if the points I mentioned aren’t relevant for you and the way to go for devs is to use packages for this kind of core functionality, just let me know, then we can close the PR 😉 But in that case, I’d also suggest closing #21594 and mentioning that the recommended solution is to use the two_dimensional_scrollables package.

Thanks again for the fast response to that PR and I'll fill out the document you mentioned as soon as possible.

Piinks · 2025-10-27T21:54:17Z

as my other older PR #176393 is still waiting, but maybe that one’s not very interesting for you guys

Actually, we use labels to route PRs to the right sub-team for review. I noticed that PR did not have a team label on it, so I applied one and reached out to the team to confirm. I hope you will hear back soon on it, and thanks again for contributing!
We have a Discord channel for reaching out to folks directly if a PR goes unattended, see here for docs:

Thanks as well for your detailed response. If you are able to fill out the design dic template (the various sections are suggestive, not all required) it would be helpful for review. Otherwise I can start digging into this, it just might take a minute to get through it all. :)

…t64List

hm21 · 2025-10-28T12:34:58Z

Hey @Piinks, thanks for sharing those two links and my bad for not reading carefully enough that I was supposed to mention the open PR in the Discord channel after two weeks🙈 Still, really appreciate your help with tagging the team on the other PR.

The link to the design-document is https://flutter.dev/go/table-cell-span.

Also, sorry again, I missed that the usual process is to first create an issue referencing the design doc before opening a PR. If you'd still prefer I create a new issue for the design doc but I just thought it might be a bit pointless now that the PR is already there😅

## Description of what this PR is changing or adding, and why: Adds a new shortlink redirect for the Flutter design document describing TableCell span support. ## Issues fixed by this PR (if any): ## PRs or commits this PR depends on (if any): [flutter/flutter#177102](flutter/flutter#177102)

Piinks

Still working through, but a couple questions to start. Thanks for writing a doc! Very helpful!

packages/flutter/lib/src/widgets/table.dart

packages/flutter/lib/src/rendering/table.dart

…ties in TableCell

… RenderTable

…e bounds

Piinks

Thanks for the updates and your patience here. :)

Couple tests I want to make sure we've covered..

From your doc (thanks again for providing!):

If a developer forgets to include the required TableCell.none entries, assertions during layout report the conflict and specify which row and column overlap occurred.

Is that covered here? I might have missed it.

Also, what happens if the configuration of spans causes overlapping merged cells? How is that handled?

packages/flutter/lib/src/rendering/table.dart

packages/flutter/lib/src/widgets/table.dart

packages/flutter/test/rendering/table_test.dart

packages/flutter/test/widgets/table_test.dart

Piinks · 2025-11-17T23:25:48Z

packages/flutter/test/widgets/table_test.dart

+      expect(find.text('Bottom Middle'), findsOneWidget);
+    });
+
+    testWidgets('Table with all cells using TableCell.none in spanning area', (


What happens if the user puts another widget in a hidden cell instead of TableCell.none?

Currently, nothing will happen and it will just use it as a placeholder same as TableCell.none. I did consider adding an assert, but decided to leave it optional and allow the use of TableCell.none for a couple of reasons:

Some users might prefer to use SizedBox.shrink() or another widget, so this gives them the flexibility to choose.

Imagine a scenario where cells can be dynamically expanded or collapsed. In such cases, developers can simply update the colSpan or rowSpan value without having to switch between TableCell.none and an actual widget.

Anyway if you’d prefer to enforce the use of TableCell.none, I can add an assert, I'm fine with that too :)

Connecting the other thread - we checked against TableView, and overlap like this is allowed. It is in the realm of possibility folks may want to be able to do this for their UI.

I am slightly confused about the reasoning for allowing use of other widget in placed for the hidden cell? If I understand correctly

TableRow( children: <Widget>[ TableCell(colSpan: 2, child: Text('Spanning Cell')), Text('hidden'), // This is ignored? ], ),

This feels like code smell that they should use TableCell.none to be more descriptive.

@chunhtai Got your point and yes in your example it would feel odd if the Text widget gets ignored.

That said, I still think the two reasons I explained here could be relevant for why we might want to allow it. But I’m also totally fine with adding an assert to enforce the use of TableCell.none. So I’ll hold back for now and if you guys decide to go that route, I can extend it with the assert later :)

I vote for add assertion to enforce the use of TableCell.none, we can always relax later if this indeed becomes a pain point.

@chunhtai commit 1cb90e2 will assert that now

Piinks · 2025-11-17T23:29:39Z

Also, FYI it looks like there are some failing tests here.

…/table

hm21 · 2025-11-28T15:55:29Z

Hey @Piinks, so sorry for my late response, I was on vacation in Iceland, and afterwards got a bit caught up with some personal work projects🙈

Couple tests I want to make sure we've covered..
From your doc (thanks again for providing!):
"If a developer forgets to include the required TableCell.none entries, assertions during layout report the conflict and specify which row and column overlap occurred."
Is that covered here? I might have missed it.

Currently it detects two different behaviors:

If the user forgets to add a TableCell.none or any other widget in a row, it will assert here, indicating exactly which row has the incorrect number of children.
If the number of children is correct but the colSpan or rowSpan exceeds the available columns or rows, it will assert here which throws an error with the exact row and column number where the problem occurred.

Also, what happens if the configuration of spans causes overlapping merged cells? How is that handled?

At the moment, there's no assert that throws an error in that case, so if it happens, the merged cells will overlap the other cells in reverse order (the last widget ends up on top of the others). I guess it would make sense to implement an assert for that too, right? Or how do you handle that case in TableView?

Also, FYI it looks like there are some failing tests here.

Oh, I thought it was cuz of the infrastructure issue with the Linux tests that were failing around the time I created that PR. In another PR, I had the same problem and was told here that it was related to that. But my bad for not double-checking also here more carefully.

~~Some tests might fail again now, since I’m pretty sure I didn’t implement the golden tests correctly but I’ll fix them ASAP ;)~~

EDIT:
The Flutter Dashboard bot here mentions reviewing the golden tests. I opened the link and tried it (logged in with the same email as on GitHub), but got this error message: "Unexpected error triaging: 401 (Are you logged in with the right account?)"

So I’m guessing that part is only available to Flutter team members, or in this case, to “you,” right? Or is there something else I need to do first?

flutter-dashboard · 2025-11-28T17:31:33Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #177102 at sha 0dfad75

packages/flutter/lib/src/rendering/table.dart

Piinks · 2025-12-09T21:04:46Z

Thanks for the updates! I hope you had a nice time in Iceland. Let me check how TableView handles overlapping merged cells. I do not recall, and there are probably some fundamental differences here since it lays out lazily.

flutter-dashboard · 2025-12-19T21:55:51Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #177102 at sha b929a32

flutter-dashboard · 2025-12-30T21:51:07Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #177102 at sha e1f2ed8

justinmc · 2026-01-20T23:28:32Z

@hm21 FYI this PR has a merge conflict.

hm21 · 2026-01-21T08:23:26Z

@justinmc Thanks for pointing that out! I just fixed it, so it's ready for review now :)

flutter-dashboard · 2026-01-21T08:24:25Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #177102 at sha f249739

flutter-dashboard · 2026-02-10T08:25:37Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

justinmc · 2026-02-10T23:27:25Z

@hm21 Can you update this PR? Looks like the Goldens bot is complaining it's too old.

Also CC @chunhtai for re-review.

…/table

flutter-dashboard · 2026-02-11T08:05:34Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #177102 at sha 91e165f

Piinks · 2026-02-18T22:30:49Z

I think this is ready to go, let me check in with @chunhtai

chunhtai

Sorry for the late review. I think the logic and calculation looks good to me, but I left some comments on the way we cache data and some readability suggestions.

packages/flutter/lib/src/rendering/table.dart

chunhtai · 2026-03-09T19:57:58Z

packages/flutter/lib/src/rendering/table_border.dart

    required Iterable<double> rows,
    required Iterable<double> columns,
+    required Float64List rowHeights,
+    List<Set<int>> spannedColumnsPerRow = const <Set<int>>[],


Since this is going to be public, we may need to pick a more straightforward API. Can we use a single bit map to encapsure the hidden cell?

We can do it with a bitmap, but I’m not sure if that would make things more complicated to understand right now. However, the commit that implements it is a0cf25d in case we want to undo it.

chunhtai · 2026-03-09T20:04:11Z

packages/flutter/test/widgets/table_test.dart

+      expect(find.text('Bottom Middle'), findsOneWidget);
+    });
+
+    testWidgets('Table with all cells using TableCell.none in spanning area', (


I vote for add assertion to enforce the use of TableCell.none, we can always relax later if this indeed becomes a pain point.

Gustl22 · 2026-03-14T07:33:46Z

Sorry I came across this implementation, but I wanted to ask why there is a need of a public TableCell.none in the first place.

I would expect to span automatically without the need to specify a TableCell.none like in HTML. This would also resolve the confusion, why only TableCell.none is allowed as next widget, when a span is specified previously.

https://www.w3schools.com/html/html_table_colspan_rowspan.asp

<table style="width:100%">
  <tr>
    <th colspan="2">Name</th>
    <th>Age</th>
  </tr>
  <tr>
    <td>Jill</td>
    <td>Smith</td>
    <td>43</td>
  </tr>
  <tr>
    <td>Eve</td>
    <td>Jackson</td>
    <td>57</td>
  </tr>
</table>

I did a similar implementation for the PDF package, which calculates the missing TableCells automatically: https://github.com/DavBfr/dart_pdf/pull/1736/changes#diff-7dd0c0420d9a8667875d298f38592fb595a24957ee3291f9ca6c1c36e5e8593bR330

hm21 · 2026-03-14T09:25:54Z

@Gustl22 That’s a good question. My main idea was not that the HTML-style approach could not work, but rather that I wanted to keep the table structure fully explicit in the widget tree.

More explicit structure: Every occupied or skipped slot is represented directly in the row definition.
Less implicit behavior: The layout does not need to derive missing cells from previous spans.
API consistency: It makes the relationship between spanning cells and the following entries more visible in code.

I did think about the HTML table model, which is also why I chose colspan and rowspan as names since they are already familiar from the web. And I agree that if colspan and rowspan are defined correctly, an HTML-style approach can still be predictable. I just leaned more towards an explicit representation instead of having the framework infer the skipped cells automatically.

That said, I’d still love to hear feedback from the Flutter team (@Piinks, @chunhtai) on whether moving closer to the HTML-style approach would make more sense here, even though I personally leaned towards the explicit version.

…d consistency

…rity

…Table and TableBorder

…nderTable

…erTable

…cells in RenderTable

Gustl22 · 2026-03-14T10:52:25Z

I understand your intention. An idea that I throw in would be to have a convenience factory, which is able to implictly add none cells, for those who don't want to bother when having lists with large spans, or dynamically changing spans, something like: Table.implicitSpanCells. The decision is up to the flutter devs of course.

…tection in RenderTable and TableBorder

…traints

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 16, 2025

hm21 changed the title ~~Feat/table~~ feat(table): add support for colSpan and rowSpan in TableCell Oct 16, 2025

gemini-code-assist bot reviewed Oct 16, 2025

View reviewed changes

packages/flutter/lib/src/rendering/table.dart Outdated Show resolved Hide resolved

justinmc requested a review from Piinks October 21, 2025 22:23

hm21 force-pushed the feat/table branch from 567c1cd to d11f8a4 Compare October 22, 2025 09:57

Piinks reviewed Oct 24, 2025

View reviewed changes

perf(rendering): optimize table painting and layout caching with Floa…

b3eab2b

…t64List

hm21 mentioned this pull request Oct 28, 2025

Add go redirect for table-cell-span doc flutter/website#12602

Merged

Piinks reviewed Nov 6, 2025

View reviewed changes

hm21 added 3 commits November 7, 2025 11:24

refactor(table): improve documentation for colSpan and rowSpan proper…

64cb99b

…ties in TableCell

refactor(table): validate colSpan and rowSpan against table bounds in…

5205845

… RenderTable

fix(tests): fix error handling for colSpan and rowSpan exceeding tabl…

20d018f

…e bounds

Piinks reviewed Nov 17, 2025

View reviewed changes

hm21 added 3 commits November 28, 2025 14:53

fix(table): resolve issues highlighted in PR review

769af52

Merge branch 'master' of https://github.com/flutter/flutter into feat…

7cdb314

…/table

refactor(tests): simplify variable declarations in table tests

a748295

hm21 added 2 commits November 28, 2025 17:12

fix(tests): update golden file names for vertical alignment tests

c2416f1

fix(tests): add "reduced-test-set" for golden tests

0dfad75

flutter-dashboard bot added the will affect goldens Changes to golden files label Nov 28, 2025

Piinks reviewed Dec 9, 2025

View reviewed changes

packages/flutter/lib/src/rendering/table.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/rendering/table.dart Outdated Show resolved Hide resolved

fix(table): ensure non-negative pending heights for row spans

b929a32

chunhtai self-requested a review December 30, 2025 18:26

fix(table): remove useless comment

e1f2ed8

justinmc requested a review from Piinks January 13, 2026 23:35

Merge https://github.com/flutter/flutter into feat/table

f249739

Merge branch 'master' of https://github.com/flutter/flutter into feat…

91e165f

…/table

chunhtai reviewed Mar 9, 2026

View reviewed changes

hm21 added 9 commits March 14, 2026 10:32

Merge https://github.com/flutter/flutter into feat/table

22f9977

refactor: renamed cached span variables in RenderTable for clarity an…

d5e4c71

…d consistency

refactor: improve comments for cached layout data in RenderTable

b35e361

refactor: enhance colSpan and rowSpan properties with validation

a4bf755

refactor: update span checks to use maxColSpan and maxRowSpan for cla…

42cf370

…rity

refactor: replace cached row heights with computed row tops in Render…

7d1f87d

…Table and TableBorder

refactor: clarify comment on row-major order for cache locality in Re…

a0dc58c

…nderTable

refactor: streamline span information computation and caching in Rend…

7fc121e

…erTable

refactor: add assertions for visibility of cells covered by spanning …

1cb90e2

…cells in RenderTable

hm21 added 2 commits March 14, 2026 12:34

refactor: replace spanned cell caches with bitmaps for hidden cell de…

a0cf25d

…tection in RenderTable and TableBorder

test: add error handling tests for TableCell colSpan and rowSpan cons…

03019da

…traints

Conversation

hm21 commented Oct 16, 2025

Description

Examples

Issues Fixed

Questions for Reviewers

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Oct 24, 2025

Uh oh!

hm21 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test 1: Very Large (10,000 cells: 500 rows × 20 columns)

Test 2: Large (500 cells: 50 rows × 10 columns)

Uh oh!

Piinks commented Oct 27, 2025

Uh oh!

hm21 commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks commented Nov 17, 2025

Uh oh!

hm21 commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

Piinks commented Dec 9, 2025

Uh oh!

flutter-dashboard bot commented Dec 19, 2025

Uh oh!

flutter-dashboard bot commented Dec 30, 2025

Uh oh!

hm21 commented Oct 25, 2025 •

edited

Loading

hm21 commented Oct 28, 2025 •

edited

Loading

hm21 commented Nov 28, 2025 •

edited

Loading

Gustl22 commented Mar 14, 2026 •

edited

Loading