[CP-beta]Configure FfiNative resolver on dart:io#177308
Conversation
This is needed by file watching implementation after dart-lang/sdk@ed6bab8 Ideally we should actually move this whole code into `io_natives.{h,cc}` on the Dart runtime side to avoid duplication.
|
@mraleph please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request, a cherry-pick, configures the FfiNative resolver for dart:io. The change involves adding a call to Dart_SetFfiNativeResolver for the dart:io library during isolate initialization. This is consistent with how native resolvers are set up for other core libraries. The code change is straightforward and I have no further feedback.
|
autosubmit label was removed for flutter/flutter/177308, because - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
082bd44
into
flutter:flutter-3.38-candidate.0
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
None
Changelog Description:
Calling
FileSystemEntity.watch(...)will throw on Mac OS and Windows.Impact Description:
Calling
FileSystemEntity.watch(...)will throw on Mac OS and Windows, instead of correctly watching the path.Workaround:
No user level work-around.
dart:iois broken.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
It's tested by tests in Dart SDK
Validation Steps:
Run a Mac OS or Windows app with the following
main. It should do nothing - rather than throw an exception.