Skip to content

Marks Mac_arm64_mokey run_release_test to be flaky#177372

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
fluttergithubbot:lqkRGL3kSf
Dec 9, 2025
Merged

Marks Mac_arm64_mokey run_release_test to be flaky#177372
auto-submit[bot] merged 1 commit intoflutter:masterfrom
fluttergithubbot:lqkRGL3kSf

Conversation

@fluttergithubbot
Copy link
Contributor

Issue link: #177371

@fluttergithubbot fluttergithubbot added the team-tool Owned by Flutter Tool team label Oct 22, 2025
@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Oct 22, 2025
@github-actions github-actions bot removed c: tech-debt Technical debt, code quality, testing, etc. team-tool Owned by Flutter Tool team labels Oct 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request marks the Mac_arm6g4_mokey run_release_test as flaky by setting bringup: true. This is a standard and correct approach to handle flaky tests in the CI. My review includes a minor suggestion to align the comment with the repository's documented process for tracking flaky tests, which will improve maintainability.


# mac mokey test
- name: Mac_arm64_mokey run_release_test
bringup: true # Flaky https://github.com/flutter/flutter/issues/177371
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve tracking and maintainability of this flaky test, the comment should be on its own line above bringup: true and follow the TODO(username): issue url format as specified in the repository's guide on reducing test flakiness.1

    # TODO(flutter-hackers): Flaky https://github.com/flutter/flutter/issues/177371
    bringup: true

Style Guide References

Footnotes

  1. The documentation on reducing test flakiness specifies that when a test is marked as flaky, a TODO comment with the username and issue URL should be added above the bringup: true line to ensure proper tracking.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 8, 2025
Merged via the queue into flutter:master with commit bc073bb Dec 9, 2025
151 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_arm64_mokey run_release_test"
}
-->
Issue link: flutter#177371
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 10, 2025
Manual roll requested by [email protected]

flutter/flutter@b2de367...6a1f5b7

2025-12-09 [email protected] Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480)
2025-12-09 [email protected] Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955)
2025-12-09 [email protected] Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351)
2025-12-09 [email protected] Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978)
2025-12-09 [email protected] Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625)
2025-12-09 [email protected] [skia] Update SkSerialProcs to use new type (flutter/flutter#179347)
2025-12-09 [email protected] Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617)
2025-12-09 [email protected] Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608)
2025-12-09 [email protected] Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525)
2025-12-08 [email protected] Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595)
2025-12-08 [email protected] Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115)
2025-12-08 [email protected] Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594)
2025-12-08 [email protected] Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372)
2025-12-08 [email protected] Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589)
2025-12-08 [email protected] MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546)
2025-12-08 [email protected] Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292)
2025-12-08 [email protected] Android implementation of content sizing (flutter/flutter#176063)
2025-12-08 [email protected] Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587)
2025-12-08 [email protected] Redistribute TESTOWNERS for Android team (flutter/flutter#179464)
2025-12-08 [email protected] Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109)
2025-12-08 [email protected] Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773)
2025-12-08 [email protected] Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ivan-vanyusho pushed a commit to ivan-vanyusho/packages that referenced this pull request Jan 26, 2026
…0593)

Manual roll requested by [email protected]

flutter/flutter@b2de367...6a1f5b7

2025-12-09 [email protected] Fix - Semantics focus does not move outside viewport when moving up or down (flutter/flutter#179480)
2025-12-09 [email protected] Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (flutter/flutter#178955)
2025-12-09 [email protected] Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (flutter/flutter#179351)
2025-12-09 [email protected] Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (flutter/flutter#178978)
2025-12-09 [email protected] Roll Packages from 33a9a81 to 338ecd3 (5 revisions) (flutter/flutter#179625)
2025-12-09 [email protected] [skia] Update SkSerialProcs to use new type (flutter/flutter#179347)
2025-12-09 [email protected] Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (flutter/flutter#179617)
2025-12-09 [email protected] Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (flutter/flutter#179608)
2025-12-09 [email protected] Remove unused optional argument in _followDiagnosticableChain (flutter/flutter#179525)
2025-12-08 [email protected] Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (flutter/flutter#179595)
2025-12-08 [email protected] Marks Linux_mokey flutter_engine_group_performance to be flaky (flutter/flutter#179115)
2025-12-08 [email protected] Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (flutter/flutter#179594)
2025-12-08 [email protected] Marks Mac_arm64_mokey run_release_test to be flaky (flutter/flutter#177372)
2025-12-08 [email protected] Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (flutter/flutter#179589)
2025-12-08 [email protected] MatrixUtils.forceToPoint - simplify and optimize (flutter/flutter#179546)
2025-12-08 [email protected] Change GenerateFilledArcStrip to use non-overlapping triangles (flutter/flutter#179292)
2025-12-08 [email protected] Android implementation of content sizing (flutter/flutter#176063)
2025-12-08 [email protected] Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (flutter/flutter#179587)
2025-12-08 [email protected] Redistribute TESTOWNERS for Android team (flutter/flutter#179464)
2025-12-08 [email protected] Make sure that a CupertinoListTile doesn't crash in 0x0 environment (flutter/flutter#179109)
2025-12-08 [email protected] Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment (flutter/flutter#178773)
2025-12-08 [email protected] Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment (flutter/flutter#178929)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: flake Tests that sometimes, but not always, incorrectly pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants