Validate that platforms specified in .ci.yaml target names match the platforms defined in the platform_properties section by jason-simmons · Pull Request #177523 · flutter/flutter

jason-simmons · 2025-10-24T22:19:38Z

Target names must begin with a platform name. The LUCI configuration scripts in https://flutter.googlesource.com/infra will look up the platform name in platform_properties to obtain the dimensions for the bot where the target will be scheduled.

See #177465

gemini-code-assist

Code Review

This pull request introduces validation for .ci.yaml files to ensure that the platform specified in each target's name corresponds to a platform defined in the platform_properties section. This is achieved by refactoring the YAML parsing logic into a new _CiYaml class that holds both targets and platform information. The tests have been updated to use this new class and include a new check for platform name validity. My feedback includes a suggestion to improve the immutability of the new _CiYaml class by making its fields final.

dev/bots/test/ci_yaml_validation_test.dart

jtmcdole · 2025-11-04T17:32:02Z

I just needed to prove to myself that the framework really had so many "platforms":

1 │ framework ciYaml platforms: {staging_build_linux, linux, linux_android_emu, linux_android_emu_unstable, linux_android_emu_vulkan_stable, linux_build_test, linux_pixel_7pro, linux_mokey, linux_galaxy_s24, mac, mac_arm64, mac_benchmark, mac_x64,
  │ mac_build_test, mac_mokey, mac_arm64_mokey, mac_ios, mac_x64_ios, mac_arm64_ios, windows, windows_arm64, windows_mokey}
2 │ engine ciYaml platforms: {linux, mac, windows}

Not sure how many of those are active. I know staging_build_linux is not.

jtmcdole

██╗      ██████╗████████╗███╗   ███╗
██║     ██╔════╝╚══██╔══╝████╗ ████║
██║     ██║  ███╗  ██║   ██╔████╔██║
██║     ██║   ██║  ██║   ██║╚██╔╝██║
███████╗╚██████╔╝  ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝   ╚═╝   ╚═╝     ╚═╝

auto-submit · 2025-11-04T17:37:26Z

autosubmit label was removed for flutter/flutter/177523, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

…platforms defined in the platform_properties section Target names must begin with a platform name. The LUCI configuration scripts in https://flutter.googlesource.com/infra will look up the platform name in platform_properties to obtain the dimensions for the bot where the target will be scheduled. See flutter#177465

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

flutter/flutter@e5d5c01...c5e809a 2025-11-06 [email protected] Remove WindowingOwner.hasTopLevelWindows (flutter/flutter#178033) 2025-11-06 [email protected] Fix DropdownMenu escape key does not close the menu (flutter/flutter#178002) 2025-11-06 [email protected] Update documentation tool reference in image.dart (flutter/flutter#177782) 2025-11-06 [email protected] Roll Skia from 4eb2383d38f2 to 5c4e1352128f (5 revisions) (flutter/flutter#178094) 2025-11-06 [email protected] Revert "Refactor OverlayPortal semantics (#173005)" (flutter/flutter#178007) 2025-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix verified input test failure in CI (attempt 4) (#178018)" (flutter/flutter#178089) 2025-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] Unify Surface code between Skwasm and CanvasKit (#177138)" (flutter/flutter#178085) 2025-11-05 [email protected] Fix verified input test failure in CI (attempt 4) (flutter/flutter#178018) 2025-11-05 [email protected] fix: inconsistent horizontal spacing between hours and mins in time picker for non-english language (flutter/flutter#173706) 2025-11-05 [email protected] Roll Fuchsia Linux SDK from mpsxF1gd-jbKNvmpm... to cm88aTLui5yorSGYQ... (flutter/flutter#178074) 2025-11-05 [email protected] Fix(ios): Remove arm64 exclusion to support Xcode 26 simulators (flutter/flutter#177065) 2025-11-05 [email protected] Roll Skia from 2ff897e9b440 to 4eb2383d38f2 (18 revisions) (flutter/flutter#178070) 2025-11-05 [email protected] [web] Unify Surface code between Skwasm and CanvasKit (flutter/flutter#177138) 2025-11-05 [email protected] Update more missing ninja deps (flutter/flutter#178079) 2025-11-05 [email protected] Add ninja / cmake deps to failing tests (flutter/flutter#178054) 2025-11-05 [email protected] [web] Don't add webparagraph suite to CI (flutter/flutter#177681) 2025-11-05 [email protected] Fixing broken link in engine readme (flutter/flutter#177987) 2025-11-05 [email protected] Print reason for adb command failure in verified input test (attempt 3) (flutter/flutter#178005) 2025-11-05 [email protected] Fix `ReorderableList` items jumping when drag direction reverses mid-animation (flutter/flutter#173241) 2025-11-05 [email protected] Replace deprecated `withOpacity` in `overflow_bar.0.dart‎` example (flutter/flutter#177813) 2025-11-05 [email protected] Replace deprecated `withOpacity` in `data_table.1.dart‎` example (flutter/flutter#177812) 2025-11-05 [email protected] Replace deprecated `withOpacity` in `switch.1.dart` example (flutter/flutter#177811) 2025-11-04 [email protected] Roll Skia from c89b6118266b to 2ff897e9b440 (6 revisions) (flutter/flutter#177999) 2025-11-04 [email protected] Fix verified input test in CI (attempt 2) (flutter/flutter#177961) 2025-11-04 [email protected] Replace rendering for solid color circles (both filled and stroked) to use SDFs (flutter/flutter#177482) 2025-11-04 [email protected] Roll Fuchsia Linux SDK from vxK5obzfr1X9P2kSh... to mpsxF1gd-jbKNvmpm... (flutter/flutter#177996) 2025-11-04 [email protected] Validate that platforms specified in .ci.yaml target names match the platforms defined in the platform_properties section (flutter/flutter#177523) 2025-11-04 [email protected] Roll Packages from 1a7075b to 3d926aa (6 revisions) (flutter/flutter#177998) 2025-11-04 [email protected] Remove dead code from snippet_generator (flutter/flutter#174440) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…platforms defined in the platform_properties section (flutter#177523) Target names must begin with a platform name. The LUCI configuration scripts in https://flutter.googlesource.com/infra will look up the platform name in platform_properties to obtain the dimensions for the bot where the target will be scheduled. See flutter#177465

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

jason-simmons requested a review from jtmcdole October 24, 2025 22:19

gemini-code-assist bot reviewed Oct 24, 2025

View reviewed changes

dev/bots/test/ci_yaml_validation_test.dart Outdated Show resolved Hide resolved

jtmcdole approved these changes Nov 4, 2025

View reviewed changes

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2025

jason-simmons added 2 commits November 4, 2025 09:40

final fields

b358af5

jason-simmons force-pushed the bug_177465_validate_ci_yaml branch from 152a578 to b358af5 Compare November 4, 2025 17:40

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2025

auto-submit bot added this pull request to the merge queue Nov 4, 2025

Merged via the queue into flutter:master with commit 36f0ee7 Nov 4, 2025
155 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2025

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Flutter from e5d5c01850f2 to 3fd81edbf1e0 (14 revisions) flutter/packages#10364

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

d467faa

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

6c86583

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Flutter from e5d5c01850f2 to 3fd81edbf1e0 (14 revisions) flutter/packages#10365

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

1360a39

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to c5e809a998fe (29 revisions) flutter/packages#10369

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

29e64af

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to 6925f8b815ea (30 revisions) flutter/packages#10370

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

9250e0b

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to aebe02b44fe2 (31 revisions) flutter/packages#10371

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

55a7cba

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to c45883383950 (32 revisions) flutter/packages#10372

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

9321ebc

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to ac3b91db0dcc (33 revisions) flutter/packages#10373

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

2b70020

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to 7dc982e1b16d (34 revisions) flutter/packages#10375

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

36f0ee7 Validate that platforms specified in .ci.yaml target names ma…

536608a

…tch the platforms defined in the platform_properties section (flutter/flutter#177523)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate that platforms specified in .ci.yaml target names match the platforms defined in the platform_properties section#177523

Validate that platforms specified in .ci.yaml target names match the platforms defined in the platform_properties section#177523
auto-submit[bot] merged 2 commits intoflutter:masterfrom
jason-simmons:bug_177465_validate_ci_yaml

jason-simmons commented Oct 24, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

jtmcdole commented Nov 4, 2025

Uh oh!

jtmcdole left a comment

Uh oh!

auto-submit bot commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jason-simmons commented Oct 24, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

jtmcdole commented Nov 4, 2025

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants