[CP-beta][web] Move webparagraph tests to their right location#178304
Conversation
Many failures happening in [`Linux linux_web_engine_tests `](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20linux_web_engine_tests) due to `ui/web_paragraph/font_collection_test.dart` being misplaced. This PR moves the test file to the correct directory so it runs with the correct test suite.
|
@mdebbar please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
engine
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a refactoring that moves the webparagraph tests to a new directory. The only code change is updating relative import paths in font_collection_test.dart to reflect the file's new location. This change is correct. While there are no issues with the code, please note that the pull request description template has not been filled out, which is required by the repository's style guide.
camsim99
added
the
autosubmit
auto-submit
bot
merged commit aef5bdc
into
flutter:flutter-3.38-candidate.0
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
N/A
Changelog Description:
Move the new font collection test to the correct folder.
Impact Description:
Flakiness in CI.
Workaround:
N/A
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
Notice there are no font collection-related failures in
Linux linux_web_engine_tests