fix: infra out of resources#178387
Conversation
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
There was a problem hiding this comment.
Code Review
This pull request updates the CI configuration in .ci.yaml to add Mac-15.7 to the list of supported operating systems. This change directly addresses an issue where CI jobs were failing due to a mismatch with upgraded Mac bots. My review includes a suggestion to improve the long-term maintainability of this configuration by investigating more flexible OS version matching to prevent similar issues in the future.
| {"dependency": "open_jdk", "version": "version:21"} | ||
| ] | ||
| os: Mac-15.1|Mac-15.5|Mac-15.6 | ||
| os: Mac-15.1|Mac-15.5|Mac-15.6|Mac-15.7 |
There was a problem hiding this comment.
While this fixes the immediate problem, pinning specific minor OS versions is brittle and requires manual updates for each new version, as you noted in the description. To improve maintainability, it would be ideal to use a more flexible pattern if the CI system supports it. For instance, a wildcard like Mac-15.* or specifying only the major version could make this configuration more resilient to future OS upgrades on the bots.
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml question for future: is there a better option for this other than pinning? fixes: flutter#178384
Mac bots in device lab were upgraded to 15.7; which no longer matches ci.yaml
question for future: is there a better option for this other than pinning?
fixes: #178384