Adds format argument to Picture.toImageSync by gaaclarke · Pull Request #178691 · flutter/flutter

gaaclarke · 2025-11-17T23:27:37Z

This allows users to chain together fragment shaders with pixel formats other than rgba8.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

…make the drawing take up the full screen

chinmaygarde

Just some minor nits.

chinmaygarde · 2025-11-21T19:41:44Z

engine/src/flutter/shell/common/snapshot_controller_impeller.cc

    render_target_size.height *= scale_factor;
  }

+  std::optional<impeller::PixelFormat> impeller_pixel_format;


Nit: Hoist into a little helper.

chinmaygarde · 2025-11-21T19:44:50Z

engine/src/flutter/impeller/entity/render_target_cache.h

-      const std::shared_ptr<Texture>& existing_depth_stencil_texture =
-          nullptr) override;
+      const std::shared_ptr<Texture>& existing_depth_stencil_texture = nullptr,
+      std::optional<PixelFormat> target_pixel_format = std::nullopt) override;


Oof. These argument lists are getting kinda large aren't they? I remember having a bug for to create a RenderTargetBuilder. I think we even added one but had to back it out because it didn't quite do the right thing.

Yea, I thought the same thing. I have a few other things I want to get to so I didn't incorporate as much refactoring here as I was thinking.

chinmaygarde · 2025-11-21T19:45:37Z

engine/src/flutter/impeller/renderer/render_target.cc

    color0_tex_desc.storage_mode = color_attachment_config.storage_mode;
-    color0_tex_desc.format = pixel_format;
+    color0_tex_desc.format =
+        target_pixel_format.has_value()


Nit: target_pixel_format.value_or(context.GetCapabilities()->GetDefaultColorFormat());

And elsewhere.

auto-submit · 2025-11-24T21:30:24Z

autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-11-25T22:03:36Z

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 33368de.

Possible causes:

Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) If you reach out to GitHub Support for help, please include the request ID D832:173C34:12151:4FF44:692627B7.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:246:24)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1253:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1314:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1121:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompleted (package:cocoon_service/src/service/scheduler.dart:1054:9)
<asynchronous suspension>
#9      PresubmitLuciSubscription.post (package:cocoon_service/src/request_handlers/presubmit_luci_subscription.dart:135:7)
<asynchronous suspension>
#10     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#11     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#12     createServer.<anonymous closure> (package:cocoon_service/server.dart:339:7)
<asynchronous suspension>

auto-submit · 2025-11-25T23:27:05Z

autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Windows tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-12-01T18:48:10Z

autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

gaaclarke · 2025-12-02T17:03:23Z

Merging main to hopefully help with presubmit tasks that were stuck queued.

auto-submit · 2025-12-02T18:03:10Z

autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

…178691)

flutter/flutter@5545bb3...e274574 2025-12-03 [email protected] Roll Skia from 20829e37dfb8 to db4c79d41513 (1 revision) (flutter/flutter#179401) 2025-12-03 [email protected] Roll Skia from adc7ea94cada to 20829e37dfb8 (6 revisions) (flutter/flutter#179385) 2025-12-03 [email protected] Refactor GetShaderClipDepth for clarity (flutter/flutter#179110) 2025-12-03 [email protected] Roll Skia from 3b339a83959b to adc7ea94cada (1 revision) (flutter/flutter#179376) 2025-12-03 [email protected] Roll Dart SDK from eb743a1d4ade to 0bb365d7ac74 (7 revisions) (flutter/flutter#179372) 2025-12-03 [email protected] feat: Add `mainAxisExtent` parameter to `GridView` constructors (flutter/flutter#176927) 2025-12-03 [email protected] Roll Skia from eb01fff20df8 to 3b339a83959b (4 revisions) (flutter/flutter#179371) 2025-12-02 [email protected] Fix crash when text editing value changes between scrolls (flutter/flutter#179163) 2025-12-02 [email protected] Roll Skia from 6bd3b06b1e08 to eb01fff20df8 (3 revisions) (flutter/flutter#179362) 2025-12-02 [email protected] Adds Impellerc flatbuffer format versioning. (flutter/flutter#175470) 2025-12-02 [email protected] Adds format argument to Picture.toImageSync (flutter/flutter#178691) 2025-12-02 [email protected] Delete disabled workflow and add missing permissions key to workflow (flutter/flutter#178911) 2025-12-02 [email protected] [web] Fix some gn warnings (flutter/flutter#178313) 2025-12-02 [email protected] Roll Skia from 45337c4e919d to 6bd3b06b1e08 (4 revisions) (flutter/flutter#179353) 2025-12-02 [email protected] [ios] Reland Dynamic Content Resizing (flutter/flutter#179153) 2025-12-02 [email protected] [web] Fix onTextScaleFactorChanged not getting called. (flutter/flutter#178862) 2025-12-02 [email protected] Roll Packages from c8be05d to 148dcd2 (9 revisions) (flutter/flutter#179343) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fixes flutter#178539 This allows users to chain together fragment shaders with pixel formats other than rgba8. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

flutter/flutter@5545bb3...e274574 2025-12-03 [email protected] Roll Skia from 20829e37dfb8 to db4c79d41513 (1 revision) (flutter/flutter#179401) 2025-12-03 [email protected] Roll Skia from adc7ea94cada to 20829e37dfb8 (6 revisions) (flutter/flutter#179385) 2025-12-03 [email protected] Refactor GetShaderClipDepth for clarity (flutter/flutter#179110) 2025-12-03 [email protected] Roll Skia from 3b339a83959b to adc7ea94cada (1 revision) (flutter/flutter#179376) 2025-12-03 [email protected] Roll Dart SDK from eb743a1d4ade to 0bb365d7ac74 (7 revisions) (flutter/flutter#179372) 2025-12-03 [email protected] feat: Add `mainAxisExtent` parameter to `GridView` constructors (flutter/flutter#176927) 2025-12-03 [email protected] Roll Skia from eb01fff20df8 to 3b339a83959b (4 revisions) (flutter/flutter#179371) 2025-12-02 [email protected] Fix crash when text editing value changes between scrolls (flutter/flutter#179163) 2025-12-02 [email protected] Roll Skia from 6bd3b06b1e08 to eb01fff20df8 (3 revisions) (flutter/flutter#179362) 2025-12-02 [email protected] Adds Impellerc flatbuffer format versioning. (flutter/flutter#175470) 2025-12-02 [email protected] Adds format argument to Picture.toImageSync (flutter/flutter#178691) 2025-12-02 [email protected] Delete disabled workflow and add missing permissions key to workflow (flutter/flutter#178911) 2025-12-02 [email protected] [web] Fix some gn warnings (flutter/flutter#178313) 2025-12-02 [email protected] Roll Skia from 45337c4e919d to 6bd3b06b1e08 (4 revisions) (flutter/flutter#179353) 2025-12-02 [email protected] [ios] Reland Dynamic Content Resizing (flutter/flutter#179153) 2025-12-02 [email protected] [web] Fix onTextScaleFactorChanged not getting called. (flutter/flutter#178862) 2025-12-02 [email protected] Roll Packages from c8be05d to 148dcd2 (9 revisions) (flutter/flutter#179343) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…178691)

github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Nov 17, 2025

gaaclarke force-pushed the format-to-image-sync branch from e1bc825 to 1714a6b Compare November 19, 2025 23:33

gaaclarke added 9 commits November 20, 2025 16:39

Adds target format to toImageSync

4a66dbd

percolated up PixelFormat

cd711dc

format

7fda425

adds snapshot_pixel_format.h

524ca23

added integration test

7471080

got the integration test passing

9374e0a

switched so msaa is based on the color attachemnets sample count and …

edd64a0

…make the drawing take up the full screen

started rendering the sdf

079166d

cleanup

a8b932c

gaaclarke force-pushed the format-to-image-sync branch from 60122bd to a8b932c Compare November 21, 2025 00:54

gaaclarke added 3 commits November 21, 2025 09:48

added gpuR32Float test

9491b64

adds r32float test

1799232

updated docstring

8c04e41

gaaclarke marked this pull request as ready for review November 21, 2025 18:35

gaaclarke requested review from chinmaygarde and flar November 21, 2025 18:35

chinmaygarde approved these changes Nov 21, 2025

View reviewed changes

updated web_ui

1719b95

github-actions bot added the platform-web Web applications specifically label Nov 24, 2025

gaaclarke added autosubmit Merge PR when tree becomes green via auto submit App and removed platform-web Web applications specifically labels Nov 24, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 24, 2025

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 24, 2025

github-actions bot added the platform-web Web applications specifically label Nov 24, 2025

skwasm update

f79ae2a

gaaclarke force-pushed the format-to-image-sync branch from ccfe34f to f79ae2a Compare November 24, 2025 21:33

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2025

Merge branch 'master' into format-to-image-sync

e42acdc

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 25, 2025

Merge branch 'master' into format-to-image-sync

be141d9

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2025

updated to new lints

a05c466

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2025

Merge branch 'master' into format-to-image-sync

fb34cad

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2025

new lints

bf4ac10

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2025

auto-submit bot added this pull request to the merge queue Dec 2, 2025

Merged via the queue into flutter:master with commit d57f6f8 Dec 2, 2025
181 of 182 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 3, 2025

d57f6f8 Adds format argument to Picture.toImageSync (flutter/flutter#…

fda0f5e

…178691)

engine-flutter-autoroll mentioned this pull request Dec 3, 2025

Roll Flutter from 5545bb397e7b to e27457436b04 (17 revisions) flutter/packages#10554

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 3, 2025

d57f6f8 Adds format argument to Picture.toImageSync (flutter/flutter#…

a8c94e9

…178691)

engine-flutter-autoroll mentioned this pull request Dec 3, 2025

Roll Flutter from 5545bb397e7b to 5c64d54db667 (18 revisions) flutter/packages#10555

Closed

Piinks mentioned this pull request Dec 12, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

d57f6f8 Adds format argument to Picture.toImageSync (flutter/flutter#…

5bb4b0e

…178691)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds format argument to Picture.toImageSync#178691

Adds format argument to Picture.toImageSync#178691
auto-submit[bot] merged 23 commits intoflutter:masterfrom
gaaclarke:format-to-image-sync

gaaclarke commented Nov 17, 2025 •

edited

Loading

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde Nov 21, 2025

Uh oh!

chinmaygarde Nov 21, 2025

Uh oh!

gaaclarke Nov 21, 2025

Uh oh!

chinmaygarde Nov 21, 2025

Uh oh!

chinmaygarde Nov 21, 2025

Uh oh!

auto-submit bot commented Nov 24, 2025

Uh oh!

flutter-dashboard bot commented Nov 25, 2025

Uh oh!

auto-submit bot commented Nov 25, 2025

Uh oh!

auto-submit bot commented Dec 1, 2025

Uh oh!

gaaclarke commented Dec 2, 2025

Uh oh!

auto-submit bot commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gaaclarke commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

gaaclarke Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Nov 24, 2025

Uh oh!

flutter-dashboard bot commented Nov 25, 2025

Uh oh!

auto-submit bot commented Nov 25, 2025

Uh oh!

auto-submit bot commented Dec 1, 2025

Uh oh!

gaaclarke commented Dec 2, 2025

Uh oh!

auto-submit bot commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaaclarke commented Nov 17, 2025 •

edited

Loading