Add contentTextStyle support to SimpleDialog by 777genius · Pull Request #178824 · flutter/flutter

777genius · 2025-11-19T19:58:27Z

Description

This PR adds contentTextStyle support to SimpleDialog, matching the functionality already available in AlertDialog.

Problem

SimpleDialog was ignoring DialogTheme.contentTextStyle, even though the DialogThemeData.contentTextStyle documentation explicitly states it applies to SimpleDialog.children:

"Overrides the default value for DefaultTextStyle for SimpleDialog.children and AlertDialog.content."

However, only AlertDialog actually implemented this behavior, forcing developers to specify text styles individually on each child widget.

Solution

Added contentTextStyle parameter to SimpleDialog and applied it using DefaultTextStyle, following the same pattern as AlertDialog. The implementation uses the standard fallback chain:

contentTextStyle parameter → DialogTheme.contentTextStyle → M2/M3 defaults

Testing

Added a new test 'SimpleDialog Custom Content Text Style' that verifies contentTextStyle is correctly applied to the children of SimpleDialog.

Related Issues

Fixes #59462

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

flutter-dashboard · 2025-11-19T19:58:31Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request introduces support for contentTextStyle in the SimpleDialog widget, aligning its functionality with AlertDialog. The changes include adding the contentTextStyle parameter to the SimpleDialog constructor and applying it to the dialog's children using DefaultTextStyle. Additionally, the build method of SimpleDialog has been refactored to cache DialogTheme and default theme data, improving readability and preventing redundant lookups. The implementation appears correct and consistent with existing patterns. I've added one comment suggesting the addition of a test to verify the new functionality.

packages/flutter/lib/src/material/dialog.dart

dkwingsmt

LGTM. Thanks for your work! Also sorry for late review.

QuncCccccc

Thanks for adding this! LGTM. I'll add a g3fix to fix the Google testing. The failures look expected since now we added the missing default value for content text style (defaults.contentTextStyle).

QuncCccccc · 2026-01-28T06:03:21Z

packages/flutter/lib/src/material/dialog.dart

@@ -1288,7 +1301,7 @@ class SimpleDialog extends StatelessWidget {
    // The paddingScaleFactor is used to adjust the padding of Dialog
    // children.
    final TextStyle defaultTextStyle =


nit: I think we can rename the variable to effectiveTextStyle. Just feel defaultTextStyle is a bit confusing and effectiveXXX is convention we use for this path.

Good catch! Renamed it to effectiveTitleTextStyle to be more specific — this way it's consistent with effectiveTitlePadding and effectiveContentPadding in the same method. Let me know if you'd prefer just
effectiveTextStyle instead.

QuncCccccc · 2026-01-28T06:04:46Z

packages/flutter/test/material/dialog_test.dart

    expect(materialWidget.clipBehavior, Clip.antiAlias);
  });

+  testWidgets('SimpleDialog Custom Content Text Style', (WidgetTester tester) async {


Can we add one more unit test to berify DialogTheme.contentTextStyle works?

Done! Added the test for DialogTheme.contentTextStyle. Also added Material3/Material2 fallback tests since the docs mention those defaults — figured it's good to have them covered too.

QuncCccccc · 2026-01-28T20:32:22Z

packages/flutter/test/material/dialog_test.dart

+    expect(content.text.style, contentTextStyle);
+  });
+
+  testWidgets('SimpleDialog Custom Content Text Style - DialogTheme', (WidgetTester tester) async {


The linux analyzer is complaining some type issues but should be simple to fix:)

Done! Linux analyze passes now. The issue was that the branch was based on an older master.

Thank you for review!

QuncCccccc · 2026-01-29T17:59:45Z

Created g3fix: cl/862354198 and waiting for google testing to pass. Waiting for approvals.

EDIT: the g3fix has been approved.

SimpleDialog now respects contentTextStyle from both the constructor parameter and DialogTheme, matching AlertDialog behavior. This implementation follows the existing pattern used for AlertDialog and titleTextStyle. The DialogThemeData.contentTextStyle property was already documented to apply to SimpleDialog.children, but was not actually implemented. Fixes flutter#59462

- Rename defaultTextStyle to effectiveTitleTextStyle to follow Flutter convention for resolved values (consistent with effectiveTitlePadding, effectiveContentPadding naming pattern) - Add test to verify DialogTheme.contentTextStyle works with SimpleDialog - Add Material3/Material2 theme fallback tests for contentTextStyle to ensure documented behavior is covered

auto-submit · 2026-02-10T21:11:25Z

autosubmit label was removed for flutter/flutter/178824, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

This commit adds a `contentTextStyle` flag to `SimpleDialog` to make it easier to land the internal fixes needed to PR flutter#178824. The flag currently does nothing. Actual implementation will be landed in PR flutter#178824.

This commit adds a `contentTextStyle` flag to `SimpleDialog` to make it easier to land the internal fixes needed to PR #178824. The flag currently does nothing. Actual implementation will be landed in PR #178824.

777genius · 2026-02-18T09:55:34Z

Excellent, well done, thank you all!

…er#178824)

…11060) Manual roll requested by [email protected] flutter/flutter@6e4a481...c023e5b 2026-02-18 [email protected] [web] Pass form validation errors to screen readers via aria-description (flutter/flutter#180556) 2026-02-18 [email protected] Roll Packages from f83926f to 59f905c (10 revisions) (flutter/flutter#182547) 2026-02-18 [email protected] flutter_tools: Copy vendored frameworks from plugin podspecs in ios/macos-framework builds (flutter/flutter#180135) 2026-02-18 [email protected] Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#182534) 2026-02-18 [email protected] Allow TabBar to receive a TabBarScrollController (flutter/flutter#180389) 2026-02-18 [email protected] Clean up cross imports in single_child_scroll_view_test.dart, decorated_sliver_test.dart, draggable_scrollable_sheet_test.dart (flutter/flutter#181613) 2026-02-18 [email protected] Roll Fuchsia Linux SDK from mcN42vw48OPH3JDNm... to Ihau0pUz3u5ajw42u... (flutter/flutter#182530) 2026-02-18 [email protected] Analyzer, require 10.1.0, fix deprecations in dependency_graph.dart (flutter/flutter#182507) 2026-02-17 [email protected] Refactor: Remove material from actions test (flutter/flutter#181702) 2026-02-17 [email protected] [a11y] RangeSlider mouse interaction should change keyboard focus (flutter/flutter#182185) 2026-02-17 [email protected] Remove more getters from userMessages class (flutter/flutter#182166) 2026-02-17 [email protected] Implement getUniformMatX and getUniformMatXArray functionality on web (flutter/flutter#182249) 2026-02-17 [email protected] Do not wait until dispose before removing replaced/popped page (flutter/flutter#182315) 2026-02-17 [email protected] Add contentTextStyle support to SimpleDialog (flutter/flutter#178824) 2026-02-17 [email protected] Filter error messages from `emulator -list-avds` output (flutter/flutter#180802) 2026-02-17 [email protected] [Reland] Cupertino cross imports (flutter/flutter#182416) 2026-02-17 [email protected] Roll Packages from 09104b0 to f83926f (1 revision) (flutter/flutter#182504) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…2200) This commit adds a `contentTextStyle` flag to `SimpleDialog` to make it easier to land the internal fixes needed to PR flutter#178824. The flag currently does nothing. Actual implementation will be landed in PR flutter#178824.

## Description This PR adds `contentTextStyle` support to `SimpleDialog`, matching the functionality already available in `AlertDialog`. ### Problem `SimpleDialog` was ignoring `DialogTheme.contentTextStyle`, even though the `DialogThemeData.contentTextStyle` documentation explicitly states it applies to `SimpleDialog.children`: > "Overrides the default value for DefaultTextStyle for SimpleDialog.children and AlertDialog.content." However, only `AlertDialog` actually implemented this behavior, forcing developers to specify text styles individually on each child widget. ### Solution Added `contentTextStyle` parameter to `SimpleDialog` and applied it using `DefaultTextStyle`, following the same pattern as `AlertDialog`. The implementation uses the standard fallback chain: `contentTextStyle` parameter → `DialogTheme.contentTextStyle` → M2/M3 defaults ### Testing Added a new test `'SimpleDialog Custom Content Text Style'` that verifies `contentTextStyle` is correctly applied to the children of `SimpleDialog`. ## Related Issues Fixes flutter#59462 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Qun Cheng <[email protected]>

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 19, 2025

gemini-code-assist bot reviewed Nov 19, 2025

View reviewed changes

packages/flutter/lib/src/material/dialog.dart Show resolved Hide resolved

777genius force-pushed the fix-simpledialog-contenttextstyle-59462 branch 2 times, most recently from 3884d24 to b6d73d1 Compare November 19, 2025 21:19

dkwingsmt self-requested a review November 26, 2025 19:25

dkwingsmt approved these changes Jan 14, 2026

View reviewed changes

dkwingsmt requested a review from QuncCccccc January 21, 2026 19:11

QuncCccccc approved these changes Jan 28, 2026

View reviewed changes

777genius force-pushed the fix-simpledialog-contenttextstyle-59462 branch 2 times, most recently from f41904b to 7c485e3 Compare January 28, 2026 11:11

QuncCccccc reviewed Jan 28, 2026

View reviewed changes

777genius force-pushed the fix-simpledialog-contenttextstyle-59462 branch 2 times, most recently from 999a20d to c91f381 Compare January 29, 2026 11:52

777genius added 2 commits February 10, 2026 11:28

QuncCccccc force-pushed the fix-simpledialog-contenttextstyle-59462 branch from c91f381 to 94c42c5 Compare February 10, 2026 19:29

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2026

chingjun mentioned this pull request Feb 11, 2026

Preparation to add contentTextStyle flag to SimpleDialog. #182200

Merged

Merge branch 'master' into fix-simpledialog-contenttextstyle-59462

21f74b0

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2026

Merge branch 'master' into fix-simpledialog-contenttextstyle-59462

89b593b

QuncCccccc added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Feb 17, 2026

auto-submit bot added this pull request to the merge queue Feb 17, 2026

Merged via the queue into flutter:master with commit 70870ee Feb 17, 2026
72 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 17, 2026

engine-flutter-autoroll mentioned this pull request Feb 18, 2026

Roll Flutter from 6e4a481bdf27 to 64866862f623 (12 revisions) flutter/packages#11049

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2026

70870ee8d Add contentTextStyle support to SimpleDialog (flutter/flutt…

11b22bf

…er#178824)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2026

70870ee8d Add contentTextStyle support to SimpleDialog (flutter/flutt…

1db3bae

…er#178824)

engine-flutter-autoroll mentioned this pull request Feb 18, 2026

Roll Flutter from 6e4a481bdf27 to 0c72661d4497 (14 revisions) flutter/packages#11053

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2026

70870ee8d Add contentTextStyle support to SimpleDialog (flutter/flutt…

cfef0e1

…er#178824)

engine-flutter-autoroll mentioned this pull request Feb 18, 2026

Roll Flutter from 6e4a481bdf27 to 1887f3f8e0d4 (15 revisions) flutter/packages#11054

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2026

70870ee8d Add contentTextStyle support to SimpleDialog (flutter/flutt…

4a0387d

…er#178824)

engine-flutter-autoroll mentioned this pull request Feb 18, 2026

Roll Flutter from 6e4a481bdf27 to 24ce716cfddf (16 revisions) flutter/packages#11055

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2026

70870ee8d Add contentTextStyle support to SimpleDialog (flutter/flutt…

b402286

…er#178824)

engine-flutter-autoroll mentioned this pull request Feb 18, 2026

Manual roll Flutter from 6e4a481bdf27 to c023e5b2474f (17 revisions) flutter/packages#11060

Merged

Conversation

777genius commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Solution

Testing

Related Issues

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Nov 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

777genius Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

777genius Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

777genius Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

777genius Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Feb 10, 2026

Uh oh!

Uh oh!

777genius commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

777genius commented Nov 19, 2025 •

edited

Loading

QuncCccccc commented Jan 29, 2026 •

edited

Loading