It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@manu-sncf Would you be able to add a test for this?

@manu-sncf Would you be able to add a test for this?

@justinmc I added a test following the example in packages/flutter/test/widgets/sliver_semantics_test.dart.

Thank you for the contribution @manu-sncf! This change looks reasonable to me and is the same approach we used to solve a similar issue in SliverAppBar #60331. However trying this out change out locally on my pixel 10 pro fold and I am still experiencing this issue. Is there a specific device you tested on?

Thank you for the contribution @manu-sncf! This change looks reasonable to me and is the same approach we used to solve a similar issue in SliverAppBar #60331. However trying this out change out locally on my pixel 10 pro fold and I am still experiencing this issue. Is there a specific device you tested on?

screen-20251203-165938-1764809950067.mp4

Thank you for your time on this review

I tested on a Pixel 9 Pro emulator and a Pixel 7 Pro real device. I recorded these two videos with the Pixel 7 Pro :

Without fix :

With fix :

FYI: I am migrating all my open PRs from @manu-sncf to @zemanux

@Renzo-Olivares, I upgraded my flutter engine and rebased the PR from 314ca51 to b1c2289.

I think there is a major regression regarding scrolling semantics on Android. Remove PinnedHeaderSliver from the example, if you attempt to navigate up or down, the focus doesn't move anymore to the previous or next ListTile outside the viewport.

git bisect points to d18ab0e Fix for PR #174374 - TalkBack does not announce list information

Issue #179450 created.

@zemanux Thank you for catching that regression and filing an issue. Once a fix for that regression lands we can move forward with this change.

@Renzo-Olivares, it seems the same issue exists with SliverResizingHeader:

Here is the result with the same fix applied (config.addTagForChildren(RenderViewport.excludeFromScrolling):

Should I include this fix in the current PR, or would you prefer I create a new issue?

@zemanux looks like a fix for the regression has been merged #179480. Can you verify your fix works after this change?

With regards to SliverResizingHeader, I would generally recommend another PR since it's a separate component. Thank you for catching that issue!

@Renzo-Olivares

I created the issue #179687 for SliverResizingHeader.

I confirm the fix works following PR #179480.

I added a new commit (b45a655) to handle an edge case involving a PinnedHeaderSliver positioned in the middle of a list (e.g., a nested list within a SliverMainAxisGroup for a sticky header effect).

Without this fix, config.addTagForChildren(RenderViewport.excludeFromScrolling) add two issues:

• Focus jumping: The semantics focus skips elements after the PinnedHeaderSliver (resolved via overlap control).
• Inconsistent traversal: The inner focus order of PinnedHeaderSliver is inconsistent (resolved by using Semantics(container: true, explicitChildNodes: true)).

Both are now resolved :

import 'package:flutter/material.dart';

void main() => runApp(const MaterialApp(home: MyApp()));

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: CustomScrollView(
        slivers: <Widget>[
          const SliverAppBar(
            pinned: true,
            expandedHeight: 100.0,
            title: Text('Pinned Semantic Focus'),
            backgroundColor: Colors.blue,
          ),
          SliverList(
            delegate: SliverChildBuilderDelegate((BuildContext context, int index) {
              return ListTile(title: Text('Item $index'), subtitle: const Text('Scroll down then navigate back up'));
            }, childCount: 5),
          ),
          PinnedHeaderSliver(
            child: Semantics(
              child: ColoredBox(
                color: Colors.amber,
                child: Column(
                  crossAxisAlignment: CrossAxisAlignment.stretch,
                  children: [
                    Row(
                      mainAxisAlignment: MainAxisAlignment.spaceBetween,
                      spacing: 8,
                      children: [
                        Padding(padding: const EdgeInsets.only(left: 8.0), child: Text('Pinned Header')),
                        IconButton(onPressed: () {}, icon: Icon(Icons.info)),
                      ],
                    ),
                    Padding(
                      padding: const EdgeInsets.all(8.0),
                      child: Semantics(container: true, child: Text('Element')),
                    ),
                  ],
                ),
              ),
            ),
          ),
          // The List
          SliverList(
            delegate: SliverChildBuilderDelegate((BuildContext context, int index) {
              return ListTile(title: Text('Item $index'), subtitle: const Text('Scroll down then navigate back up'));
            }, childCount: 50),
          ),
        ],
      ),
    );
  }
}

@zemanux thank you for your patience over the holidays! I just tried the PR out locally with the provided code sample and it works great.

I do wonder if the additional Semantics(container: true, explicitChildNodes: true) widget is necessary. I just tried the change without it and it seems to provide the same results. Traversal works and focus order seems correct on the pinned header. I also tried to remove additional Semantics widgets in the code sample and that also worked the same. Let me know if you also see this same behavior.

@zemanux thank you for your patience over the holidays! I just tried the PR out locally with the provided code sample and it works great.

I do wonder if the additional Semantics(container: true, explicitChildNodes: true) widget is necessary. I just tried the change without it and it seems to provide the same results. Traversal works and focus order seems correct on the pinned header. I also tried to remove additional Semantics widgets in the code sample and that also worked the same. Let me know if you also see this same behavior.

screen-20260106-120836-1767730062869.mp4

@Renzo-Olivares,
The focus traversal issue only happens when the PinnedHeaderSliver is pinned. Here's a video I just made with the latest rebase (where I removed the Semantics(container: true, explicitChildNodes: true,...).