Skip to content

Implementation of tooltip windows for win32#179147

Merged
mattkae merged 57 commits intoflutter:masterfrom
canonical:feature/tooltips_win32
Jan 8, 2026
Merged

Implementation of tooltip windows for win32#179147
mattkae merged 57 commits intoflutter:masterfrom
canonical:feature/tooltips_win32

Conversation

@mattkae
Copy link
Contributor

@mattkae mattkae commented Nov 26, 2025 •
edited
Loading

What's new?

  • Implemented tooltip windows for the Win32 platform
  • Implemented size-to-content on Win32
  • Wired up the window metrics event with constraints
  • Updated the example application to demonstrate tooltips
  • Wrote a bunch of unit tests

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically d: examples Sample code and demos a: desktop Running on desktop labels Nov 26, 2025
@mattkae mattkae marked this pull request as ready for review December 4, 2025 16:04
robert-ancell
robert-ancell previously requested changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small stuff

@github-actions github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Jan 7, 2026
@loic-sharma loic-sharma dismissed robert-ancell’s stale review January 8, 2026 16:16

Dismissing as Robert is currently on vacation and cannot re-review.

@mattkae mattkae added this pull request to the merge queue Jan 8, 2026
Merged via the queue into flutter:master with commit e064e75 Jan 8, 2026
178 of 179 checks passed
@mattkae mattkae deleted the feature/tooltips_win32 branch January 8, 2026 22:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 9, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026
@engine-flutter-autoroll
e064e75 Implementation of tooltip windows for win32 (flutter/flutter#…
cb4b406 
…179147)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026
@engine-flutter-autoroll
e064e75 Implementation of tooltip windows for win32 (flutter/flutter#…
52c39d2 
…179147)
This was referenced Jan 9, 2026
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026
@engine-flutter-autoroll
e064e75 Implementation of tooltip windows for win32 (flutter/flutter#…
e76382d 
…179147)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 9, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026
@engine-flutter-autoroll
e064e75 Implementation of tooltip windows for win32 (flutter/flutter#…
17c70c6 
…179147)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026
@engine-flutter-autoroll
e064e75 Implementation of tooltip windows for win32 (flutter/flutter#…
6aafae2 
…179147)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026
@engine-flutter-autoroll
e064e75 Implementation of tooltip windows for win32 (flutter/flutter#…
3428158 
…179147)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2026
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026
@engine-flutter-autoroll
e064e75 Implementation of tooltip windows for win32 (flutter/flutter#…
5dd520d 
…179147)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 10, 2026
@engine-flutter-autoroll
Roll Flutter from 01d37bc to 73769a2 (65 revisions) (#10770)
2f21791 
Roll Flutter from 01d37bc to 73769a2 (65 revisions)

flutter/flutter@01d37bc...73769a2

2026-01-10 [email protected] Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800)
2026-01-10 [email protected] Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796)
2026-01-10 [email protected] Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794)
2026-01-10 [email protected] Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824)
2026-01-10 [email protected] Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783)
2026-01-10 [email protected] Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350)
2026-01-10 [email protected] Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478)
2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785)
2026-01-09 [email protected] Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600)
2026-01-09 [email protected] fix: there are no riscv fuchsia artifacts (flutter/flutter#180779)
2026-01-09 [email protected] Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771)
2026-01-09 [email protected] Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022)
2026-01-09 [email protected] Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759)
2026-01-09 [email protected] Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765)
2026-01-09 [email protected] [A11y ] Add `clearSemantics`in table (flutter/flutter#180665)
2026-01-09 [email protected] Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703)
2026-01-09 [email protected] [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711)
2026-01-09 [email protected] Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754)
2026-01-09 [email protected] Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741)
2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761)
2026-01-09 [email protected] Fix typo in dropdown_menu.dart (flutter/flutter#180172)
2026-01-09 [email protected] Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742)
2026-01-09 [email protected] Unpin google_mobile_ads (flutter/flutter#180573)
2026-01-09 [email protected] Update flutter changelog for 3.38.6 (flutter/flutter#180708)
2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709)
2026-01-08 [email protected] Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457)
2026-01-08 [email protected] Implementation of tooltip windows for win32 (flutter/flutter#179147)
2026-01-08 [email protected] [web] Don't serve files outside of project (flutter/flutter#180699)
2026-01-08 [email protected] Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702)
2026-01-08 [email protected] Add new motion accessibility features to iOS. (flutter/flutter#178102)
2026-01-08 [email protected] Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355)
2026-01-08 [email protected] [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658)
2026-01-08 [email protected] De-interleaves engine dart test output (flutter/flutter#180651)
2026-01-08 [email protected] [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958)
2026-01-08 [email protected] Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693)
2026-01-08 [email protected] Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685)
2026-01-08 [email protected] Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583)
2026-01-08 [email protected] Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610)
2026-01-08 [email protected] Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688)
2026-01-08 [email protected] [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655)
2026-01-08 [email protected] Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684)
2026-01-08 [email protected] flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888)
2026-01-08 [email protected] Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679)
2026-01-08 [email protected] Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677)
2026-01-08 [email protected] Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675)
2026-01-08 [email protected] Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673)
...
bufffun pushed a commit to bufffun/flutter that referenced this pull request Jan 21, 2026
@mattkae @knopp @bufffun
Implementation of tooltip windows for win32 (flutter#179147)
8354081 
## What's new?
- Implemented tooltip windows for the Win32 platform
- Implemented size-to-content on Win32
- Wired up the window metrics event with constraints
- Updated the example application to demonstrate tooltips
- Wrote a bunch of unit tests

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Matej Knopp <[email protected]>
# Conflicts:
#	engine/src/flutter/shell/platform/windows/accessibility_plugin_unittests.cc
ivan-vanyusho pushed a commit to ivan-vanyusho/packages that referenced this pull request Jan 26, 2026
@engine-flutter-autoroll @ivan-vanyusho
Roll Flutter from 01d37bc to 73769a2 (65 revisions) (flutter#10770)
931e79c 
Roll Flutter from 01d37bc to 73769a2 (65 revisions)

flutter/flutter@01d37bc...73769a2

2026-01-10 [email protected] Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800)
2026-01-10 [email protected] Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796)
2026-01-10 [email protected] Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794)
2026-01-10 [email protected] Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824)
2026-01-10 [email protected] Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783)
2026-01-10 [email protected] Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350)
2026-01-10 [email protected] Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478)
2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785)
2026-01-09 [email protected] Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600)
2026-01-09 [email protected] fix: there are no riscv fuchsia artifacts (flutter/flutter#180779)
2026-01-09 [email protected] Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771)
2026-01-09 [email protected] Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022)
2026-01-09 [email protected] Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759)
2026-01-09 [email protected] Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765)
2026-01-09 [email protected] [A11y ] Add `clearSemantics`in table (flutter/flutter#180665)
2026-01-09 [email protected] Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703)
2026-01-09 [email protected] [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711)
2026-01-09 [email protected] Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754)
2026-01-09 [email protected] Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741)
2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761)
2026-01-09 [email protected] Fix typo in dropdown_menu.dart (flutter/flutter#180172)
2026-01-09 [email protected] Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742)
2026-01-09 [email protected] Unpin google_mobile_ads (flutter/flutter#180573)
2026-01-09 [email protected] Update flutter changelog for 3.38.6 (flutter/flutter#180708)
2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709)
2026-01-08 [email protected] Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457)
2026-01-08 [email protected] Implementation of tooltip windows for win32 (flutter/flutter#179147)
2026-01-08 [email protected] [web] Don't serve files outside of project (flutter/flutter#180699)
2026-01-08 [email protected] Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702)
2026-01-08 [email protected] Add new motion accessibility features to iOS. (flutter/flutter#178102)
2026-01-08 [email protected] Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355)
2026-01-08 [email protected] [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658)
2026-01-08 [email protected] De-interleaves engine dart test output (flutter/flutter#180651)
2026-01-08 [email protected] [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958)
2026-01-08 [email protected] Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693)
2026-01-08 [email protected] Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685)
2026-01-08 [email protected] Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583)
2026-01-08 [email protected] Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610)
2026-01-08 [email protected] Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688)
2026-01-08 [email protected] [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655)
2026-01-08 [email protected] Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684)
2026-01-08 [email protected] flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888)
2026-01-08 [email protected] Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679)
2026-01-08 [email protected] Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677)
2026-01-08 [email protected] Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675)
2026-01-08 [email protected] Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@robert-ancell robert-ancell Awaiting requested review from robert-ancell

@justinmc justinmc Awaiting requested review from justinmc

@knopp knopp Awaiting requested review from knopp

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. platform-windows Building on or for Windows specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattkae @loic-sharma @knopp @robert-ancell @justinmc