[ios] Reland Dynamic Content Resizing by LouiseHsu · Pull Request #179153 · flutter/flutter

LouiseHsu · 2025-11-26T20:10:48Z

This is a reland of #177410

The previous pr was hitting deadlocks with tests that use screenshots. This reland fixes it by submitting frames asynchronously instead of synchronously.

This PR fixes #169147

This is the iOS implementation of #149033

In Add-to-App scenarios, a common desired use case is to have the embedded FlutterView be able to size itself based on it's content. Up till now, the size had to be manually specified, which can be tedious and inaccurate.

This PR adds a new flag, isAutoResizable, which enables the ability for the embedded flutter view to dynamically set it's own size based off it's content. Note that this feature will NOT work if the the embedded app is wrapped in flexible or unsized widgets, such as Scaffold. The FlutterView will just not display at all.

To use the new flag, just set it like

flutterViewController.autoResizable = true;

or in Swift

flutterViewController.isAutoResizable = true

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request relands dynamic content resizing for iOS, introducing an isAutoResizable flag on FlutterViewController. This allows an embedded Flutter view to size itself based on its content. The implementation uses custom layout constraints and asynchronous frame submission to prevent deadlocks that were an issue in a previous attempt. The changes include new integration and UI tests to validate this functionality. My review identifies a critical crash risk, a potential retain cycle, and several opportunities to improve code maintainability and style.

gemini-code-assist · 2025-11-26T20:13:00Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterView.mm

+  CGFloat scale = self.window.windowScene.screen.scale;
+  CGSize scaledSize = CGSizeMake(size.width / scale, size.height / scale);


Accessing self.window.windowScene.screen.scale can cause a crash if self.window is nil, which can happen if the view is not yet part of a window hierarchy. You should add a check to ensure self.window is not nil before accessing its properties.

Suggested change

CGFloat scale = self.window.windowScene.screen.scale;

CGSize scaledSize = CGSizeMake(size.width / scale, size.height / scale);

UIWindow* window = self.window;

if (!window) {

return;

}

CGFloat scale = window.windowScene.screen.scale;

CGSize scaledSize = CGSizeMake(size.width / scale, size.height / scale);

why didnt you have these thoughts in the original pr

I think this is a valid concern. I don't like returning nothing though. Can we instead use self.traitCollection.displayScale to get the scale?

tbf this is a void function - maybe an error msg abt the view not being part of a window yet instead?

No, I don't like that because when you "set" something it should set it or provide some way to know programmatically that it wasn't set.

Do you not like the idea of getting self.traitCollection.displayScale or if self.window ? self.window.windowScene.screen.scale : self.traitCollection.displayScale?

ah, gotcha.

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsController.mm

dev/integration_tests/ios_host_app/Host/DynamicResizingViewController.m

dev/integration_tests/ios_host_app/flutterapp/lib/resize

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterView.mm

gaaclarke

Looking good, i think the bot had a few good comments. I've noted where it had a point and I have one cleanup note that should happen now that we are using RunNowOrPostTask.

gaaclarke · 2025-11-26T21:25:25Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsController.mm

  if (self.flutterView == nil || (self.compositionOrder.empty() && !self.hadPlatformViews)) {
+    // No platform views to render but the FlutterView may need to be resized.
+    if (self.flutterView != nil) {
+      if (self.platformTaskRunner->RunsTasksOnCurrentThread()) {


This check is no longer necessary, RunNowOrPostTask is doing this for us.

You forgot to push the commit methinks =)

gaaclarke

lgtm! round 2, fight!

auto-submit · 2025-11-26T23:47:29Z

autosubmit label was removed for flutter/flutter/179153, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-12-02T09:54:13Z

autosubmit label was removed for flutter/flutter/179153, because - The status or check suite Windows tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter@5545bb3...e274574 2025-12-03 [email protected] Roll Skia from 20829e37dfb8 to db4c79d41513 (1 revision) (flutter/flutter#179401) 2025-12-03 [email protected] Roll Skia from adc7ea94cada to 20829e37dfb8 (6 revisions) (flutter/flutter#179385) 2025-12-03 [email protected] Refactor GetShaderClipDepth for clarity (flutter/flutter#179110) 2025-12-03 [email protected] Roll Skia from 3b339a83959b to adc7ea94cada (1 revision) (flutter/flutter#179376) 2025-12-03 [email protected] Roll Dart SDK from eb743a1d4ade to 0bb365d7ac74 (7 revisions) (flutter/flutter#179372) 2025-12-03 [email protected] feat: Add `mainAxisExtent` parameter to `GridView` constructors (flutter/flutter#176927) 2025-12-03 [email protected] Roll Skia from eb01fff20df8 to 3b339a83959b (4 revisions) (flutter/flutter#179371) 2025-12-02 [email protected] Fix crash when text editing value changes between scrolls (flutter/flutter#179163) 2025-12-02 [email protected] Roll Skia from 6bd3b06b1e08 to eb01fff20df8 (3 revisions) (flutter/flutter#179362) 2025-12-02 [email protected] Adds Impellerc flatbuffer format versioning. (flutter/flutter#175470) 2025-12-02 [email protected] Adds format argument to Picture.toImageSync (flutter/flutter#178691) 2025-12-02 [email protected] Delete disabled workflow and add missing permissions key to workflow (flutter/flutter#178911) 2025-12-02 [email protected] [web] Fix some gn warnings (flutter/flutter#178313) 2025-12-02 [email protected] Roll Skia from 45337c4e919d to 6bd3b06b1e08 (4 revisions) (flutter/flutter#179353) 2025-12-02 [email protected] [ios] Reland Dynamic Content Resizing (flutter/flutter#179153) 2025-12-02 [email protected] [web] Fix onTextScaleFactorChanged not getting called. (flutter/flutter#178862) 2025-12-02 [email protected] Roll Packages from c8be05d to 148dcd2 (9 revisions) (flutter/flutter#179343) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This is a reland of flutter#177410 The previous pr was hitting deadlocks with tests that use screenshots. This reland fixes it by submitting frames asynchronously instead of synchronously. This PR fixes flutter#169147 This is the iOS implementation of flutter#149033 In Add-to-App scenarios, a common desired use case is to have the embedded FlutterView be able to size itself based on it's content. Up till now, the size had to be manually specified, which can be tedious and inaccurate. This PR adds a new flag, `isAutoResizable`, which enables the ability for the embedded flutter view to dynamically set it's own size based off it's content. Note that this feature will *NOT* work if the the embedded app is wrapped in flexible or unsized widgets, such as Scaffold. The FlutterView will just not display at all. To use the new flag, just set it like ``` flutterViewController.autoResizable = true; ``` or in Swift ``` flutterViewController.isAutoResizable = true ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

flutter/flutter@5545bb3...e274574 2025-12-03 [email protected] Roll Skia from 20829e37dfb8 to db4c79d41513 (1 revision) (flutter/flutter#179401) 2025-12-03 [email protected] Roll Skia from adc7ea94cada to 20829e37dfb8 (6 revisions) (flutter/flutter#179385) 2025-12-03 [email protected] Refactor GetShaderClipDepth for clarity (flutter/flutter#179110) 2025-12-03 [email protected] Roll Skia from 3b339a83959b to adc7ea94cada (1 revision) (flutter/flutter#179376) 2025-12-03 [email protected] Roll Dart SDK from eb743a1d4ade to 0bb365d7ac74 (7 revisions) (flutter/flutter#179372) 2025-12-03 [email protected] feat: Add `mainAxisExtent` parameter to `GridView` constructors (flutter/flutter#176927) 2025-12-03 [email protected] Roll Skia from eb01fff20df8 to 3b339a83959b (4 revisions) (flutter/flutter#179371) 2025-12-02 [email protected] Fix crash when text editing value changes between scrolls (flutter/flutter#179163) 2025-12-02 [email protected] Roll Skia from 6bd3b06b1e08 to eb01fff20df8 (3 revisions) (flutter/flutter#179362) 2025-12-02 [email protected] Adds Impellerc flatbuffer format versioning. (flutter/flutter#175470) 2025-12-02 [email protected] Adds format argument to Picture.toImageSync (flutter/flutter#178691) 2025-12-02 [email protected] Delete disabled workflow and add missing permissions key to workflow (flutter/flutter#178911) 2025-12-02 [email protected] [web] Fix some gn warnings (flutter/flutter#178313) 2025-12-02 [email protected] Roll Skia from 45337c4e919d to 6bd3b06b1e08 (4 revisions) (flutter/flutter#179353) 2025-12-02 [email protected] [ios] Reland Dynamic Content Resizing (flutter/flutter#179153) 2025-12-02 [email protected] [web] Fix onTextScaleFactorChanged not getting called. (flutter/flutter#178862) 2025-12-02 [email protected] Roll Packages from c8be05d to 148dcd2 (9 revisions) (flutter/flutter#179343) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

LouiseHsu and others added 30 commits October 22, 2025 12:34

init

d9437d0

tests

284d9e2

formattttttt

9d8dae4

Merge branch 'master' into ios-resizing-final

3039822

tests

a66cd95

.

93d23b9

.

d22e355

test

365b35e

.

f42c704

analyze

b206a41

.

e5d91f0

clean up

06927d7

more clean up

31d4ec3

Merge branch 'master' into ios-resizing-final

860f048

formatting 😞

9548048

rainbows heheh

4a8eb68

test

0a70bfa

test

f8d0c82

test?

4424868

test

7c4e98e

Merge branch 'master' into ios-resizing-final

2782e76

test test test

b0937c6

format :D

f808ead

change to gesture detector in test app and misc feedback

818ba30

fix test

4291535

.

f064def

.

58a7461

add warning

52fe77d

fOrMaT

0e13cee

spelling

87a5e99

github-actions bot added the team-ios Owned by iOS platform team label Nov 26, 2025

gemini-code-assist bot reviewed Nov 26, 2025

View reviewed changes

gemini feedback

0f2b5d8

gaaclarke reviewed Nov 26, 2025

View reviewed changes

pr comments

2450a7b

gaaclarke approved these changes Nov 26, 2025

View reviewed changes

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 26, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 26, 2025

LouiseHsu and others added 3 commits November 26, 2025 21:31

Merge branch 'master' into ios-resizing-final

4481e3a

format

8bb8135

Merge branch 'master' into ios-resizing-final

b2ad657

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2025

Merge branch 'master' into ios-resizing-final

d8331a1

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2025

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2025

auto-submit bot added this pull request to the merge queue Dec 2, 2025

Merged via the queue into flutter:master with commit 1bf445b Dec 2, 2025
182 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 3, 2025

1bf445b [ios] Reland Dynamic Content Resizing (flutter/flutter#179153)

15ef33d

engine-flutter-autoroll mentioned this pull request Dec 3, 2025

Roll Flutter from 5545bb397e7b to e27457436b04 (17 revisions) flutter/packages#10554

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 3, 2025

1bf445b [ios] Reland Dynamic Content Resizing (flutter/flutter#179153)

c628ed0

engine-flutter-autoroll mentioned this pull request Dec 3, 2025

Roll Flutter from 5545bb397e7b to 5c64d54db667 (18 revisions) flutter/packages#10555

Closed

Piinks mentioned this pull request Dec 12, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

1bf445b [ios] Reland Dynamic Content Resizing (flutter/flutter#179153)

031f98c

		CGFloat scale = self.window.windowScene.screen.scale;
		CGSize scaledSize = CGSizeMake(size.width / scale, size.height / scale);

Conversation

LouiseHsu commented Nov 26, 2025

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LouiseHsu Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Nov 26, 2025

Uh oh!

auto-submit bot commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LouiseHsu Nov 26, 2025 •

edited

Loading