Skip to content

Fix SliverResizingHeader semantic focus#179690

Open
zemanux wants to merge 2 commits intoflutter:masterfrom
zemanux:sliver_resizing_header_semantics_focus
Open

Fix SliverResizingHeader semantic focus#179690
zemanux wants to merge 2 commits intoflutter:masterfrom
zemanux:sliver_resizing_header_semantics_focus

Conversation

@zemanux
Copy link
Contributor

@zemanux zemanux commented Dec 10, 2025

Fix #179687

Pre-launch Checklist

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Dec 10, 2025
@zemanux zemanux force-pushed the sliver_resizing_header_semantics_focus branch 3 times, most recently from e8f1928 to 10f3194 Compare December 30, 2025 14:10
@Renzo-Olivares Renzo-Olivares self-requested a review January 6, 2026 20:11
@zemanux zemanux force-pushed the sliver_resizing_header_semantics_focus branch from 10f3194 to d305b63 Compare January 21, 2026 07:33
@zemanux zemanux force-pushed the sliver_resizing_header_semantics_focus branch from d305b63 to 50b0f2d Compare February 4, 2026 13:04
@zemanux zemanux marked this pull request as ready for review February 4, 2026 14:02
@zemanux zemanux force-pushed the sliver_resizing_header_semantics_focus branch from 50b0f2d to 70b1bc1 Compare February 4, 2026 14:03
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses the semantic focus issue in SliverResizingHeader by correctly applying Semantics properties and the RenderViewport.excludeFromScrolling tag. The refactoring in applyPaintTransform to use applyPaintTransformForBoxChild improves code maintainability. The addition of a dedicated test case for semantics ensures the new accessibility behavior is verified.

@zemanux
Copy link
Contributor Author

zemanux commented Feb 4, 2026

@Renzo-Olivares, this PR duplicate #179023 (updated with last comments) to fix semantic focus problem on SliverResizingHeader.
I don't know why test fails: https://github.com/flutter/flutter/pull/179690/checks?check_run_id=62490759402

@Renzo-Olivares
Copy link
Contributor

Renzo-Olivares commented Feb 17, 2026

@zemanux The test failures seem unrelated. You can try rebasing to the master branch and see if that helps fix the issue.

Renzo-Olivares
Renzo-Olivares reviewed Feb 17, 2026
View reviewed changes
packages/flutter/test/widgets/sliver_resizing_header_test.dart

testWidgets(
'SliverResizingHeader: presence of RenderViewport.excludeFromScrolling tag when pinned',
(WidgetTester tester) async {
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the following to the top of this test.

// Regression test for https://github.com/flutter/flutter/issues/179687.

Copy link
Contributor Author

@zemanux zemanux Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@zemanux zemanux force-pushed the sliver_resizing_header_semantics_focus branch from 70b1bc1 to 53468de Compare February 23, 2026 08:16
@justinmc justinmc requested a review from Renzo-Olivares March 3, 2026 23:26
@zemanux zemanux force-pushed the sliver_resizing_header_semantics_focus branch from 53468de to 7abc3c9 Compare March 11, 2026 20:39
@zemanux zemanux force-pushed the sliver_resizing_header_semantics_focus branch from 7abc3c9 to 69a3c52 Compare March 11, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Awaiting requested review from Renzo-Olivares

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Accessibility] SliverResizingHeader captures semantic focus before list is fully scrolled

2 participants

@zemanux @Renzo-Olivares