Update Skwasm to engine style guidelines. by eyebrowsoffire · Pull Request #179756 · flutter/flutter

eyebrowsoffire · 2025-12-11T20:07:16Z

This updates the Skwasm library to conform to the style of the rest of the engine. This includes:

Moving the location of the skwasm library into engine/src/flutter/skwasm instead of engine/src/flutter/lib/web_ui/skwasm, since that was altogether too nested and weird.
Changed all the file extensions to .cc instead of .cpp
Changed all local include paths to be from the engine/src/flutter directory rather than relying on the source file's location.
Changed ordering of include paths.
Removed instances of using namespace
Changed local variable names and argument names to use snake_case
Changed class functions to use UpperCamelCase
Changed private member variables to use trailing_ underscore instead of _leading.
Removed some uses of auto

… variables.

flutter-dashboard · 2025-12-11T20:07:20Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request is a large refactoring to align the Skwasm library with the engine's C++ style guidelines. The changes include moving files to a new directory, renaming file extensions from .cpp to .cc, updating include paths, and applying naming conventions for variables, functions, and members. My review focuses on areas where the new style conventions were missed. I've pointed out several free-standing functions that should be renamed to UpperCamelCase to fully comply with the Google C++ Style Guide, as adopted by the project.

engine/src/flutter/skwasm/images_skia.cc

engine/src/flutter/skwasm/shaders_impeller.cc

gaaclarke

lgtm! I don't know if we got everything but this is definitely a huge step to getting us there. We can address anything else as they come up in code reviews. Thanks jackson, I hope the bot was able to do a lot of the heavy lifting.

engine/src/flutter/skwasm/canvas_text.h

auto-submit · 2025-12-12T22:25:24Z

autosubmit label was removed for flutter/flutter/179756, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…9756)

Roll Flutter from 6e1aa82 to d81baab (47 revisions) flutter/flutter@6e1aa82...d81baab 2025-12-16 [email protected] Revert "chore: linux fuchsia tests are flaking" (flutter/flutter#179897) 2025-12-15 [email protected] add default-linux-sysroot to gn frontend args (flutter/flutter#179303) 2025-12-15 [email protected] Roll pub packages (flutter/flutter#179751) 2025-12-15 [email protected] Roll Skia from 783ce2077e46 to 6903a4e65c3f (2 revisions) (flutter/flutter#179903) 2025-12-15 [email protected] Add `Adwaita Sans` as a font fallback on Linux (flutter/flutter#179144) 2025-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unmodified android sdk bundle (#179647)" (flutter/flutter#179904) 2025-12-15 [email protected] Update window settings as they change rather than the more outdated "Apply" pattern. (flutter/flutter#179861) 2025-12-15 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 5.0.1 to 6.0.0 in the all-github-actions group (flutter/flutter#179901) 2025-12-15 [email protected] Roll Skia from 9decbd4c216b to 783ce2077e46 (2 revisions) (flutter/flutter#179896) 2025-12-15 [email protected] Unmodified android sdk bundle (flutter/flutter#179647) 2025-12-15 [email protected] [web] Fix `resizeToAvoidBottomInset` on Android web (flutter/flutter#179581) 2025-12-15 [email protected] Suppress deprecation warning for AChoreographer_postFrameCallback (flutter/flutter#178580) 2025-12-15 [email protected] remove unnecessary virtual destructor from VertexDescriptor (flutter/flutter#178682) 2025-12-15 [email protected] Roll Dart SDK from b245f6022727 to 20d114f951db (1 revision) (flutter/flutter#179893) 2025-12-15 [email protected] [Impeller] Delete GLES framebuffer objects only on the thread where they were created (flutter/flutter#179768) 2025-12-15 [email protected] [Impeller] Convert paths in ImpellerC command line flags to std::filesystem::path objects (flutter/flutter#179717) 2025-12-15 [email protected] Roll Skia from 5e1ff611b36b to 9decbd4c216b (2 revisions) (flutter/flutter#179890) 2025-12-15 [email protected] Roll Fuchsia Linux SDK from DtfDWAx6t_CsD2e1W... to 433KtmJvbMyaDMJvD... (flutter/flutter#179889) 2025-12-15 [email protected] Remove unnecessary unboxing in `FlutterLoader.java‎` (flutter/flutter#179869) 2025-12-15 [email protected] Roll Skia from f04f8ca3b284 to 5e1ff611b36b (1 revision) (flutter/flutter#179882) 2025-12-15 [email protected] Roll Packages from 0ac7a03 to 2cd921c (1 revision) (flutter/flutter#179885) 2025-12-15 [email protected] [ Widget Preview ] Pass DTD URI as a constant in a generated file (flutter/flutter#179821) 2025-12-15 [email protected] Bump minSdk to `24` in `engine` (flutter/flutter#175508) 2025-12-15 [email protected] Roll Dart SDK from bca8bb37d95f to b245f6022727 (1 revision) (flutter/flutter#179879) 2025-12-15 [email protected] Roll Skia from eb1347d18957 to f04f8ca3b284 (1 revision) (flutter/flutter#179876) 2025-12-15 [email protected] Roll Skia from 41bcfb848b13 to eb1347d18957 (1 revision) (flutter/flutter#179871) 2025-12-15 [email protected] Roll Skia from d194c3b7a9a9 to 41bcfb848b13 (6 revisions) (flutter/flutter#179866) 2025-12-14 [email protected] Remove obsolete windowing channel (flutter/flutter#179718) 2025-12-14 [email protected] Roll Fuchsia Linux SDK from SCLq31whvg8nJvuYE... to DtfDWAx6t_CsD2e1W... (flutter/flutter#179856) 2025-12-14 [email protected] Roll Skia from 5d98ce0af031 to d194c3b7a9a9 (1 revision) (flutter/flutter#179854) 2025-12-13 [email protected] Roll Skia from f9b242d9a365 to 5d98ce0af031 (1 revision) (flutter/flutter#179843) 2025-12-13 [email protected] Roll Skia from abe90c72cf56 to f9b242d9a365 (1 revision) (flutter/flutter#179838) 2025-12-13 [email protected] Roll Fuchsia Linux SDK from fppT9ZrwbFx7iYrIh... to SCLq31whvg8nJvuYE... (flutter/flutter#179836) 2025-12-13 [email protected] Roll Dart SDK from 34654f2a3baa to bca8bb37d95f (1 revision) (flutter/flutter#179835) 2025-12-13 [email protected] Roll Skia from 9e7c893bb593 to abe90c72cf56 (1 revision) (flutter/flutter#179830) 2025-12-13 [email protected] Roll Dart SDK from f105c2168574 to 34654f2a3baa (1 revision) (flutter/flutter#179823) 2025-12-13 [email protected] Add FilterQuality parameter to FragmentShader.setImageSampler (flutter/flutter#179760) 2025-12-13 [email protected] Add profiling counts to pipeline uses (flutter/flutter#179374) 2025-12-13 [email protected] Roll Skia from edf52cb27f29 to 9e7c893bb593 (3 revisions) (flutter/flutter#179819) 2025-12-12 [email protected] Update Skwasm to engine style guidelines. (flutter/flutter#179756) 2025-12-12 [email protected] Roll Dart SDK from 9a65db770758 to f105c2168574 (5 revisions) (flutter/flutter#179814) 2025-12-12 [email protected] Roll Skia from f23b00a407a4 to edf52cb27f29 (5 revisions) (flutter/flutter#179807) 2025-12-12 [email protected] Use depth buffer to implement geometry overdraw protection (flutter/flutter#179426) 2025-12-12 [email protected] [flutter_tool] Force UTF-8 character set for dev (flutter/flutter#179419) 2025-12-12 [email protected] Roll Skia from e66816c3645e to f23b00a407a4 (2 revisions) (flutter/flutter#179798) 2025-12-12 [email protected] Implements decodeImageFromPixelsSync (flutter/flutter#179519) ...

…9756)

eyebrowsoffire added 6 commits December 9, 2025 14:13

Move skwasm files.

ee54865

Change file extensions.

cabe49b

Fix include paths.

c1b8847

Remove using namespace and qualify names

a78d7f5

Update local variable names, class function names, and private member…

1dc32c6

… variables.

Update argument names to snake_case.

a39e4bd

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Dec 11, 2025

eyebrowsoffire requested a review from gaaclarke December 11, 2025 20:07

gemini-code-assist bot reviewed Dec 11, 2025

View reviewed changes

engine/src/flutter/skwasm/images_skia.cc Outdated Show resolved Hide resolved

engine/src/flutter/skwasm/images_skia.cc Outdated Show resolved Hide resolved

engine/src/flutter/skwasm/shaders_impeller.cc Outdated Show resolved Hide resolved

gaaclarke approved these changes Dec 11, 2025

View reviewed changes

engine/src/flutter/skwasm/canvas_text.h Outdated Show resolved Hide resolved

eyebrowsoffire added 4 commits December 12, 2025 09:34

Fixed some style updates suggested by Aaron and Gemini.

69e0dd1

Merge branch 'master' into skwasm_style

aae5e7a

Whoops, forgot to commit the canvas.cc changes.

5ba62b8

Add skwasm to .clang-tidy header regex.

a840b29

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 12, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 12, 2025

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 12, 2025

auto-submit bot added this pull request to the merge queue Dec 12, 2025

Merged via the queue into flutter:master with commit 1963354 Dec 12, 2025
182 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 12, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

5c345a3

…9756)

engine-flutter-autoroll mentioned this pull request Dec 13, 2025

Roll Flutter from 6e1aa823523d to 3355a1d031e3 (15 revisions) flutter/packages#10618

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

bd75e32

…9756)

engine-flutter-autoroll mentioned this pull request Dec 13, 2025

Roll Flutter from 6e1aa823523d to f13792c679ad (16 revisions) flutter/packages#10619

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

ef74301

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

8fb6a38

…9756)

engine-flutter-autoroll mentioned this pull request Dec 16, 2025

Roll Flutter from 6e1aa823523d to d81baabfec4c (47 revisions) flutter/packages#10637

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

cbabbd3

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

970f6bf

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

9b5c803

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

f292ddc

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

8dc333f

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

25d1ab8

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

1f6a52e

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

8a3d027

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

563da40

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

a7eb2a7

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

29edf61

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

7487d64

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

e21e011

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

ed32e02

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

a804c0d

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

6d59ff8

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

86c6c02

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

ce01f00

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

a89a74e

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

dbaf11a

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

edd06b0

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

7032e43

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

0a07479

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

df8002e

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

b87d05f

…9756)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

1963354 Update Skwasm to engine style guidelines. (flutter/flutter#17…

368ed8f

…9756)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Skwasm to engine style guidelines.#179756

Update Skwasm to engine style guidelines.#179756
auto-submit[bot] merged 10 commits intoflutter:masterfrom
eyebrowsoffire:skwasm_style

eyebrowsoffire commented Dec 11, 2025

Uh oh!

flutter-dashboard bot commented Dec 11, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke left a comment

Uh oh!

Uh oh!

auto-submit bot commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eyebrowsoffire commented Dec 11, 2025

Uh oh!

flutter-dashboard bot commented Dec 11, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants