Skip to content

Implement popup windows in the API and test code#179757

Merged
mattkae merged 7 commits intoflutter:masterfrom
canonical:feature/popup_windows_api
Jan 5, 2026
Merged

Implement popup windows in the API and test code#179757
mattkae merged 7 commits intoflutter:masterfrom
canonical:feature/popup_windows_api

Conversation

@mattkae
Copy link
Contributor

@mattkae mattkae commented Dec 11, 2025

What's new?

  • Add PopupWindowController, PopupWindowControllerDelegate, and PopupWindow
  • Implement reference logic for popup windows in the test bindings
  • Add tests for the popup windows API

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Dec 11, 2025
@github-actions github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos a: desktop Running on desktop labels Dec 12, 2025
@mattkae mattkae marked this pull request as ready for review December 16, 2025 19:02
justinmc
justinmc approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mattkae mattkae enabled auto-merge January 5, 2026 16:37
@mattkae mattkae added this pull request to the merge queue Jan 5, 2026
Merged via the queue into flutter:master with commit 4333b77 Jan 5, 2026
68 of 69 checks passed
@mattkae mattkae deleted the feature/popup_windows_api branch January 5, 2026 17:48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
ade5148 
…tter#179757)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 5, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
fc2d2ba 
…tter#179757)
This was referenced Jan 5, 2026
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
b1a9ed6 
…tter#179757)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
8a13397 
…tter#179757)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
6663d65 
…tter#179757)
This was referenced Jan 6, 2026
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
d0fbd04 
…tter#179757)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
6f08edf 
…tter#179757)
This was referenced Jan 6, 2026
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
5ed7c9b 
…tter#179757)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
ad49f27 
…tter#179757)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
3e5f7e2 
…tter#179757)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
ac40f53 
…tter#179757)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
ba7d2ed 
…tter#179757)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
e00f182 
…tter#179757)
bufffun pushed a commit to bufffun/flutter that referenced this pull request Jan 21, 2026
@mattkae @bufffun
Implement popup windows in the API and test code (flutter#179757)
cbcf8af 
## What's new?
- Add `PopupWindowController`, `PopupWindowControllerDelegate`, and
`PopupWindow`
- Implement reference logic for popup windows in the test bindings
- Add tests for the popup windows API

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
# Conflicts:
#	packages/flutter/test/widgets/windowing_test.dart
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
4333b77 Implement popup windows in the API and test code (flutter/flu…
a21cde1 
…tter#179757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

@knopp knopp Awaiting requested review from knopp

Assignees

No one assigned

Labels

a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattkae @justinmc