Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment by ahmedsameha1 · Pull Request #179824 · flutter/flutter

ahmedsameha1 · 2025-12-13T04:38:43Z

This is my attempt to handle #6537 for the CupertinoTabScaffold widget.

gemini-code-assist

Code Review

This pull request introduces a regression test to address a crash in CupertinoTabScaffold when it is rendered within a zero-sized environment. The new test case effectively simulates this scenario by placing the widget inside a SizedBox.shrink(). The test verifies that the application does not crash and that the CupertinoTabScaffold correctly reports its size as zero, confirming the fix for the edge case. The test is well-structured and serves as a good safeguard against future regressions.

auto-submit · 2025-12-17T06:41:16Z

autosubmit label was removed for flutter/flutter/179824, because - The status or check suite Windows framework_tests_libraries_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-12-17T19:50:24Z

autosubmit label was removed for flutter/flutter/179824, because - The status or check suite Windows framework_tests_libraries_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-12-17T21:32:51Z

autosubmit label was removed for flutter/flutter/179824, because - The status or check suite Windows framework_tests_libraries_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label.

victorsanni · 2025-12-17T22:44:12Z

I think the leak is legit but can't figure out why.

dkwingsmt · 2026-01-05T23:39:36Z

I did some research and here's my suggestion:

Add imageCache.clear(); to the end of this new test case.
Remove the following block from the beginning of main:

  tearDown(() {
    imageCache.clear();
  });

Explanation: Basically the tearDown clearance doesn't work. Before the PR it was used only for 'System back navigation inside of tabs', which has its own imageCache.clear(); at the end of the case. I suspect that the tearDown doesn't work because clearing the image cache is actually performed in a post-frame callback (image_cache.dart L607) which is not executed if the command was added as a tearDown.

…area test

auto-submit · 2026-01-06T08:26:06Z

autosubmit label was removed for flutter/flutter/179824, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

auto-submit · 2026-01-10T00:31:42Z

autosubmit label was removed for flutter/flutter/179824, because - The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

…vironment (flutter/flutter#179824)

Roll Flutter from 01d37bc to 73769a2 (65 revisions) flutter/flutter@01d37bc...73769a2 2026-01-10 [email protected] Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800) 2026-01-10 [email protected] Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796) 2026-01-10 [email protected] Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794) 2026-01-10 [email protected] Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824) 2026-01-10 [email protected] Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783) 2026-01-10 [email protected] Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350) 2026-01-10 [email protected] Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478) 2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785) 2026-01-09 [email protected] Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600) 2026-01-09 [email protected] fix: there are no riscv fuchsia artifacts (flutter/flutter#180779) 2026-01-09 [email protected] Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771) 2026-01-09 [email protected] Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022) 2026-01-09 [email protected] Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759) 2026-01-09 [email protected] Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765) 2026-01-09 [email protected] [A11y ] Add `clearSemantics`in table (flutter/flutter#180665) 2026-01-09 [email protected] Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703) 2026-01-09 [email protected] [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711) 2026-01-09 [email protected] Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754) 2026-01-09 [email protected] Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741) 2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761) 2026-01-09 [email protected] Fix typo in dropdown_menu.dart (flutter/flutter#180172) 2026-01-09 [email protected] Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742) 2026-01-09 [email protected] Unpin google_mobile_ads (flutter/flutter#180573) 2026-01-09 [email protected] Update flutter changelog for 3.38.6 (flutter/flutter#180708) 2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709) 2026-01-08 [email protected] Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457) 2026-01-08 [email protected] Implementation of tooltip windows for win32 (flutter/flutter#179147) 2026-01-08 [email protected] [web] Don't serve files outside of project (flutter/flutter#180699) 2026-01-08 [email protected] Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702) 2026-01-08 [email protected] Add new motion accessibility features to iOS. (flutter/flutter#178102) 2026-01-08 [email protected] Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355) 2026-01-08 [email protected] [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658) 2026-01-08 [email protected] De-interleaves engine dart test output (flutter/flutter#180651) 2026-01-08 [email protected] [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958) 2026-01-08 [email protected] Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693) 2026-01-08 [email protected] Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685) 2026-01-08 [email protected] Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583) 2026-01-08 [email protected] Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610) 2026-01-08 [email protected] Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688) 2026-01-08 [email protected] [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655) 2026-01-08 [email protected] Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684) 2026-01-08 [email protected] flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888) 2026-01-08 [email protected] Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679) 2026-01-08 [email protected] Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677) 2026-01-08 [email protected] Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675) 2026-01-08 [email protected] Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673) ...

Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment

b678826

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Dec 13, 2025

gemini-code-assist bot reviewed Dec 13, 2025

View reviewed changes

victorsanni approved these changes Dec 17, 2025

View reviewed changes

victorsanni requested a review from dkwingsmt December 17, 2025 00:44

dkwingsmt approved these changes Dec 17, 2025

View reviewed changes

Merge branch 'master' into handle#6537-CupertinoTabScaffold

49ec359

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025

Merge branch 'master' into handle#6537-CupertinoTabScaffold

759ec69

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025

Merge branch 'master' into handle#6537-CupertinoTabScaffold

09c3b88

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2025

victorsanni and others added 2 commits December 18, 2025 14:06

Merge branch 'master' into handle#6537-CupertinoTabScaffold

5bc34ed

Merge branch 'master' into handle#6537-CupertinoTabScaffold

f0a3f7b

Trying to solve the Windows leak that happened after adding the zero …

bc05946

…area test

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2026

victorsanni added 2 commits January 6, 2026 00:29

Merge branch 'master' into handle#6537-CupertinoTabScaffold

d3b9846

Merge branch 'master' into handle#6537-CupertinoTabScaffold

2dae60b

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2026

Merge branch 'master' into handle#6537-CupertinoTabScaffold

6f42d6c

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2026

auto-submit bot added this pull request to the merge queue Jan 10, 2026

Merged via the queue into flutter:master with commit eb95ba4 Jan 10, 2026
70 of 71 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2026

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 0b7596b3f269 (64 revisions) flutter/packages#10768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

eb95ba4 Make sure that a CupertinoTabScaffold doesn't crash in 0x0 en…

c90ff73

…vironment (flutter/flutter#179824)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

eb95ba4 Make sure that a CupertinoTabScaffold doesn't crash in 0x0 en…

fded1a3

…vironment (flutter/flutter#179824)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10770

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

eb95ba4 Make sure that a CupertinoTabScaffold doesn't crash in 0x0 en…

86ff0ac

…vironment (flutter/flutter#179824)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment#179824

Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment#179824
auto-submit[bot] merged 10 commits intoflutter:masterfrom
ahmedsameha1:handle#6537-CupertinoTabScaffold

ahmedsameha1 commented Dec 13, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

auto-submit bot commented Dec 17, 2025

Uh oh!

auto-submit bot commented Dec 17, 2025

Uh oh!

auto-submit bot commented Dec 17, 2025

Uh oh!

victorsanni commented Dec 17, 2025

Uh oh!

dkwingsmt commented Jan 5, 2026

Uh oh!

auto-submit bot commented Jan 6, 2026

Uh oh!

auto-submit bot commented Jan 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ahmedsameha1 commented Dec 13, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

auto-submit bot commented Dec 17, 2025

Uh oh!

auto-submit bot commented Dec 17, 2025

Uh oh!

auto-submit bot commented Dec 17, 2025

Uh oh!

victorsanni commented Dec 17, 2025

Uh oh!

dkwingsmt commented Jan 5, 2026

Uh oh!

auto-submit bot commented Jan 6, 2026

Uh oh!

auto-submit bot commented Jan 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants