Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
tool
|
@liamappelbe Do we need to remember to bump these templates manually occasionally (or automate it)? I believe there's currently no automation for that... |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ffigen dependency from ^13.0.0 to ^20.1.1 across various templates (package_ffi and plugin_shared). To accommodate breaking changes in the new ffigen version, the templates for generated code have been adjusted. Specifically, the preamble configuration has been removed from ffigen.yaml.tmpl files, and the generated Dart binding templates (..._bindings_generated.dart.tmpl) have been updated with new ignore_for_file comments and reformatted according to the latest dart format standards.
goderbauer
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
2 participants
No description provided.