[ Widget Preview ] Add support for `dart:ffi` imports by bkonyi · Pull Request #180586 · flutter/flutter

bkonyi · 2026-01-06T16:48:31Z

Adds logic to pass --include-unsupported-platform-library-stubs to the CFE when launched via flutter widget-preview start, as well as logic to ensure the flag can't be passed as an extra frontend option to bypass compile time errors due to imports of unsupported libraries.

Fixes #166431

Adds logic to pass `--include-unsupported-platform-library-stubs` to the CFE when launched via `flutter widget-preview start`, as well as logic to ensure the flag can't be passed as an extra frontend option to bypass compile time errors due to imports of unsupported libraries. Fixes flutter#166431

jyameo

lgtm!

…et_preview_ffi_support

gemini-code-assist

Code Review

This pull request adds support for dart:ffi imports in the widget preview feature by passing the --include-unsupported-platform-library-stubs flag to the Dart frontend compiler (CFE) for the dartdevc target.

The changes include:

Updating the BUILD.gn file to pass the flag when building the web SDK's DDC platform summary.
Adding an includeUnsupportedPlatformLibraryStubs flag to BuildInfo and passing it to the ResidentCompiler.
Enabling this flag for the widget-preview start command.
Adding safeguards to filter this flag from user-provided extraFrontEndOptions and restricting its use to the dartdevc target model.
Adding tests to verify the new logic and safeguards.

The changes appear to correctly implement the intended feature and include measures to prevent misuse. I have one suggestion to make the error message in compile.dart more general for future maintainability.

packages/flutter_tools/lib/src/compile.dart

auto-submit · 2026-01-06T20:01:16Z

autosubmit label was removed for flutter/flutter/180586, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-01-07T00:03:28Z

autosubmit label was removed for flutter/flutter/180586, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r/flutter#180586)

Roll Flutter from 13b2b91 to 01d37bc (74 revisions) flutter/flutter@13b2b91...01d37bc 2026-01-07 [email protected] Replace Hybrid Composition wiki page with dev-facing content (flutter/flutter#180642) 2026-01-07 [email protected] Improve code quality in `FlutterActivityTest.java` (flutter/flutter#180585) 2026-01-07 [email protected] Roll Dart SDK to 3.11.0-296.1.beta (flutter/flutter#180633) 2026-01-07 [email protected] Bump target Windows version to 10 (flutter/flutter#180624) 2026-01-07 [email protected] Run hook_user_defines and link_hook integration tests on CI (flutter/flutter#180622) 2026-01-07 [email protected] Fix division by zero in RenderTable intrinsic size methods (flutter/flutter#178217) 2026-01-07 [email protected] Remove more `requires 24` anotations (flutter/flutter#180116) 2026-01-07 [email protected] Roll Skia from 3971dbb85d45 to c5359a4d720e (1 revision) (flutter/flutter#180631) 2026-01-07 [email protected] Fix TabBar.image does not render at initialIndex for the first time (flutter/flutter#179616) 2026-01-07 [email protected] Roll Skia from 1e7ad625f6f7 to 3971dbb85d45 (3 revisions) (flutter/flutter#180627) 2026-01-07 [email protected] Unpin DDS (flutter/flutter#180571) 2026-01-07 [email protected] Fix DropdownMenuEntry.style not resolved when entry is highlighted (flutter/flutter#178873) 2026-01-07 [email protected] Remove unnecessary `@RequiresApi24` annotations from FlutterFragment methods (flutter/flutter#180117) 2026-01-07 [email protected] Roll Skia from 7fc63228056b to 1e7ad625f6f7 (1 revision) (flutter/flutter#180616) 2026-01-07 [email protected] Roll Fuchsia Linux SDK from QfR2ZFZ5kGTD3raO3... to dTvN_JVSCfGFRasvH... (flutter/flutter#180612) 2026-01-07 [email protected] [ Widget Preview ] Add support for `dart:ffi` imports (flutter/flutter#180586) 2026-01-07 [email protected] Roll Skia from eec90000a899 to 7fc63228056b (2 revisions) (flutter/flutter#180608) 2026-01-07 [email protected] Add --web-define flag for template variable injection in Flutter web builds (flutter/flutter#175805) 2026-01-07 [email protected] docs(engine): update rbe notes (flutter/flutter#180599) 2026-01-06 [email protected] Roll Skia from b6249496c230 to eec90000a899 (3 revisions) (flutter/flutter#180602) 2026-01-06 [email protected] Forward proxy 404 responses to client (flutter/flutter#179858) 2026-01-06 [email protected] Roll Dart SDK from 40a8c6188f7f to d2e3ce177270 (1 revision) (flutter/flutter#180598) 2026-01-06 [email protected] Restore CLI precedence for web headers and HTTPS over web_dev_config.yaml (flutter/flutter#179639) 2026-01-06 [email protected] Roll Skia from f5d9da13d56d to b6249496c230 (1 revision) (flutter/flutter#180596) 2026-01-06 [email protected] Enable misc leak tracking (flutter/flutter#176992) 2026-01-06 [email protected] [hooks] Don't require NDK for Android targets (flutter/flutter#180594) 2026-01-06 [email protected] [skia] Disable legacy non-const SkData APIs (flutter/flutter#179684) 2026-01-06 [email protected] Fix/ios share context menu (flutter/flutter#176199) 2026-01-06 [email protected] Roll Skia from b970aeffa66f to f5d9da13d56d (5 revisions) (flutter/flutter#180588) 2026-01-06 [email protected] Manually bump dependencies (flutter/flutter#180509) 2026-01-06 [email protected] Roll Dart SDK from 8150be8a0e48 to 40a8c6188f7f (2 revisions) (flutter/flutter#180582) 2026-01-06 [email protected] Roll Packages from 12eb764 to d3f860d (2 revisions) (flutter/flutter#180581) 2026-01-06 [email protected] Roll Fuchsia Test Scripts from MHF-UAfO6sVKqSEYk... to nR2ESa1Gd8yPcWo06... (flutter/flutter#180578) 2026-01-06 [email protected] Add tooltip support to PlatformMenuItem and PlatformMenu. (flutter/flutter#180069) 2026-01-06 [email protected] Add DropdownMenuFormField.errorBuilder (flutter/flutter#179345) 2026-01-06 [email protected] Roll Skia from 1845397e11ba to b970aeffa66f (2 revisions) (flutter/flutter#180566) 2026-01-06 [email protected] Don't embed unreferenced assets (flutter/flutter#179251) 2026-01-06 [email protected] Improve documentation about ValueNotifier's behavior (flutter/flutter#179870) 2026-01-06 [email protected] Roll Skia from 904ba00331ca to 1845397e11ba (5 revisions) (flutter/flutter#180558) 2026-01-06 [email protected] Roll Dart SDK from 2fb9ad834c4d to 8150be8a0e48 (1 revision) (flutter/flutter#180557) 2026-01-06 [email protected] Roll Skia from 98c042dde68c to 904ba00331ca (3 revisions) (flutter/flutter#180550) 2026-01-06 [email protected] Roll Dart SDK from ba9f7f790966 to 2fb9ad834c4d (2 revisions) (flutter/flutter#180548) 2026-01-06 [email protected] Roll Fuchsia Linux SDK from ubBGcRaAKWKihQ4ac... to QfR2ZFZ5kGTD3raO3... (flutter/flutter#180547) 2026-01-06 [email protected] Make sure that a DraggableScrollableSheet doesn't crash in 0x0 enviro… (flutter/flutter#180433) 2026-01-06 [email protected] Make sure that a ColorFiltered doesn't crash 0x0 environment (flutter/flutter#180307) 2026-01-06 [email protected] Make sure that a FadeInImage doesn't crash in 0x0 environment (flutter/flutter#180495) ...

…r/flutter#180586)

bkonyi requested a review from jyameo January 6, 2026 16:48

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Jan 6, 2026

jyameo approved these changes Jan 6, 2026

View reviewed changes

Merge branch 'master' of https://github.com/flutter/flutter into widg…

a6249fc

…et_preview_ffi_support

gemini-code-assist bot reviewed Jan 6, 2026

View reviewed changes

packages/flutter_tools/lib/src/compile.dart Show resolved Hide resolved

Merge branch 'master' into widget_preview_ffi_support

16fe9bb

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2026

Fix analysis

cfc1e4f

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

auto-submit bot added this pull request to the merge queue Jan 7, 2026

Merged via the queue into flutter:master with commit 15c48f2 Jan 7, 2026
181 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 20fc4107d61f (67 revisions) flutter/packages#10740

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

15c48f2 [ Widget Preview ] Add support for dart:ffi imports (flutte…

f529714

…r/flutter#180586)

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to a73c1002a6fa (68 revisions) flutter/packages#10741

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

15c48f2 [ Widget Preview ] Add support for dart:ffi imports (flutte…

8772b4d

…r/flutter#180586)

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to b2d157623eeb (69 revisions) flutter/packages#10742

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

15c48f2 [ Widget Preview ] Add support for dart:ffi imports (flutte…

8e9ca37

…r/flutter#180586)

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 6acc84ee2ce9 (71 revisions) flutter/packages#10743

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

15c48f2 [ Widget Preview ] Add support for dart:ffi imports (flutte…

11f76bb

…r/flutter#180586)

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 01d37bc80fd5 (74 revisions) flutter/packages#10745

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

15c48f2 [ Widget Preview ] Add support for dart:ffi imports (flutte…

d1dba94

…r/flutter#180586)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

15c48f2 [ Widget Preview ] Add support for dart:ffi imports (flutte…

2583853

…r/flutter#180586)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ Widget Preview ] Add support for `dart:ffi` imports#180586

[ Widget Preview ] Add support for `dart:ffi` imports#180586
auto-submit[bot] merged 4 commits intoflutter:masterfrom
bkonyi:widget_preview_ffi_support

bkonyi commented Jan 6, 2026

Uh oh!

jyameo left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

auto-submit bot commented Jan 6, 2026

Uh oh!

auto-submit bot commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bkonyi commented Jan 6, 2026

Uh oh!

jyameo left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

auto-submit bot commented Jan 6, 2026

Uh oh!

auto-submit bot commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants