[web][triage] Exclude PRs that have been approved/triaged#180644
[web][triage] Exclude PRs that have been approved/triaged#180644auto-submit[bot] merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates a GitHub query in the web triage documentation to exclude already triaged pull requests. My review includes a suggestion to maintain consistency in the query syntax for filtering draft PRs with another query in the same file.
| * The list of [P1 issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Ateam-web+label%3AP1) should be manageable (<30 issues) | ||
| * Number of open PRs should be manageable (<15): | ||
| * [flutter/flutter](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+label%3Aplatform-web+sort%3Acreated-asc+-is%3Adraft) | ||
| * [flutter/flutter](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+label%3Aplatform-web+sort%3Acreated-asc+draft%3Afalse+-label%3Atriaged-web) |
There was a problem hiding this comment.
For consistency with the filter used for flutter/packages on the next line, it would be better to use -is:draft instead of draft:false to filter out draft pull requests. While both are functionally equivalent, using the same syntax improves the document's readability and maintainability.
| * [flutter/flutter](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+label%3Aplatform-web+sort%3Acreated-asc+draft%3Afalse+-label%3Atriaged-web) | |
| * [flutter/flutter](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+label%3Aplatform-web+sort%3Acreated-asc+-is%3Adraft+-label%3Atriaged-web) |
There was a problem hiding this comment.
This change seems good to me
| * The list of [P1 issues](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Ateam-web+label%3AP1) should be manageable (<30 issues) | ||
| * Number of open PRs should be manageable (<15): | ||
| * [flutter/flutter](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+label%3Aplatform-web+sort%3Acreated-asc+-is%3Adraft) | ||
| * [flutter/flutter](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+label%3Aplatform-web+sort%3Acreated-asc+draft%3Afalse+-label%3Atriaged-web) |
There was a problem hiding this comment.
This change seems good to me
No description provided.