De-interleaves engine dart test output by gaaclarke · Pull Request #180651 · flutter/flutter

gaaclarke · 2026-01-07T18:37:38Z

This includes the following changes:

Logging output from dart tests is no longer interleaved
The backend that is running the test is now printed out
TestingContext abstraction was added in order to support more rendering backends in the future

test exempt: it is tests

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gaaclarke · 2026-01-07T23:15:48Z

@walley892 this will make fixing that issue with the fragment shader tests not running on vulkan easier since the output is legible after this.

walley892

Couple of comments on structure

engine/src/flutter/shell/testing/tester_context_vk_factory.cc

walley892

LGTM!

auto-submit · 2026-01-08T02:58:29Z

autosubmit label was removed for flutter/flutter/180651, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

gaaclarke · 2026-01-08T16:27:31Z

Google testing failed because there is a test that misidentifies the message for what backend is being used as an error. Permissions on the code are such that I can't easily remedy it. So I'll remove that. Once the next PR lands this will show up in the invocation anyways.

Roll Flutter from 01d37bc to 73769a2 (65 revisions) flutter/flutter@01d37bc...73769a2 2026-01-10 [email protected] Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800) 2026-01-10 [email protected] Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796) 2026-01-10 [email protected] Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794) 2026-01-10 [email protected] Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824) 2026-01-10 [email protected] Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783) 2026-01-10 [email protected] Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350) 2026-01-10 [email protected] Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478) 2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785) 2026-01-09 [email protected] Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600) 2026-01-09 [email protected] fix: there are no riscv fuchsia artifacts (flutter/flutter#180779) 2026-01-09 [email protected] Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771) 2026-01-09 [email protected] Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022) 2026-01-09 [email protected] Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759) 2026-01-09 [email protected] Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765) 2026-01-09 [email protected] [A11y ] Add `clearSemantics`in table (flutter/flutter#180665) 2026-01-09 [email protected] Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703) 2026-01-09 [email protected] [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711) 2026-01-09 [email protected] Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754) 2026-01-09 [email protected] Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741) 2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761) 2026-01-09 [email protected] Fix typo in dropdown_menu.dart (flutter/flutter#180172) 2026-01-09 [email protected] Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742) 2026-01-09 [email protected] Unpin google_mobile_ads (flutter/flutter#180573) 2026-01-09 [email protected] Update flutter changelog for 3.38.6 (flutter/flutter#180708) 2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709) 2026-01-08 [email protected] Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457) 2026-01-08 [email protected] Implementation of tooltip windows for win32 (flutter/flutter#179147) 2026-01-08 [email protected] [web] Don't serve files outside of project (flutter/flutter#180699) 2026-01-08 [email protected] Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702) 2026-01-08 [email protected] Add new motion accessibility features to iOS. (flutter/flutter#178102) 2026-01-08 [email protected] Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355) 2026-01-08 [email protected] [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658) 2026-01-08 [email protected] De-interleaves engine dart test output (flutter/flutter#180651) 2026-01-08 [email protected] [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958) 2026-01-08 [email protected] Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693) 2026-01-08 [email protected] Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685) 2026-01-08 [email protected] Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583) 2026-01-08 [email protected] Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610) 2026-01-08 [email protected] Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688) 2026-01-08 [email protected] [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655) 2026-01-08 [email protected] Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684) 2026-01-08 [email protected] flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888) 2026-01-08 [email protected] Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679) 2026-01-08 [email protected] Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677) 2026-01-08 [email protected] Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675) 2026-01-08 [email protected] Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673) ...

github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 7, 2026

gaaclarke force-pushed the flutter-tester-backends branch from d68de8b to a5fdafb Compare January 7, 2026 21:52

gaaclarke added 8 commits January 7, 2026 14:22

Added impeller backends to flutter_tester

92a4c52

++

6b7a881

brought in context

1f2286e

++

804bdc2

cleaned up creation to one spot

63d29f9

started logging backend and made loggers private

c26c8af

stopped interleaving dart test output

3412a9e

cleanup

091f759

gaaclarke force-pushed the flutter-tester-backends branch from a5fdafb to 091f759 Compare January 7, 2026 22:24

gaaclarke marked this pull request as ready for review January 7, 2026 23:14

gaaclarke requested review from b-luk, bkonyi and walley892 and removed request for bkonyi January 7, 2026 23:14

walley892 reviewed Jan 7, 2026

View reviewed changes

engine/src/flutter/shell/testing/tester_context_vk_factory.cc Show resolved Hide resolved

engine/src/flutter/shell/testing/tester_context_vk_factory.cc Show resolved Hide resolved

engine/src/flutter/shell/testing/tester_context_vk_factory.cc Show resolved Hide resolved

introduced anonymous namespace

5555ab2

gaaclarke requested a review from walley892 January 7, 2026 23:48

walley892 approved these changes Jan 8, 2026

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2026

Removed extra log statement that was messing up google testing

43d5bbf

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2026

auto-submit bot added this pull request to the merge queue Jan 8, 2026

Merged via the queue into flutter:master with commit 5b5bf6c Jan 8, 2026
181 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2026

engine-flutter-autoroll mentioned this pull request Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to 96403e0fa570 (41 revisions) flutter/packages#10756

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

7baca92

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

0fbf9b9

This was referenced Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to c1e1dc260fb7 (43 revisions) flutter/packages#10757

Closed

Roll Flutter from 01d37bc80fd5 to fd1fad23f595 (44 revisions) flutter/packages#10759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

4f8b1e7

engine-flutter-autoroll mentioned this pull request Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to 61b241292e19 (45 revisions) flutter/packages#10760

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

9444768

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 0b7596b3f269 (64 revisions) flutter/packages#10768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

b558877

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

bdbd79a

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10770

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

fe70a4f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

5b5bf6c De-interleaves engine dart test output (flutter/flutter#180651)

75c34ce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

De-interleaves engine dart test output#180651

De-interleaves engine dart test output#180651
auto-submit[bot] merged 10 commits intoflutter:masterfrom
gaaclarke:flutter-tester-backends

gaaclarke commented Jan 7, 2026

Uh oh!

gaaclarke commented Jan 7, 2026

Uh oh!

walley892 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

walley892 left a comment

Uh oh!

auto-submit bot commented Jan 8, 2026

Uh oh!

gaaclarke commented Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gaaclarke commented Jan 7, 2026

Pre-launch Checklist

Uh oh!

gaaclarke commented Jan 7, 2026

Uh oh!

walley892 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

walley892 left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 8, 2026

Uh oh!

gaaclarke commented Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

walley892 left a comment •

edited

Loading