[ Tool ] Fix flake in overall_experience_test.dart by bkonyi · Pull Request #180655 · flutter/flutter

bkonyi · 2026-01-07T20:39:11Z

The diagnostics string builder responsible for building diagnostics messages can sometimes wrap lines that are too long. This caused the expectation for the 'flutter error messages include a DevTools links' to sometimes be incorrect when run on systems where the absolute file path of the file referenced in the diagnostic was too long.

This change updates the test expectation to allow for both wrapping and non-wrapping scenarios to be accepted.

Fixes #174502

The diagnostics string builder responsible for building diagnostics messages can sometimes wrap lines that are too long. This caused the expectation for the 'flutter error messages include a DevTools links' to sometimes be incorrect when run on systems where the absolute file path of the file referenced in the diagnostic was too long. This change updates the test expectation to allow for both wrapping and non-wrapping scenarios to be accepted. Fixes flutter#174502

gemini-code-assist

Code Review

This pull request addresses a flaky test by updating the test expectation to handle both wrapped and non-wrapped line scenarios in diagnostic messages. The approach is solid. I've provided a couple of suggestions to enhance the readability and clarity of the test code.

packages/flutter_tools/test/integration.shard/overall_experience_test.dart

Piinks

LGTM! Thanks for this! :)

bkonyi · 2026-01-08T15:47:34Z

LGTM! Thanks for this! :)

No problem! Finally had some time to do some digging into some of these flakes :)

…lutter#180655)

Roll Flutter from 01d37bc to 73769a2 (65 revisions) flutter/flutter@01d37bc...73769a2 2026-01-10 [email protected] Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800) 2026-01-10 [email protected] Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796) 2026-01-10 [email protected] Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794) 2026-01-10 [email protected] Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824) 2026-01-10 [email protected] Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783) 2026-01-10 [email protected] Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350) 2026-01-10 [email protected] Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478) 2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785) 2026-01-09 [email protected] Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600) 2026-01-09 [email protected] fix: there are no riscv fuchsia artifacts (flutter/flutter#180779) 2026-01-09 [email protected] Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771) 2026-01-09 [email protected] Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022) 2026-01-09 [email protected] Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759) 2026-01-09 [email protected] Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765) 2026-01-09 [email protected] [A11y ] Add `clearSemantics`in table (flutter/flutter#180665) 2026-01-09 [email protected] Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703) 2026-01-09 [email protected] [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711) 2026-01-09 [email protected] Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754) 2026-01-09 [email protected] Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741) 2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761) 2026-01-09 [email protected] Fix typo in dropdown_menu.dart (flutter/flutter#180172) 2026-01-09 [email protected] Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742) 2026-01-09 [email protected] Unpin google_mobile_ads (flutter/flutter#180573) 2026-01-09 [email protected] Update flutter changelog for 3.38.6 (flutter/flutter#180708) 2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709) 2026-01-08 [email protected] Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457) 2026-01-08 [email protected] Implementation of tooltip windows for win32 (flutter/flutter#179147) 2026-01-08 [email protected] [web] Don't serve files outside of project (flutter/flutter#180699) 2026-01-08 [email protected] Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702) 2026-01-08 [email protected] Add new motion accessibility features to iOS. (flutter/flutter#178102) 2026-01-08 [email protected] Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355) 2026-01-08 [email protected] [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658) 2026-01-08 [email protected] De-interleaves engine dart test output (flutter/flutter#180651) 2026-01-08 [email protected] [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958) 2026-01-08 [email protected] Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693) 2026-01-08 [email protected] Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685) 2026-01-08 [email protected] Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583) 2026-01-08 [email protected] Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610) 2026-01-08 [email protected] Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688) 2026-01-08 [email protected] [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655) 2026-01-08 [email protected] Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684) 2026-01-08 [email protected] flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888) 2026-01-08 [email protected] Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679) 2026-01-08 [email protected] Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677) 2026-01-08 [email protected] Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675) 2026-01-08 [email protected] Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673) ...

…lutter#180655)

bkonyi requested a review from Piinks January 7, 2026 20:39

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 7, 2026

gemini-code-assist bot reviewed Jan 7, 2026

View reviewed changes

packages/flutter_tools/test/integration.shard/overall_experience_test.dart Show resolved Hide resolved

packages/flutter_tools/test/integration.shard/overall_experience_test.dart Show resolved Hide resolved

Piinks approved these changes Jan 7, 2026

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2026

auto-submit bot added this pull request to the merge queue Jan 8, 2026

Merged via the queue into flutter:master with commit 8812db3 Jan 8, 2026
141 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2026

engine-flutter-autoroll mentioned this pull request Jan 8, 2026

Roll Flutter from 01d37bc80fd5 to 8812db359497 (26 revisions) flutter/packages#10750

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

e0fa1d1

…lutter#180655)

engine-flutter-autoroll mentioned this pull request Jan 8, 2026

Roll Flutter from 01d37bc80fd5 to 40644514f94b (27 revisions) flutter/packages#10751

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

7b40876

…lutter#180655)

engine-flutter-autoroll mentioned this pull request Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to 96403e0fa570 (41 revisions) flutter/packages#10756

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

939956d

…lutter#180655)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

af1a888

…lutter#180655)

This was referenced Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to c1e1dc260fb7 (43 revisions) flutter/packages#10757

Closed

Roll Flutter from 01d37bc80fd5 to fd1fad23f595 (44 revisions) flutter/packages#10759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

4b1d894

…lutter#180655)

engine-flutter-autoroll mentioned this pull request Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to 61b241292e19 (45 revisions) flutter/packages#10760

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

5c04955

…lutter#180655)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 0b7596b3f269 (64 revisions) flutter/packages#10768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

4d9c82b

…lutter#180655)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

0b00595

…lutter#180655)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

fb4079b

…lutter#180655)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10770

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

8812db3 [ Tool ] Fix flake in overall_experience_test.dart (flutter/f…

c6a11e5

…lutter#180655)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ Tool ] Fix flake in overall_experience_test.dart#180655

[ Tool ] Fix flake in overall_experience_test.dart#180655
auto-submit[bot] merged 1 commit intoflutter:masterfrom
bkonyi:flaky_diagnostic_line_wrapping

bkonyi commented Jan 7, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Uh oh!

bkonyi commented Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bkonyi commented Jan 7, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

bkonyi commented Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants