Conversation
codefu wins the shamecube award for bad python. Tested on windows 11 enterprise + vc 2022: ```shell Searching for installed Visual Studio versions: 2019, 2017, 2022, 2026, 16.0, 15.0, 17.0, 18 vs_path = "C:\\Program Files/Microsoft Visual Studio/2022/Community" sdk_path = "C:\\Program Files (x86)\\Windows Kits\\10" vs_version = "2022" wdk_dir = "" runtime_dirs = "C:\\Windows\\System32;C:\\Windows\\SysWOW64;Arm64Unused" ``` fixes flutter#180660
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in GetVisualStudioVersion where the list of Visual Studio versions to search was being overwritten in a loop, causing only the last version to be checked. The change ensures all supported versions are considered. My review includes a suggestion to simplify the code for constructing this search list, making it more concise and Pythonic.
|
Thanks! |
jtmcdole
added
the
autosubmit
|
Yeah, really sorry about that. |
flutter-dashboard
bot
removed
the
autosubmit
3 participants
codefu wins the shamecube award for bad python.
Tested on windows 11 enterprise + vc 2022:
fixes #180660