Hi @gktirkha - thank you for opening a PR! To make this easier to review, could you file an issue in the Flutter repo that describes this issue (along with steps on how to reproduce) and link to it in this PR. Thank you!

Hi @gktirkha - thank you for opening a PR! To make this easier to review, could you file an issue in the Flutter repo that describes this issue (along with steps on how to reproduce) and link to it in this PR. Thank you!

Sure @justinmc , Here it is

#180956

Hi @elliette, just checking in to see if there are any updates on this PR. Thanks for taking a look!

Hi @elliette, just checking in to see if there are any updates on this PR. Thanks for taking a look!

Hi! Do you mind looking into the test failures to see if they are related to this PR? It looks the failing tests are the widget tests. Merging in the main branch might further help determine whether the test failures are due to this PR or not. Thanks!

 Command: ../../bin/flutter test --reporter=expanded --file-reporter=json:/b/s/w/ir/x/t/metrics_1769943602511512.json --test-randomize-ordering-seed=20260201 --fatal-warnings --track-widget-creation test/widgets/
║ Command exited with exit code 1 but expected zero exit code.
║ Working directory: /b/s/w/ir/x/w/flutter/packages/flutter

Hi @elliette, just checking in to see if there are any updates on this PR. Thanks for taking a look!

Hi! Do you mind looking into the test failures to see if they are related to this PR? It looks the failing tests are the widget tests. Merging in the main branch might further help determine whether the test failures are due to this PR or not. Thanks!

 Command: ../../bin/flutter test --reporter=expanded --file-reporter=json:/b/s/w/ir/x/t/metrics_1769943602511512.json --test-randomize-ordering-seed=20260201 --fatal-warnings --track-widget-creation test/widgets/
║ Command exited with exit code 1 but expected zero exit code.
║ Working directory: /b/s/w/ir/x/w/flutter/packages/flutter

I Don't think that it is related

bin/flutter test --reporter=expanded --file-reporter=json:/b/s/w/ir/x/t/metrics_1769943602511512.json --test-randomize-ordering-seed=20260201 --fatal-warnings --track-widget-creation test/widgets/
Resolving dependencies...
The current Flutter SDK version is 0.0.0-unknown.

Because _flutter_packages depends on webview_flutter_wkwebview 3.23.5 which requires Flutter SDK version >=3.35.0, version solving failed.
Failed to update packages.

but if I do use flutter from main branch (system flutter)

Resolving dependencies...
Downloading packages...
  _fe_analyzer_shared 92.0.0 (94.0.0 available)
  adaptive_breakpoints 0.1.7 (discontinued)
  analyzer 9.0.0 (10.0.2 available)
  archive 3.6.1 (4.0.7 available)
  dart_style 3.1.3 (3.1.5 available)
  device_info 2.0.3 (discontinued replaced by device_info_plus)
  gcloud 0.8.19 (0.9.0 available)
  google_fonts 6.3.3 (8.0.1 available)
  google_mobile_ads 5.1.0 (7.0.0 available)
  googleapis 14.0.0 (16.0.0 available)
  hooks 1.0.0 (1.0.1 available)
  isolate 2.1.1 (discontinued)
  js 0.7.2 (discontinued)
  json_annotation 4.9.0 (4.10.0 available)
  lints 6.0.0 (6.1.0 available)
  meta 1.18.0 (1.18.1 available)
  objective_c 9.2.3 (9.3.0 available)
  pedantic 1.11.1 (discontinued replaced by lints)
  source_span 1.10.1 (1.10.2 available)
  url_launcher_ios 6.3.6 (6.4.0 available)
  video_player_avfoundation 2.8.10 (2.9.1 available)
  webview_flutter 4.9.0 (4.13.1 available)
  webview_flutter_android 3.16.9 (4.10.11 available)
  webview_flutter_wkwebview 3.23.5 (3.23.6 available)
Got dependencies!
5 packages are discontinued.
19 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Shuffling test order with --test-randomize-ordering-seed=20260201
Creation failed, path = '/b' (OS Error: Read-only file system, errno = 30)
dart:io                                                             _File.createSync
package:test_core/src/runner.dart 87:32                             new Runner.<fn>.createFileReporter
package:test_core/src/runner.dart 99:15                             new Runner.<fn>
dart:async                                                          runZoned
package:test_core/src/runner/configuration.dart 865:7               Configuration.asCurrent
package:test_core/src/runner.dart 76:50                             new Runner
package:test_core/src/executable.dart 149:14                        _execute
package:test_core/src/executable.dart 38:9                          main
package:flutter_tools/src/test/test_wrapper.dart 31:16              _DefaultTestWrapper.main
package:flutter_tools/src/test/runner.dart 187:25                   FlutterTestRunner.runTests
package:flutter_tools/src/commands/test.dart 662:33                 TestCommand.runCommand
package:flutter_tools/src/runner/flutter_command.dart 1559:27       FlutterCommand.run.<fn>
package:flutter_tools/src/base/context.dart 154:19                  AppContext.run.<fn>
package:args/command_runner.dart 212:13                             CommandRunner.runCommand
package:flutter_tools/src/runner/flutter_command_runner.dart 487:9  FlutterCommandRunner.runCommand.<fn>
package:flutter_tools/src/base/context.dart 154:19                  AppContext.run.<fn>
package:flutter_tools/src/runner/flutter_command_runner.dart 422:5  FlutterCommandRunner.runCommand
package:flutter_tools/runner.dart 104:11                            run.<fn>.<fn>
package:flutter_tools/src/base/context.dart 154:19                  AppContext.run.<fn>
package:flutter_tools/executable.dart 103:3                         main

This is an unexpected error. Please file an issue at http://github.com/dart-lang/test
with the stack trace and instructions for reproducing the error.

Tree is currently broken. Please do not merge this PR unless it contains a fix for the tree.

Thank you! Looks like the tree is currently broken. Let's wait for that to resolve and then make sure the tests are passing. Sorry for wait!

Here is the failing test log:

04:40 +5305 ~17: /b/s/w/ir/x/w/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Multiple widget inspectors
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following _TypeError was thrown running a test:
Null check operator used on a null value

When the exception was thrown, this was the stack:
#0      _TestWidgetInspectorService.runTests.<anonymous closure> (file:///b/s/w/ir/x/w/flutter/packages/flutter/test/widgets/widget_inspector_test.dart:909:72)
<asynchronous suspension>
#1      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:192:15)
<asynchronous suspension>
#2      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1800:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The test description was:
  Multiple widget inspectors
════════════════════════════════════════════════════════════════════════════════════════════════════
04:40 +5305 ~17 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/widgets/parent_data_test.dart: ParentDataWidget control test
04:40 +5305 ~17 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Multiple widget inspectors [E]
  Test failed. See exception logs above.
  The test description was: Multiple widget inspectors

did this,
_WidgetInspectorButtonGroupState.build — use math.max to preserve minimum bottom margin

// Before
final double bottomPadding = MediaQuery.viewPaddingOf(context).bottom;

// After
final double bottomPadding = math.max(_kExitWidgetSelectionButtonMargin,MediaQuery.viewPaddingOf(context).bottom);

Using viewPadding.bottom alone breaks on devices/environments with no bottom safe area inset (Android, older iPhones, tests) where it returns 0.

hi @elliette

I Believe all widgets tests related to pr have passed, let me know if i can do anything regarding failed test cases

I Believe all widgets tests related to pr have passed, let me know if i can do anything regarding failed test cases

Hi @gktirkha - it looks like the widget_inspector needs to be formatted:

Found 1 Dart file which was formatted incorrectly.
To fix, run `dart format packages/flutter/lib/src/widgets/widget_inspector.dart`

I Believe all widgets tests related to pr have passed, let me know if i can do anything regarding failed test cases

Hi @gktirkha - it looks like the widget_inspector needs to be formatted:

Found 1 Dart file which was formatted incorrectly.
To fix, run `dart format packages/flutter/lib/src/widgets/widget_inspector.dart`

Oops!, forgot that
Fixed it