Fix style_manager_test for Firefox by harryterkelsen · Pull Request #181084 · flutter/flutter

harryterkelsen · 2026-01-16T19:19:10Z

Fixes style_manager_test.dart for Firefox by

changing the CSS to explicitly set outline: rgb(0, 0, 0) none 0px
actually focusing the element before checking it's computed style

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request fixes a test for Firefox by making the CSS outline property more explicit and correcting the test logic to properly focus the element before checking its computed style. Specifically, outline: none; is changed to outline: rgb(0, 0, 0) none 0px;. The test style_manager_test.dart is updated to set tabIndex, call focusWithoutScroll(), and use getComputedStyle on the element directly, and the test is no longer skipped on Firefox.

gemini-code-assist · 2026-01-16T19:20:34Z

engine/src/flutter/lib/web_ui/test/engine/view_embedder/style_manager_test.dart

+      final expected = ui_web.browser.browserEngine == ui_web.BrowserEngine.firefox
+          ? 'rgb(0, 0, 0) 0px'
+          : 'rgb(0, 0, 0) none 0px';


For consistency and readability, you can use the isFirefox boolean that's available from browser_detection.dart (which is imported via engine.dart). The skip parameter in the original test also used it.

Suggested change

final expected = ui_web.browser.browserEngine == ui_web.BrowserEngine.firefox

? 'rgb(0, 0, 0) 0px'

: 'rgb(0, 0, 0) none 0px';

final String expected = isFirefox

? 'rgb(0, 0, 0) 0px'

: 'rgb(0, 0, 0) none 0px';

mdebbar

auto-submit · 2026-01-16T21:37:58Z

autosubmit label was removed for flutter/flutter/181084, because - The status or check suite Linux linux_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

Fixes style_manager_test.dart for Firefox by 1. changing the CSS to explicitly set `outline: rgb(0, 0, 0) none 0px` 2. actually focusing the element before checking it's computed style Fixes flutter#180940 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

flutteractionsbot · 2026-01-20T18:41:56Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

Fixes style_manager_test.dart for Firefox by 1. changing the CSS to explicitly set `outline: rgb(0, 0, 0) none 0px` 2. actually focusing the element before checking it's computed style Fixes flutter#180940 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Fixes style_manager_test.dart for Firefox by 1. changing the CSS to explicitly set `outline: rgb(0, 0, 0) none 0px` 2. actually focusing the element before checking it's computed style Fixes #181203 **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md  *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Fixes style_manager_test.dart for Firefox by 1. changing the CSS to explicitly set `outline: rgb(0, 0, 0) none 0px` 2. actually focusing the element before checking it's computed style Fixes flutter#180940 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

harryterkelsen requested a review from mdebbar January 16, 2026 19:19

github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Jan 16, 2026

gemini-code-assist bot reviewed Jan 16, 2026

View reviewed changes

mdebbar approved these changes Jan 16, 2026

View reviewed changes

harryterkelsen added 2 commits January 16, 2026 12:38

Fix style_manager_test for Firefox

3ee77c8

Use isFirefox

c71888b

harryterkelsen force-pushed the fix-firefox-stylemanagertest-really branch from 110a760 to c71888b Compare January 16, 2026 20:39

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2026

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2026

auto-submit bot added this pull request to the merge queue Jan 17, 2026

Merged via the queue into flutter:master with commit c652e45 Jan 17, 2026
181 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2026

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 7bc5493d88bf (70 revisions) flutter/packages#10823

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

99743c8

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 7bc5493d88bf (70 revisions) flutter/packages#10824

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

1010086

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 2bb464851daf (71 revisions) flutter/packages#10825

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

0ffc4d8

engine-flutter-autoroll mentioned this pull request Jan 18, 2026

Roll Flutter from 48c247582e45 to d20405293d08 (78 revisions) flutter/packages#10826

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

15eb94e

engine-flutter-autoroll mentioned this pull request Jan 18, 2026

Roll Flutter from 48c247582e45 to d20405293d08 (78 revisions) flutter/packages#10827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

61f4d99

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to 8329989d2978 (79 revisions) flutter/packages#10829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

509876e

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to d21322b1b67b (80 revisions) flutter/packages#10830

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

e24ce4f

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to 58260a7f0a51 (82 revisions) flutter/packages#10831

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

947d644

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 841e195e8356 (96 revisions) flutter/packages#10834

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

22d933a

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 4628fdbcde3c (97 revisions) flutter/packages#10835

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

8c1fd78

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 1d70a351c96f (98 revisions) flutter/packages#10837

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

8a31a84

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Roll Flutter from 48c247582e45 to 2d7c3105aa22 (99 revisions) flutter/packages#10838

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

863d2f7

jtmcdole added the cp: beta cherry pick this pull request to beta release candidate branch label Jan 20, 2026

harryterkelsen mentioned this pull request Jan 20, 2026

[CP] Fix for Firefox style test #181203

Closed

engine-flutter-autoroll mentioned this pull request Jan 20, 2026

Manual roll Flutter from 48c247582e45 to 8cbe1be5e6cf (104 revisions) flutter/packages#10840

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

e5f0a79

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

cc12f5b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

830902f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

0c3d7a5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

afa1359

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

cd12aa0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

437bf67

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026

c652e45cd Fix style_manager_test for Firefox (flutter/flutter#181084)

02d5028

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix style_manager_test for Firefox#181084

Fix style_manager_test for Firefox#181084
auto-submit[bot] merged 2 commits intoflutter:masterfrom
harryterkelsen:fix-firefox-stylemanagertest-really

harryterkelsen commented Jan 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 16, 2026

Uh oh!

harryterkelsen Jan 16, 2026

Uh oh!

mdebbar left a comment

Uh oh!

auto-submit bot commented Jan 16, 2026

Uh oh!

Uh oh!

flutteractionsbot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

harryterkelsen commented Jan 16, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 16, 2026

Uh oh!

Uh oh!

flutteractionsbot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants