Add DateInputCalendarDelegate to customize date input#181105
Open
Mairramer wants to merge 8 commits intoflutter:masterfrom
Open
Add DateInputCalendarDelegate to customize date input#181105Mairramer wants to merge 8 commits intoflutter:masterfrom
Mairramer wants to merge 8 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
framework
Mairramer
changed the title
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces DateInputCalendarDelegate, which allows for customizable date input formatting in showDatePicker and showDateRangePicker. The changes include a new example demonstrating its usage, updates to core date picker files to integrate the new delegate, and corresponding tests. The implementation appears solid, providing a flexible extension point for date input.
juampiq6
reviewed
Jan 30, 2026
Mairramer
force-pushed
the
feature/create-date-input-delegate
branch
from
787eb5a to
25522f5
Compare
Mairramer
force-pushed
the
feature/create-date-input-delegate
branch
from
4cba849 to
4583052
Compare
Mairramer
force-pushed
the
feature/create-date-input-delegate
branch
from
4583052 to
c9c9dd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
DateInputGregorianCalendarDelegate, a specialized calendar delegate that extendsGregorianCalendarDelegateto support customizable text input behavior inshowDatePickerandshowDateRangePickerwhen usingDatePickerEntryMode.input.The default behavior of
showDatePickerandshowDateRangePickerremains unchanged. This change improves the extensibility of the date picker’s input mode without affecting the calendar UI or existing APIs.Fixes #83302
Fixes #97134
Fixes #62401
Fixes #181043
Fixes #115151
Partially fixes #150611
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.