Improve code quality in `PlatformViewsController.java` by AbdeMohlbi · Pull Request #181338 · flutter/flutter

AbdeMohlbi · 2026-01-22T18:43:49Z

This change mostly is a cleanup :

fixes typos in method names.
replaces :

    for (int i = 0; i < pendingTransactions.size(); i++) {
      activeTransactions.add(pendingTransactions.get(i));
    }

with :

    activeTransactions.addAll(pendingTransactions);

removes unnecessary cast in:

layoutParams.leftMargin = (int) x;
layoutParams.topMargin = (int) y;

because :

flutter/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java

Line 1273 in bfc9041

    
           public void onDisplayOverlaySurface(int id, int x, int y, int width, int height) {

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request focuses on improving code quality in PlatformViewsController.java and PlatformViewsController2.java by fixing typos, replacing a loop with addAll, and removing unnecessary casts. The changes enhance readability and maintainability, aligning with the repository's style guide emphasizing code readability.

I am having trouble creating individual review comments. Click here to see my feedback.

engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java (1284-1286)

HIGH: Unnecessary casts are removed as width, height, x, and y are already integers, which aligns with the constructor's expected input types. This simplifies the code and improves readability.

    FrameLayout.LayoutParams layoutParams = new FrameLayout.LayoutParams(width, height);
    layoutParams.leftMargin = x;
    layoutParams.topMargin = y;

engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController2.java (552-554)

HIGH: Using activeTransactions.addAll(pendingTransactions) is more concise and efficient than iterating through pendingTransactions and adding each element individually.

    activeTransactions.addAll(pendingTransactions);
    pendingTransactions.clear();

engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java (322)

MEDIUM: "embeded" is misspelled. It should be "embedded".

          // This offset doesn't affect the position of the embedded view by itself since the GL

engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java (714)

MEDIUM: "VirtualDiplay" is misspelled. It should be "VirtualDisplay".

      float density, PlatformViewTouch touch, boolean usingVirtualDisplay) {