Skip to content

fix firefox 3 38#181498

Merged
auto-submit[bot] merged 1 commit intoflutter:flutter-3.38-candidate.0from
reidbaker:fix-firefox-3-38
Jan 26, 2026
Merged

fix firefox 3 38#181498
auto-submit[bot] merged 1 commit intoflutter:flutter-3.38-candidate.0from
reidbaker:fix-firefox-3-38

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Jan 26, 2026 •
edited
Loading

Fixes 181495

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added platform-android Android applications specifically platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically d: examples Sample code and demos platform-web Web applications specifically platform-linux Building on or for Linux specifically a: desktop Running on desktop team-android Owned by Android platform team team-ios Owned by iOS platform team platform-macos labels Jan 26, 2026
@reidbaker reidbaker changed the base branch from master to flutter-3.38-candidate.0 January 26, 2026 16:06
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 26, 2026

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@reidbaker reidbaker requested a review from mdebbar January 26, 2026 16:07
mdebbar
mdebbar approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2026
@reidbaker reidbaker marked this pull request as ready for review January 26, 2026 16:32
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 26, 2026

autosubmit label was removed for flutter/flutter/181498, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2026
@auto-submit auto-submit bot merged commit db373eb into flutter:flutter-3.38-candidate.0 Jan 26, 2026
162 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026
@engine-flutter-autoroll
db373eb85 fix firefox 3 38 (flutter/flutter#181498)
a6d6ddf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App d: examples Sample code and demos engine flutter/engine related. See also e: labels. platform-android Android applications specifically platform-ios iOS applications specifically platform-linux Building on or for Linux specifically platform-macos platform-web Web applications specifically platform-windows Building on or for Windows specifically team-android Owned by Android platform team team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @mdebbar @harryterkelsen