[native assets] Split debug info into .dsym files#181533
[native assets] Split debug info into .dsym files#181533auto-submit[bot] merged 1 commit intomasterfrom
.dsym files#181533Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to split debug information from native code assets into separate .dsym files for macOS and iOS, and to strip the dylibs for non-debug builds. This aligns with standard release build practices to reduce binary size while retaining debuggability via dSYM files. New utility functions dsymutilDylib and stripDylib have been added to handle these operations, along with corresponding integration tests to verify the behavior. The changes are well-documented and logically applied.
packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
Outdated
Show resolved
Hide resolved
| 'dsymutil', | ||
| dylibFile.path, | ||
| '-o', | ||
| dsymPath, |
There was a problem hiding this comment.
See comment: #181533 (comment)
This likely needs to be changed to output to somewhere outside of the framework, and then copied into the BUILT_PRODUCTS_DIR, likely in xcode_backend.dart
|
test/general.shard/xcode_backend_test.dart needs to be updated |
|
Also, the stripping does not change correctly when switching between build modes. If you do
then do
then do
|
Oh nice catch! This is a separate issue (and is already an issue before this PR), let's address it in a separate PR. The root cause is a |
f036f96 to
7db8781
Compare
flutter/flutter@1d9d6a9...9eafba4 2026-02-01 [email protected] Roll Skia from a8ceddc2bca0 to 4ee9eb659ae0 (1 revision) (flutter/flutter#181773) 2026-02-01 [email protected] Roll Skia from a5a535bc21a3 to a8ceddc2bca0 (1 revision) (flutter/flutter#181772) 2026-02-01 [email protected] Roll Dart SDK from cde322c518b9 to 84abc8d58ec8 (1 revision) (flutter/flutter#181767) 2026-02-01 [email protected] Roll Dart SDK from c72b3f527a07 to cde322c518b9 (1 revision) (flutter/flutter#181763) 2026-01-31 [email protected] Roll Dart SDK from 43de79f08887 to c72b3f527a07 (1 revision) (flutter/flutter#181762) 2026-01-31 [email protected] Roll Fuchsia Linux SDK from 27OsrsrKcrr2pOaqY... to nI52U4LJMrBv8G1M9... (flutter/flutter#181760) 2026-01-31 [email protected] Roll Dart SDK from a0aac59705e5 to 43de79f08887 (1 revision) (flutter/flutter#181758) 2026-01-31 [email protected] Roll Skia from b704afbcd8e7 to a5a535bc21a3 (1 revision) (flutter/flutter#181757) 2026-01-31 [email protected] Roll Dart SDK from d6f77f9098e1 to a0aac59705e5 (1 revision) (flutter/flutter#181756) 2026-01-31 [email protected] Roll Skia from 6f9511ce11ba to b704afbcd8e7 (4 revisions) (flutter/flutter#181753) 2026-01-31 [email protected] Roll Dart SDK from 0cf997832948 to d6f77f9098e1 (2 revisions) (flutter/flutter#181749) 2026-01-31 [email protected] Roll Skia from 33c00c0f3b8b to 6f9511ce11ba (1 revision) (flutter/flutter#181744) 2026-01-31 [email protected] Roll Dart SDK from be3ffc51d407 to 0cf997832948 (1 revision) (flutter/flutter#181740) 2026-01-30 [email protected] Roll Skia from b62d43b59dd6 to 33c00c0f3b8b (1 revision) (flutter/flutter#181735) 2026-01-30 [email protected] [Impeller] Fix type conversion warnings seen on Windows when Impeller GL API wrappers log arguments with function types (flutter/flutter#181734) 2026-01-30 [email protected] Update New Android API Docs (flutter/flutter#180604) 2026-01-30 [email protected] Roll Fuchsia Linux SDK from isy1ARvK-3bsvtfc-... to 27OsrsrKcrr2pOaqY... (flutter/flutter#181733) 2026-01-30 [email protected] Fix P3-to-sRGB color conversion to operate in linear light (flutter/flutter#181720) 2026-01-30 [email protected] chore: deflake Linux_mokey flutter_engine_group_performance (flutter/flutter#181624) 2026-01-30 [email protected] Roll Dart SDK from 2703fd9733ce to be3ffc51d407 (1 revision) (flutter/flutter#181729) 2026-01-30 [email protected] Ensure content-sizing resize is run on UI thread (flutter/flutter#181686) 2026-01-30 [email protected] [ Tool ] Cleanup `ResidentCompiler` initialization logic (flutter/flutter#181421) 2026-01-30 [email protected] [native assets] Split debug info into `.dsym` files (flutter/flutter#181533) 2026-01-30 [email protected] Roll Skia from 4745eb2fe837 to b62d43b59dd6 (1 revision) (flutter/flutter#181727) 2026-01-30 [email protected] add ccache support for custom toolchain (flutter/flutter#180737) 2026-01-30 [email protected] update GLFW to latest and use EGL context creation on linux (flutter/flutter#181259) 2026-01-30 [email protected] add stacktrace support when requested for host builds (flutter/flutter#181264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR splits the debug info from code assets into separate dsym files for MacOS and iOS. The splitting only happens if the build mode is not debug. This aligns with whether the debug symbols are separated out for the Flutter framework and the app Framework. Closes: flutter#181377 Testing: Added some tests to the integration test
This PR splits the debug info from code assets into separate dsym files for MacOS and iOS. The splitting only happens if the build mode is not debug. This aligns with whether the debug symbols are separated out for the Flutter framework and the app Framework. Closes: flutter#181377 Testing: Added some tests to the integration test
|
Still happening on Flutter 3.41.1. Saw the issue above was merged, when can it be expected to be included in an update? Is there a workaround until then? thanks for all your relentless efforts! |
This PR splits the debug info from code assets into separate dsym files for MacOS and iOS. The splitting only happens if the build mode is not debug. This aligns with whether the debug symbols are separated out for the Flutter framework and the app Framework. Closes: flutter#181377 Testing: Added some tests to the integration test
https://github.com/flutter/flutter/blob/master/docs/releases/Flutter-build-release-channels.md explains how fixes reach |


This PR splits the debug info from code assets into separate dsym files for MacOS and iOS.
The splitting only happens if the build mode is not debug. This aligns with whether the debug symbols are separated out for the Flutter framework and the app Framework.
Closes: #181377
Testing: Added some tests to the integration test