Skip to content

[flutter_tools] Support flavors and transformers for shaders#181889

Merged
auto-submit[bot] merged 6 commits intoflutter:masterfrom
Laurie-Lin:pr/shader-transformers
Mar 13, 2026
Merged

[flutter_tools] Support flavors and transformers for shaders#181889
auto-submit[bot] merged 6 commits intoflutter:masterfrom
Laurie-Lin:pr/shader-transformers

Conversation

@Laurie-Lin
Copy link
Contributor

@Laurie-Lin Laurie-Lin commented Feb 4, 2026

This PR adds support for transformers on entries under flutter: shaders: in pubspec.yaml, bringing it closer to the existing assets entry model.

When a shader entry declares transformers, Flutter tools will run the transformer chain prior to shader compilation (Impeller/impellerc). This is wired through the build/bundle paths as well as DevFS shader recompilation during hot reload, so transformed sources are consistently used.

Fixes #181888

Testing

cd $FLUTTER_ROOT/packages/flutter_tools
../../bin/flutter test test/general.shard/flutter_manifest_test.dart test/general.shard/build_system/targets/assets_test.dart -r expanded

Pre-launch Checklist

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for transformers to shader entries in pubspec.yaml, aligning them with the existing asset entry model. The changes correctly wire this through the build/bundle paths and DevFS for hot reload. The implementation is solid and well-tested. My main feedback is to address some code duplication in the shader transformation logic to improve maintainability.

@bkonyi bkonyi requested review from bkonyi and chingjun February 9, 2026 15:51
@bkonyi
Copy link
Contributor

bkonyi commented Feb 9, 2026

Thanks for your contribution, @Laurie-Lin!

This LGTM overall (although there are some analysis failures that need to be resolved), but we'll need a second set of eyes on this before it can be approved.

Copy link
Contributor

@chingjun chingjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM other than stricter input check needed.

Also, can we add tests for the changes in bundle_builder.dart and devfs.dart? Thanks!

@Laurie-Lin Laurie-Lin changed the title flutter_tools: support transformers for flutter.shaders [flutter_tools] Support flavors and transformers for shaders Feb 11, 2026
@bkonyi
Copy link
Contributor

bkonyi commented Feb 24, 2026

Thanks for adding flavors and platform support here!

There's some analysis failures that need to be resolved, but this looks good to me once they're resolved:

   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/build_system/targets/assets.dart:157:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/build_system/targets/assets.dart:160:23 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/bundle_builder.dart:208:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/bundle_builder.dart:210:23 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:244:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:300:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:360:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:511:13 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:546:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:583:26 • omit_obvious_local_variable_types
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:597:59 • unnecessary_null_checks
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:601:41 • unnecessary_null_checks
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:602:46 • unnecessary_null_checks

@Laurie-Lin
Copy link
Contributor Author

Thanks for adding flavors and platform support here!

There's some analysis failures that need to be resolved, but this looks good to me once they're resolved:

   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/build_system/targets/assets.dart:157:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/build_system/targets/assets.dart:160:23 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/bundle_builder.dart:208:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/bundle_builder.dart:210:23 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:244:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:300:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:360:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:511:13 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:546:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:583:26 • omit_obvious_local_variable_types
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:597:59 • unnecessary_null_checks
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:601:41 • unnecessary_null_checks
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:602:46 • unnecessary_null_checks

OK, I'm starting to work on fixing these warnings.

@Laurie-Lin
Copy link
Contributor Author

Laurie-Lin commented Mar 10, 2026

Thanks for adding flavors and platform support here!

There's some analysis failures that need to be resolved, but this looks good to me once they're resolved:

   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/build_system/targets/assets.dart:157:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/build_system/targets/assets.dart:160:23 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/bundle_builder.dart:208:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/lib/src/bundle_builder.dart:210:23 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:244:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:300:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:360:17 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:511:13 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:546:15 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:583:26 • omit_obvious_local_variable_types
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:597:59 • unnecessary_null_checks
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:601:41 • unnecessary_null_checks
   info • Unnecessary use of a null check ('!') • packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart:602:46 • unnecessary_null_checks

Done, I fixed the analysis issues and reran targeted analysis on the affected files.

# dart analyze \
  packages/flutter_tools/lib/src/build_system/targets/assets.dart \
  packages/flutter_tools/lib/src/bundle_builder.dart \
  packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart
Analyzing assets.dart, bundle_builder.dart, assets_test.dart... 0.5s
No issues found!

@bkonyi

@bkonyi bkonyi added the CICD Run CI/CD label Mar 12, 2026
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just need signoff from @chingjun before we can submit this.

Copy link
Contributor

@chingjun chingjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the support for flavors and platforms!

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Mar 13, 2026
Merged via the queue into flutter:master with commit cc7d8fb Mar 13, 2026
148 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 18, 2026
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 [email protected] Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 [email protected] [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 [email protected] Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 [email protected] Update goldctl version (flutter/flutter#183538)
2026-03-17 [email protected] Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 [email protected] Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 [email protected] Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 [email protected] Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 [email protected] Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 [email protected] Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 [email protected] Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 [email protected] Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 [email protected] Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 [email protected] Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 [email protected] Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 [email protected] Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 [email protected] Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 [email protected] docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 [email protected] Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 [email protected] Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 [email protected] Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 [email protected] Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 [email protected] Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 [email protected] [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 [email protected] Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 [email protected] Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 [email protected] Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 [email protected] Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 [email protected] Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 [email protected] Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 [email protected] Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 [email protected] Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 [email protected] Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 [email protected] Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 [email protected] Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 [email protected] Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 [email protected] Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 [email protected] Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 [email protected] Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 [email protected] Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 [email protected] Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 [email protected] [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 [email protected] Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 [email protected] Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 [email protected] Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 [email protected] [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support transformers for flutter.shaders entries in pubspec.yaml

3 participants