Skip to content

Handle#6537 first grouped tests#182077

Merged
auto-submit[bot] merged 11 commits intoflutter:masterfrom
ahmedsameha1:handle#6537-first-grouped-tests
Feb 19, 2026
Merged

Handle#6537 first grouped tests#182077
auto-submit[bot] merged 11 commits intoflutter:masterfrom
ahmedsameha1:handle#6537-first-grouped-tests

Conversation

@ahmedsameha1
Copy link
Contributor

This is my attempt to handle #6537 for the following widgets:
AnimatedOpacity
AnimatedDefaultTextStyle
AnimatedPhysicalModel
AnimatedFractionallySizedBox
InteractiveViewer
LayoutBuilder
ListWheelScrollView
ListWheelViewport
Localizations
RawMagnifier
ModalBarrier

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository labels Feb 9, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a suite of tests to ensure various widgets do not crash when rendered with a zero area. This is a valuable addition for improving widget robustness. The tests cover RawMagnifier, AnimatedOpacity, AnimatedDefaultTextStyle, AnimatedPhysicalModel, AnimatedFractionallySizedBox, InteractiveViewer, LayoutBuilder, ListWheelScrollView, ListWheelViewport, Localizations, and ModalBarrier.

My review found a minor issue in packages/flutter/test/widgets/implicit_animations_test.dart where several new tests use const incorrectly, which would cause compilation errors. I've provided a suggestion to fix this.

Comment on lines +2042 to +2043
// This is a regression test for https://github.com/flutter/flutter/issues/140780.
// Tweaked to handle https://github.com/flutter/flutter/issues/6537
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
// This is a regression test for https://github.com/flutter/flutter/issues/140780.
// Tweaked to handle https://github.com/flutter/flutter/issues/6537
// This is a regression test for https://github.com/flutter/flutter/issues/140780
// and https://github.com/flutter/flutter/issues/6537.

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for Victor's comment.

@ahmedsameha1 ahmedsameha1 force-pushed the handle#6537-first-grouped-tests branch from d01a61a to 1e0c1a9 Compare February 14, 2026 04:20
@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Feb 19, 2026
Merged via the queue into flutter:master with commit 76f70d2 Feb 19, 2026
73 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2026
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
This is my attempt to handle
flutter#6537 for the following
widgets:
AnimatedOpacity
AnimatedDefaultTextStyle
AnimatedPhysicalModel
AnimatedFractionallySizedBox
InteractiveViewer
LayoutBuilder
ListWheelScrollView
ListWheelViewport
Localizations
RawMagnifier
ModalBarrier

---------

Co-authored-by: Tong Mu <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 20, 2026
…11088)

Manual roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions)

Manual roll requested by [email protected]

flutter/flutter@c023e5b...91b2d41

2026-02-19 [email protected] Reland #179643, only scroll hit-testable primary scroll views on status bar tap (flutter/flutter#182391)
2026-02-19 [email protected] Replace References to `flutter/engine` with `flutter/flutter` (flutter/flutter#182600)
2026-02-19 [email protected] Remove specific iOS extended attributes to fix code signing (flutter/flutter#180710)
2026-02-19 [email protected] Manual roll Skia from 7bbdc51ab0aa to ce5854495a3a (flutter/flutter#182637)
2026-02-19 [email protected] [pv]add integration test for original untappable web view link behind context menu bug (flutter/flutter#182111)
2026-02-19 [email protected] Roll pub packages (flutter/flutter#182579)
2026-02-19 [email protected] Remove Material import from scroll_view_test.dart (flutter/flutter#181281)
2026-02-19 [email protected] Add RawTooltip.ignorePointer (flutter/flutter#182527)
2026-02-19 [email protected] [web] Stop double loading fonts for WebParagraph (flutter/flutter#182026)
2026-02-19 [email protected] Migrate abi build paths to use new abi filtering api #AGP9 (flutter/flutter#181828)
2026-02-19 [email protected] [web] Flutter errors should be reported with console.error() (flutter/flutter#178886)
2026-02-19 [email protected] Manual roll Skia from dfe78d132e24 to 7bbdc51ab0aa (8 revisions) (flutter/flutter#182612)
2026-02-19 [email protected] Refactor autofill_group_test.dart to remove Material dependencies (flutter/flutter#181903)
2026-02-19 [email protected] Roll Packages from 59f905c to 9da22bf (8 revisions) (flutter/flutter#182611)
2026-02-19 [email protected] Roll Fuchsia Linux SDK from Ihau0pUz3u5ajw42u... to KfPgw04T0OEADLJA5... (flutter/flutter#182607)
2026-02-19 [email protected] Marks Mac_arm64_mokey entrypoint_dart_registrant unflaky (flutter/flutter#181648)
2026-02-19 [email protected] Remove material from Modal barrier tests (flutter/flutter#181708)
2026-02-19 [email protected] Remove material from ticker mode test (flutter/flutter#181696)
2026-02-19 [email protected] Remove material imports from Inherited Model, Magnifier, SafeArea, UndoHistory, Navigator and Layers test (flutter/flutter#181709)
2026-02-19 [email protected] docs: fix grammar in animation library documentation (flutter/flutter#182461)
2026-02-19 [email protected] Handle#6537 first grouped tests (flutter/flutter#182077)
2026-02-19 [email protected] Move SelectionArea web test from widgets to material folder (flutter/flutter#181951)
2026-02-19 [email protected] Roll Dart SDK from 44895e617182 to 2642761fca94 (6 revisions) (flutter/flutter#182572)
2026-02-19 [email protected] Update create template to always generate both SwiftPM and CocoaPods support for iOS/macOS plugins (flutter/flutter#181251)
2026-02-18 [email protected] Fix(Material): DateRangePicker ignores DatePickerTheme.dayShape (flutter/flutter#181658)
2026-02-18 [email protected] Fixing ExpansionTile expandedAlignment not Accepts AlignmentGeometry … (flutter/flutter#180814)
2026-02-18 [email protected] Give guided error message when CocoaPod and SwiftPM dependency conflicts (flutter/flutter#182392)
2026-02-18 [email protected] Remove material from interactive_viewer_test.dart (flutter/flutter#181465)
2026-02-18 [email protected] Bring Windows misc coverage out of bringup (flutter/flutter#182332)
2026-02-18 [email protected] Update android symbolication instructions (flutter/flutter#181267)
2026-02-18 [email protected] Unmark stable vulkan platform view tests as bringup (flutter/flutter#182554)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
ahmedsameha1 added a commit to ahmedsameha1/flutter that referenced this pull request Feb 27, 2026
This is my attempt to handle
flutter#6537 for the following
widgets:
AnimatedOpacity
AnimatedDefaultTextStyle
AnimatedPhysicalModel
AnimatedFractionallySizedBox
InteractiveViewer
LayoutBuilder
ListWheelScrollView
ListWheelViewport
Localizations
RawMagnifier
ModalBarrier

---------

Co-authored-by: Tong Mu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: animation Animation APIs f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants