[CP-stable] Pub dependencies & widget_preview_scaffold tests relocation#182317
[CP-stable] Pub dependencies & widget_preview_scaffold tests relocation#182317auto-submit[bot] merged 5 commits intoflutter:flutter-3.41-candidate.0from
Conversation
Manually updating test dependencies because the pub autoroller seems busted, flutter#180503. This one required manually updating the pubspec files because `flutter update-packages --force-upgrade` also seemed unable to deal with the fact that multiple dependencies across packages had to be updated in sync. There's probably also something broken with the `flutter update-packages` command. This is something that used to work.
…tion_tests/widget_preview_scaffold` (flutter#180658) Removes Flutter code from the flutter_tools test suite, which otherwise only contains non-Flutter code. Fixes flutter#180080
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
a: tests
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cherry-picks two changes into the stable branch. The first change relocates the widget_preview_scaffold tests and related files from packages/flutter_tools/test/widget_preview_scaffold.shard to dev/integration_tests/widget_preview_scaffold. This involves updating numerous file paths in test configurations, build scripts, and source files to reflect the new location. The second change updates several pub dependencies, including test, test_api, and test_core, across various pubspec.yaml files. Notably, the ffigen package is moved from dependencies to dev_dependencies in the root pubspec.yaml. The changes are primarily for code organization and dependency management.
Piinks
changed the title
Added release notes for Flutter version 3.41.1.
|
@Piinks can you take a look at the changelog and make sure it looks good? |
LGTM |
camsim99
added
the
autosubmit
auto-submit
bot
merged commit 8373cae
into
flutter:flutter-3.41-candidate.0
5 participants
Fixes #182314
This cherry picks in 2 changes to stable
dev/integration_tests/widget_preview_scaffold#180658This is a manual cherry pick, following https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md
Around about when we created the release, the pub roller was busted. It is fixed now (#180503).
Impacted Users: significant
Impact Description: users cannot upgrade to the latest version
Workaround: None
Risk: Not sure, but the pub roll this is cherry picking landed very very close to the stable release being cut. Analysis and flutter doctor all pass.
Test Coverage: For the widget scaffold change, tests are just relocated
Validation steps: dart-lang/test#2570 (comment)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.