[CP-stable]In flutter_test_performance, consider the blank line at the start of "flutter test" output to be optional.#182335
Conversation
…"flutter test" output to be optional. (flutter#180911) flutter_test_performance runs a "flutter test" command and parses its output. The parser expects the output to begin with a blank line. That line is no longer present after the roll to version 1.29 of the Dart test package (see flutter#180886) Fixes flutter#180903
|
@camsim99 please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the flutter_test_performance devicelab test to handle variations in flutter test output. The change makes an initial blank line in the output optional by adjusting the state machine that parses the test output. This ensures the test works correctly with different versions of the Dart test package, some of which no longer produce this blank line. The corresponding code comment has also been updated for clarity. The change is correct and improves the test's robustness.
camsim99
added
the
autosubmit
auto-submit
bot
merged commit 582a0e7
into
flutter:flutter-3.41-candidate.0
…line at the start of "flutter test" output to be optional. (flutter/flutter#182335)
…line at the start of "flutter test" output to be optional. (flutter/flutter#182335)
…line at the start of "flutter test" output to be optional. (flutter/flutter#182335)
…line at the start of "flutter test" output to be optional. (flutter/flutter#182335)
…line at the start of "flutter test" output to be optional. (flutter/flutter#182335)
…line at the start of "flutter test" output to be optional. (flutter/flutter#182335)
5 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#180903. This is blocking a stable hotfix right now. See https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_mokey%20flutter_test_performance/8971/overview.
Impact Description:
Maybe impacts some people parsing test output besides us.
Changelog Description:
Version 1.29 of the Dart test package adds a blank line to test output causing unexpected test failures.
Workaround:
No need for a workaround/
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
< Replace with validation steps here >