Add RawTooltip.ignorePointer#182527
Conversation
github-actions
bot
added
framework
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly moves the ignorePointer logic from Tooltip to RawTooltip to fix a bug where the property was not being respected. The changes are well-implemented and include corresponding tests. I found a minor documentation inconsistency that should be addressed.
|
|
||
| /// Whether this tooltip should be invisible to hit testing. | ||
| /// | ||
| /// Defaults to true. |
There was a problem hiding this comment.
The documentation states that ignorePointer defaults to true, but the constructor at line 255 sets the default value to false. Please update the documentation to match the implementation for consistency.
/// Defaults to false.
navaronbracke
left a comment
navaronbracke
left a comment
There was a problem hiding this comment.
Overall LGTM, but I have some questions for the tests.
| await gesture.moveTo(tester.getCenter(targetFinder)); | ||
| await tester.pump(); | ||
|
|
||
| // Wait for the tooltip to actually appear. |
There was a problem hiding this comment.
What is the difference between this test and the one named "Tooltip should disappear even if mouse is hovering over the tooltip overlay" ? Should this test not assert that the tooltip is never displayed at all, when hovered over the child?
There was a problem hiding this comment.
What is the difference between this test and the one named "Tooltip should disappear even if mouse is hovering over the tooltip overlay"
It's the same test, but for RawTooltip instead of Tooltip. The difference is Tooltip has ignorePointer set to true (in most cases) by default, while RawTooltip has it default to false. But this is really the behavior we are guarding - the tooltip overlay child should ignore mouse pointers if ignorePointer is set to true (and so be dismissed even when hovered, as any other surface that is not the child).
Should this test not assert that the tooltip is never displayed at all, when hovered over the child?
Not really, this is not the intention of ignorePointer. ignorePointer exists to allow the developer to ignore pointers over the overlay child, not the child. If ignoring pointers over the child is desired, the child itself can be wrapped in an IgnorePointer by the developer.
Maybe the documentation doesn't explain this well enough? Is this something we can change?
There was a problem hiding this comment.
I didn't take a look at the widget documentation for this to be honest. We can do the doc change in a follow-up if you prefer.
victorsanni
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
…11088) Manual roll Flutter from c023e5b2474f to 91b2d41a66d1 (31 revisions) Manual roll requested by [email protected] flutter/flutter@c023e5b...91b2d41 2026-02-19 [email protected] Reland #179643, only scroll hit-testable primary scroll views on status bar tap (flutter/flutter#182391) 2026-02-19 [email protected] Replace References to `flutter/engine` with `flutter/flutter` (flutter/flutter#182600) 2026-02-19 [email protected] Remove specific iOS extended attributes to fix code signing (flutter/flutter#180710) 2026-02-19 [email protected] Manual roll Skia from 7bbdc51ab0aa to ce5854495a3a (flutter/flutter#182637) 2026-02-19 [email protected] [pv]add integration test for original untappable web view link behind context menu bug (flutter/flutter#182111) 2026-02-19 [email protected] Roll pub packages (flutter/flutter#182579) 2026-02-19 [email protected] Remove Material import from scroll_view_test.dart (flutter/flutter#181281) 2026-02-19 [email protected] Add RawTooltip.ignorePointer (flutter/flutter#182527) 2026-02-19 [email protected] [web] Stop double loading fonts for WebParagraph (flutter/flutter#182026) 2026-02-19 [email protected] Migrate abi build paths to use new abi filtering api #AGP9 (flutter/flutter#181828) 2026-02-19 [email protected] [web] Flutter errors should be reported with console.error() (flutter/flutter#178886) 2026-02-19 [email protected] Manual roll Skia from dfe78d132e24 to 7bbdc51ab0aa (8 revisions) (flutter/flutter#182612) 2026-02-19 [email protected] Refactor autofill_group_test.dart to remove Material dependencies (flutter/flutter#181903) 2026-02-19 [email protected] Roll Packages from 59f905c to 9da22bf (8 revisions) (flutter/flutter#182611) 2026-02-19 [email protected] Roll Fuchsia Linux SDK from Ihau0pUz3u5ajw42u... to KfPgw04T0OEADLJA5... (flutter/flutter#182607) 2026-02-19 [email protected] Marks Mac_arm64_mokey entrypoint_dart_registrant unflaky (flutter/flutter#181648) 2026-02-19 [email protected] Remove material from Modal barrier tests (flutter/flutter#181708) 2026-02-19 [email protected] Remove material from ticker mode test (flutter/flutter#181696) 2026-02-19 [email protected] Remove material imports from Inherited Model, Magnifier, SafeArea, UndoHistory, Navigator and Layers test (flutter/flutter#181709) 2026-02-19 [email protected] docs: fix grammar in animation library documentation (flutter/flutter#182461) 2026-02-19 [email protected] Handle#6537 first grouped tests (flutter/flutter#182077) 2026-02-19 [email protected] Move SelectionArea web test from widgets to material folder (flutter/flutter#181951) 2026-02-19 [email protected] Roll Dart SDK from 44895e617182 to 2642761fca94 (6 revisions) (flutter/flutter#182572) 2026-02-19 [email protected] Update create template to always generate both SwiftPM and CocoaPods support for iOS/macOS plugins (flutter/flutter#181251) 2026-02-18 [email protected] Fix(Material): DateRangePicker ignores DatePickerTheme.dayShape (flutter/flutter#181658) 2026-02-18 [email protected] Fixing ExpansionTile expandedAlignment not Accepts AlignmentGeometry … (flutter/flutter#180814) 2026-02-18 [email protected] Give guided error message when CocoaPod and SwiftPM dependency conflicts (flutter/flutter#182392) 2026-02-18 [email protected] Remove material from interactive_viewer_test.dart (flutter/flutter#181465) 2026-02-18 [email protected] Bring Windows misc coverage out of bringup (flutter/flutter#182332) 2026-02-18 [email protected] Update android symbolication instructions (flutter/flutter#181267) 2026-02-18 [email protected] Unmark stable vulkan platform view tests as bringup (flutter/flutter#182554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...
flutter#182468 (comment) Fixes [[flutter 3.41.0] Tooltip ignorePointer property not working](flutter#182468)
4 participants
#182468 (comment)
Fixes [flutter 3.41.0] Tooltip ignorePointer property not working