Skip to content

Handle#6537 second grouped test#182529

Merged
auto-submit[bot] merged 11 commits intoflutter:masterfrom
ahmedsameha1:handle#6537-second-grouped-test
Mar 18, 2026
Merged

Handle#6537 second grouped test#182529
auto-submit[bot] merged 11 commits intoflutter:masterfrom
ahmedsameha1:handle#6537-second-grouped-test

Conversation

@ahmedsameha1
Copy link
Contributor

@ahmedsameha1 ahmedsameha1 commented Feb 18, 2026

This is my attempt to handle #6537 for the following widgets:
AnimatedModalBarrier
NestedScrollView
OrientationBuilder
DeviceOrientationBuilder
OverflowBar
Overlay
OverlayPortal
GlowingOverscrollIndicator
StretchingOverscrollIndicator
PageView

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 18, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 18, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive set of regression tests to ensure various widgets do not crash when rendered with a zero area. The changes are well-targeted and cover all the widgets mentioned in the description. I have one minor suggestion regarding test file organization to improve maintainability.

@ahmedsameha1 ahmedsameha1 force-pushed the handle#6537-second-grouped-test branch from 39c6680 to 7daa142 Compare February 18, 2026 05:38
dkwingsmt
dkwingsmt previously approved these changes Feb 24, 2026
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

victorsanni
victorsanni previously approved these changes Feb 27, 2026
View reviewed changes
victorsanni
victorsanni reviewed Feb 27, 2026
View reviewed changes
packages/flutter/test/widgets/overlay_test.dart Outdated
Comment on lines +1978 to +1979
OverlayEntry(builder: (_) => const Text('X')),
OverlayEntry(builder: (_) => const Text('Y')),
Copy link
Contributor

@victorsanni victorsanni Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need to be disposed?

@ahmedsameha1 ahmedsameha1 force-pushed the handle#6537-second-grouped-test branch from 7daa142 to 3ab1c3d Compare February 27, 2026 06:11
@ahmedsameha1 ahmedsameha1 requested review from a team and jtmcdole as code owners February 27, 2026 06:11
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. platform-android Android applications specifically platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) platform-fuchsia Fuchsia code specifically f: cupertino flutter/packages/flutter/cupertino repository platform-windows Building on or for Windows specifically d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. labels Feb 27, 2026
@github-actions github-actions bot removed f: cupertino flutter/packages/flutter/cupertino repository platform-windows Building on or for Windows specifically d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. platform-web Web applications specifically platform-linux Building on or for Linux specifically package flutter/packages repository. See also p: labels. a: desktop Running on desktop f: focus Focus traversal, gaining or losing focus team-ecosystem Owned by Ecosystem team e: impeller Impeller rendering backend issues and features requests team-android Owned by Android platform team team-engine Owned by Engine team team-ios Owned by iOS platform team d: docs/ flutter/flutter/docs, for contributors labels Feb 27, 2026
@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 10, 2026

autosubmit label was removed for flutter/flutter/182529, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2026
@ahmedsameha1 ahmedsameha1 dismissed stale reviews from victorsanni and dkwingsmt via 3c6d73d March 12, 2026 22:21
This was referenced Mar 18, 2026
Merged
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@victorsanni victorsanni victorsanni approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmedsameha1 @dkwingsmt @victorsanni