Skip to content

Reland: remove material in context_menu_controller_test, icon_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test#182891

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
rkishan516:simple-cross-imports
Feb 26, 2026
Merged

Conversation

@rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Feb 25, 2026

This PR is reland PR for #182697 because TestButton got moved to its own file

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@rkishan516 rkishan516 requested review from justinmc and victorsanni and removed request for victorsanni February 25, 2026 15:28
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 25, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request continues the effort to remove dependencies on package:flutter/material.dart from various widget tests. The changes are generally good, replacing Material widgets with more basic alternatives from package:flutter/widgets.dart or test-specific helpers. I've found a minor inconsistency in icon_test.dart where a magic number is used for an IconData instead of a constant, unlike other icons in the same file.

packages/flutter/test/widgets/icon_test.dart
void main() {
const kTimeToLeaveIcon = IconData(0xe65f, fontFamily: 'MaterialIcons');
const kAbcIcon = IconData(0xf04b6, fontFamily: 'MaterialIcons');
const kSaveIcon = IconData(0xe550, fontFamily: 'MaterialIcons');
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and to improve readability by avoiding magic numbers, please define a constant for IconData(0xe668, ...) which is used later in this file. This is similar to how kSaveIcon is defined, which is also used only once.

Suggested change
const kSaveIcon = IconData(0xe550, fontFamily: 'MaterialIcons');
const kSaveIcon = IconData(0xe550, fontFamily: 'MaterialIcons');
const kTitleIcon = IconData(0xe668, fontFamily: 'MaterialIcons');
References
  1. Code should be optimized for readability. Using a named constant instead of a magic number improves readability. (link)

packages/flutter/test/widgets/icon_test.dart
textDirection: TextDirection.ltr,
child: Center(child: Icon(Icons.title, semanticLabel: 'a label')),
child: Center(
child: Icon(IconData(0xe668, fontFamily: 'MaterialIcons'), semanticLabel: 'a label'),
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please use the newly defined kTitleIcon constant here for better readability and consistency.

Suggested change
child: Icon(IconData(0xe668, fontFamily: 'MaterialIcons'), semanticLabel: 'a label'),
child: Icon(kTitleIcon, semanticLabel: 'a label'),

justinmc
justinmc approved these changes Feb 26, 2026
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I guess I broke this when I relanded #182632, sorry about that and thanks for resubmitting.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Feb 26, 2026
Merged via the queue into flutter:master with commit a285fd5 Feb 26, 2026
153 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2026
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Feb 27, 2026
@rkishan516 @ahmedsameha1
Reland: remove material in context_menu_controller_test, icon_test, l…
a785d84 
…ist_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (flutter#182891)

This PR is reland PR for flutter#182697
because TestButton got moved to its own file

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2026
@engine-flutter-autoroll
a285fd597 Reland: remove material in context_menu_controller_test, ic…
f7e8e13 
…on_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (flutter/flutter#182891)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2026
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2026
@engine-flutter-autoroll
a285fd597 Reland: remove material in context_menu_controller_test, ic…
95a1508 
…on_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (flutter/flutter#182891)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 27, 2026
@engine-flutter-autoroll
Roll Flutter from b31548feb941 to 1141b2bdce66 (56 revisions) (#11137)
32a8a23 
Roll Flutter from b31548feb941 to 1141b2bdce66 (56 revisions)

flutter/flutter@b31548f...1141b2b

2026-02-27 [email protected] flutter#182361 Fix delegate copy on plugins init (flutter/flutter#182362)
2026-02-27 [email protected] Roll Dart SDK from 8b036b3e63cb to 1cdb7dfd913e (1 revision) (flutter/flutter#183004)
2026-02-27 [email protected] Manual roll Dart SDK to 3.12.0-192.0.dev (flutter/flutter#182883)
2026-02-27 [email protected] Roll Skia from e2062707b0c0 to ed220c490eea (1 revision) (flutter/flutter#182992)
2026-02-27 [email protected] Roll Skia from e5aa1ab5c59c to e2062707b0c0 (3 revisions) (flutter/flutter#182989)
2026-02-27 [email protected] Linux build hooks: Read compiler config from CMakeCache.txt (flutter/flutter#181004)
2026-02-27 [email protected] Roll ICU from a86a32e67b8d to 7971660ba630 (3 revisions) (flutter/flutter#182986)
2026-02-27 [email protected] Roll Skia from 49c2de95384e to e5aa1ab5c59c (2 revisions) (flutter/flutter#182980)
2026-02-27 [email protected] [Impeller] Remove shared rendering data from TextFrame (flutter/flutter#182886)
2026-02-27 [email protected] Add fl_view_new_sized_to_content() (flutter/flutter#182924)
2026-02-27 [email protected] [Shortcuts] Improve focus node debug labels (flutter/flutter#181834)
2026-02-27 [email protected] Add a cli flag for toggling HCPP use, and enable it (flutter/flutter#182516)
2026-02-27 [email protected] `SizedBox.square()` (flutter/flutter#182731)
2026-02-27 [email protected] [web] Fix stack corruption in Skwasm and harden withStackScope API (flutter/flutter#182912)
2026-02-26 [email protected] Roll zlib to 7eda07b1e067 (flutter/flutter#182692)
2026-02-26 [email protected] [ CI ] Don't crash analysis when ktlint isn't on PATH (flutter/flutter#181854)
2026-02-26 [email protected] Add calls to await `flutterDriver.waitUntilFirstFrameRasterized()` for all `android_engine_test` screenshot tests (flutter/flutter#182961)
2026-02-26 [email protected] Roll Skia from f44d7db68805 to 49c2de95384e (30 revisions) (flutter/flutter#182957)
2026-02-26 [email protected] Support sending window constraints in metrics events (flutter/flutter#182921)
2026-02-26 [email protected] Reland: remove material in context_menu_controller_test, icon_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (flutter/flutter#182891)
2026-02-26 [email protected] Remove some instances of useMaterial3: true (flutter/flutter#182944)
2026-02-26 [email protected] [Impeller] Use bilinear filtering for non-uniform scaled text (flutter/flutter#182224)
2026-02-26 [email protected] Add a ResidentCompilerFactory to create ResidentCompiler instances. (flutter/flutter#182930)
2026-02-26 [email protected] Add a getter in run.dart to access use-application-binary flag. (flutter/flutter#182931)
2026-02-26 [email protected] [web] Roll Firefox to 148 (flutter/flutter#182859)
2026-02-26 [email protected] Roll Packages from acd9adb to e1d0169 (8 revisions) (flutter/flutter#182946)
2026-02-26 [email protected] Roll Fuchsia Linux SDK from XI0Ax7fbtYE4XKYAQ... to G1GwOdVt5bM7GjMSY... (flutter/flutter#182942)
2026-02-26 [email protected] Add test for WindowPositioner.toString (flutter/flutter#182906)
2026-02-26 [email protected] Remove unused function prototype (flutter/flutter#182915)
2026-02-26 [email protected] Resolve inconsistency with SchedulerBinding.scheduleTask usage recomm… (flutter/flutter#182531)
2026-02-26 [email protected] Fix false positives for hit test misses in flutter_test (flutter/flutter#180856)
2026-02-26 [email protected] Replace an instance of flutter/engine with flutter/flutter (flutter/flutter#182655)
2026-02-26 [email protected] Use null-aware elements in widgets/routes.dart (flutter/flutter#181242)
2026-02-26 [email protected] Fix typos in method names across multiple files (flutter/flutter#182584)
2026-02-26 [email protected] Fix RawAutocomplete crash when options are hidden (flutter/flutter#182785)
2026-02-26 [email protected] Describe implications of tree-status and Google Testing for PRs (flutter/flutter#182916)
2026-02-26 [email protected] Make sure that a StretchingOverscrollIndicator doesn't crash when it … (flutter/flutter#182499)
2026-02-26 [email protected] framework: Use a super-parameter in several missed cases (flutter/flutter#182580)
2026-02-25 [email protected] `WidgetStatesConstraint` as a mixin (flutter/flutter#181704)
2026-02-25 [email protected] Paint the paragraph as a single image (flutter/flutter#181206)
2026-02-25 [email protected] Remove `ExtendSelectionByPageIntent` (flutter/flutter#182642)
2026-02-25 [email protected] feat: add few required properties to test widgets app (flutter/flutter#182805)
2026-02-25 [email protected] Updates MenuAnchor to respect software keyboard (flutter/flutter#180975)
2026-02-25 [email protected] Roll ImGui to v1.92.6-docking (flutter/flutter#182799)
2026-02-25 [email protected] Roll GoogleTest to e9907112b472 (flutter/flutter#182795)
2026-02-25 [email protected] Make positionInlineChildren assert much clearer (flutter/flutter#182093)
...
@rkishan516 rkishan516 deleted the simple-cross-imports branch March 8, 2026 01:46
xxxOVALxxx pushed a commit to xxxOVALxxx/flutter that referenced this pull request Mar 10, 2026
@rkishan516 @xxxOVALxxx
Reland: remove material in context_menu_controller_test, icon_test, l…
ecfac1d 
…ist_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (flutter#182891)

This PR is reland PR for flutter#182697
because TestButton got moved to its own file

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@victorsanni victorsanni Awaiting requested review from victorsanni

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkishan516 @justinmc