Skip to content

Update fl_texture_gl.h#182999

Merged
robert-ancell merged 2 commits intoflutter:masterfrom
nmfisher:patch-1
Mar 2, 2026
Merged

Update fl_texture_gl.h#182999
robert-ancell merged 2 commits intoflutter:masterfrom
nmfisher:patch-1

Conversation

@nmfisher
Copy link
Contributor

This is a documentation fix only.

In this PR, the Linux shell no longer creates a GL context with gdk_window_create_gl_context (it now creates its own EGL context directly).

This means that the documentation in fl_texture_gl.h is no longer correct; it is not possible to create a shared context in this way.

I filed #182998 simply to support this PR.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Feb 27, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes outdated documentation from fl_texture_gl.h. However, the change results in an extra blank line in the comment block. I have added a comment to suggest removing this superfluous line to maintain code readability.

I am having trouble creating individual review comments. Click here to see my feedback.

engine/src/flutter/shell/platform/linux/public/flutter_linux/fl_texture_gl.h (27-29)

medium

While removing this outdated documentation is correct, the change leaves an extra blank line in the resulting comment block. To improve readability, please also remove the blank line that follows this paragraph (on line 30).

References
  1. The style guide emphasizes optimizing for readability. Unnecessary blank lines can sometimes detract from this. (link)

@nmfisher nmfisher requested a review from a team as a code owner February 28, 2026 02:43
@github-actions github-actions bot added the team-linux Owned by the Linux platform team label Feb 28, 2026
@nmfisher
Copy link
Contributor Author

Tagging @robert-ancell who submitted the original PR for confirmation.

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@robert-ancell robert-ancell enabled auto-merge March 1, 2026 23:24
@robert-ancell robert-ancell added this pull request to the merge queue Mar 1, 2026
Merged via the queue into flutter:master with commit 75cca88 Mar 2, 2026
182 of 183 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 2, 2026
Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions)

flutter/flutter@1141b2b...46fb721

2026-03-02 [email protected] [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725)
2026-03-02 [email protected] Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120)
2026-03-02 [email protected] [web] Roll Chrome to 145 (flutter/flutter#182860)
2026-03-02 [email protected] Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118)
2026-03-02 [email protected] Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117)
2026-03-02 [email protected] Add information to issue triage page (flutter/flutter#182145)
2026-03-02 [email protected] Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103)
2026-03-02 [email protected] Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100)
2026-03-02 [email protected] Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101)
2026-03-01 [email protected] Update fl_texture_gl.h (flutter/flutter#182999)
2026-03-01 [email protected] Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096)
2026-03-01 [email protected] Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092)
2026-03-01 [email protected] Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971)
2026-03-01 [email protected] Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088)
2026-03-01 [email protected] Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076)
2026-02-28 [email protected] Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064)
2026-02-28 [email protected] Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057)
2026-02-28 [email protected] Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056)
2026-02-28 [email protected] Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051)
2026-02-28 [email protected] [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android.  (flutter/flutter#182918)
2026-02-28 [email protected] Add desktop review teams (flutter/flutter#182972)
2026-02-28 [email protected] [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795)
2026-02-28 [email protected] Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032)
2026-02-28 [email protected] [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)
2026-02-27 [email protected] Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847)
2026-02-27 [email protected] Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025)
2026-02-27 [email protected] Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021)
2026-02-27 [email protected] When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786)
2026-02-27 [email protected] Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018)
2026-02-27 [email protected] Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913)
2026-02-27 [email protected] Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922)
2026-02-27 [email protected] licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965)
2026-02-27 [email protected] Re-add extended attribute removed by SwiftPM (flutter/flutter#183011)
2026-02-27 [email protected] Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301)
2026-02-27 [email protected] Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014)
2026-02-27 [email protected] Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692)
2026-02-27 [email protected] chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973)
2026-02-27 [email protected] Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
...
xxxOVALxxx pushed a commit to xxxOVALxxx/flutter that referenced this pull request Mar 10, 2026
This is a documentation fix only.

In [this
PR](https://github.com/flutter/flutter/pull/172330/changes#diff-b5a9fc8e7a9ca4c2b2f825467a7b9cad411053d33f6e78f72875fcd6a2aae993L45),
the Linux shell no longer creates a GL context with
`gdk_window_create_gl_context` (it now creates its own EGL context
directly).

This means that the documentation in `fl_texture_gl.h` is no longer
correct; it is not possible to create a shared context in this way.

I filed flutter#182998 simply to
support this PR.
  
## Pre-launch Checklist

- [Y] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [Y] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [Y] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [Y] I signed the [CLA].
- [Y] I listed at least one issue that this PR fixes in the description
above.
- [Y] I updated/added relevant documentation (doc comments with `///`).
- [N] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [Y] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [Y] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically team-linux Owned by the Linux platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants