Add a Clarification for the docs of suggestionsBuilder of SearchAnchor#183106
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Mar 18, 2026
Merged
Add a Clarification for the docs of suggestionsBuilder of SearchAnchor#183106auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
github-actions
bot
added
framework
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to clarify when the suggestionsBuilder is called. The added documentation is helpful but not entirely accurate. I've suggested a more precise wording to reflect that the builder is also called when the search view is first displayed, in addition to when the text changes.
| final SearchAnchorChildBuilder builder; | ||
|
|
||
| /// Called to get the suggestion list for the search view. | ||
| /// It is called only when the search text changes. |
Contributor
There was a problem hiding this comment.
This clarification is helpful, but not entirely accurate. The suggestionsBuilder is also called when the search view is first displayed (with an empty search text), not just when the text changes subsequently. A more precise phrasing would be better.
/// It is called when the search view is shown, and again whenever the search text changes.
ahmedsameha1
force-pushed
the
handle#183105
branch
from
e1c0e16 to
c7be76e
Compare
QuncCccccc
previously approved these changes
Mar 4, 2026
Contributor
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
Thanks for your contribution:) LGTM.
| final SearchAnchorChildBuilder builder; | ||
|
|
||
| /// Called to get the suggestion list for the search view. | ||
| /// After the search view is displayed, it is called only when the search text changes. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// After the search view is displayed, it is called only when the search text changes. | |
| /// | |
| /// This builder is called once when the search view is first displayed, | |
| /// and subsequently every time the search text changes. |
Contributor
There was a problem hiding this comment.
@ahmedsameha1 Once we updated the doc with the suggestion, I'll ask for a second review and then we are good to go:)!
Contributor
Author
There was a problem hiding this comment.
Ok, I committed and pushed your suggestion. Do you think that viewBuilder needs a similar clarification? As it overrides suggestionsBuilder.
Contributor
There was a problem hiding this comment.
Running dart format packages/flutter/lib/src/material/search_anchor.dart will fix the failed Linux Analyze test.
As it overrides suggestionsBuilder.
I don't think it overrides suggestionsBuilder. The viewBuilder is used to override the default layout.
Contributor
Author
There was a problem hiding this comment.
Ok, I misunderstood it. I tested it, and the print statement in the viewBuilder did not appear to be called when the search text changes, but the one in the suggestionsBuilder prints on the console. Maybe I will ask for clarification for this in another issue!
ahmedsameha1
force-pushed
the
handle#183105
branch
2 times, most recently
from
4e89138 to
6209ec6
Compare
victorsanni
reviewed
Mar 11, 2026
ahmedsameha1
force-pushed
the
handle#183105
branch
from
6209ec6 to
0aed8f2
Compare
victorsanni
approved these changes
Mar 14, 2026
QuncCccccc
force-pushed
the
handle#183105
branch
from
0aed8f2 to
7471bfb
Compare
dkwingsmt
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 19, 2026
flutter/flutter@d117642...dd64978 2026-03-18 [email protected] Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 [email protected] Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 [email protected] Linux reuse sibling (flutter/flutter#183653) 2026-03-18 [email protected] Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 [email protected] fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 [email protected] (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 [email protected] Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 [email protected] Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 [email protected] Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 [email protected] Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 [email protected] Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 [email protected] [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 [email protected] Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 [email protected] Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 [email protected] Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 [email protected] fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 [email protected] Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 [email protected] Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 [email protected] Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 [email protected] Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 [email protected] Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 [email protected] fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 [email protected] [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 [email protected] [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle: #183105.
Fixes #183105