Rename hcpp opt in flag to enable-hcpp#183151
Merged
auto-submit[bot] merged 11 commits intoflutter:masterfrom Mar 12, 2026
Merged
Rename hcpp opt in flag to enable-hcpp#183151auto-submit[bot] merged 11 commits intoflutter:masterfrom
enable-hcpp#183151auto-submit[bot] merged 11 commits intoflutter:masterfrom
Conversation
added 2 commits
March 2, 2026 16:43
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the HCPP feature flag. The developer-facing flag is renamed to enable-hcpp, and the internal engine flag is renamed to enable-hcpp-and-surface-control. The changes are applied consistently across various parts of the codebase, including command-line tools, test suites, and the Android embedding. I have one suggestion to improve the clarity of an internal engine constant.
Note: Security Review did not run due to the size of the PR.
added 2 commits
March 4, 2026 12:18
…rol_flag' into rename_surface_control_flag
jmagman
approved these changes
Mar 6, 2026
Member
Contributor
|
autosubmit label was removed for flutter/flutter/183151, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 12, 2026
flutter/flutter@3f400d7...9e36adb 2026-03-12 [email protected] Roll Fuchsia Linux SDK from QD887D4OanteB7UKM... to jJbpv4J_tjW-wuKDq... (flutter/flutter#183584) 2026-03-12 [email protected] Adding the SatelliteWindowController interface to `_window.dart` (flutter/flutter#182903) 2026-03-12 [email protected] Roll Skia from 0cab3e4ee34b to 46f41493ebf4 (17 revisions) (flutter/flutter#183553) 2026-03-12 [email protected] Roll Dart SDK from 8531f7c2bdae to 59be21f25f2d (4 revisions) (flutter/flutter#183547) 2026-03-12 [email protected] [ios][engine] Fix keyboard flicker when switching text fields (flutter/flutter#182661) 2026-03-11 [email protected] Rename hcpp opt in flag to `enable-hcpp` (flutter/flutter#183151) 2026-03-11 [email protected] Roll pub packages (flutter/flutter#183541) 2026-03-11 [email protected] Re-enable gpu_test.dart for opengles, but disable specific tests in the file (flutter/flutter#183531) 2026-03-11 [email protected] Use CLA-approved email and username for github workflow commits. (flutter/flutter#183540) 2026-03-11 [email protected] [integration_test]UIScene Migration (flutter/flutter#182631) 2026-03-11 [email protected] ci: Run orchestrator for windows_arm_host_engine on Linux (flutter/flutter#181075) 2026-03-11 [email protected] [web] Prevent Firefox auto-updates (flutter/flutter#183330) 2026-03-11 [email protected] Add scrollCacheExtent to PageView (flutter/flutter#180411) 2026-03-11 [email protected] Remove redundant VS Code code/tests (flutter/flutter#183506) 2026-03-11 [email protected] Roll pub packages (flutter/flutter#183527) 2026-03-11 [email protected] Reapply "Make HCPP upgrading work for vd/tlhc (#181024)" (#183310) (flutter/flutter#183360) 2026-03-11 [email protected] Add awaits to dev/ callsites (flutter/flutter#183479) 2026-03-11 [email protected] Standardize review timeline guidance (flutter/flutter#183465) 2026-03-11 [email protected] Rename ExecutionModelToString to ExecutionModelToStringName. (flutter/flutter#183461) 2026-03-11 [email protected] Fix input mirroring in platform views when system language is RTL, and support is set in manifest. (flutter/flutter#183472) 2026-03-11 [email protected] Roll Packages from ee460d6 to ecace66 (10 revisions) (flutter/flutter#183517) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the flag in developer facing places to
enable-hcpp, and toenable-hcpp-and-surface-controlin internal facing places.fixes #176805