Skip to content

Rename hcpp opt in flag to enable-hcpp#183151

Merged
auto-submit[bot] merged 11 commits intoflutter:masterfrom
gmackall:rename_surface_control_flag
Mar 12, 2026
Merged

Rename hcpp opt in flag to enable-hcpp#183151
auto-submit[bot] merged 11 commits intoflutter:masterfrom
gmackall:rename_surface_control_flag

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Mar 3, 2026

Renames the flag in developer facing places to enable-hcpp, and to enable-hcpp-and-surface-control in internal facing places.

fixes #176805

Gray Mackall added 2 commits March 2, 2026 16:43
@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Mar 3, 2026
@gmackall gmackall marked this pull request as ready for review March 4, 2026 20:07
@gmackall gmackall requested a review from a team as a code owner March 4, 2026 20:07
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the HCPP feature flag. The developer-facing flag is renamed to enable-hcpp, and the internal engine flag is renamed to enable-hcpp-and-surface-control. The changes are applied consistently across various parts of the codebase, including command-line tools, test suites, and the Android embedding. I have one suggestion to improve the clarity of an internal engine constant.

Note: Security Review did not run due to the size of the PR.

Gray Mackall added 2 commits March 4, 2026 12:18
@jmagman
Copy link
Member

jmagman commented Mar 6, 2026

@gmackall can you add a link to the HCPP issue? Let's make it easy for source control archeologists.
Does this fix #176805? Can you add a comment there that explains what this feature is, how to turn it on, etc?

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 11, 2026

autosubmit label was removed for flutter/flutter/183151, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Mar 11, 2026
Merged via the queue into flutter:master with commit 7e99fcf Mar 12, 2026
187 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 12, 2026
flutter/flutter@3f400d7...9e36adb

2026-03-12 [email protected] Roll Fuchsia Linux SDK from QD887D4OanteB7UKM... to jJbpv4J_tjW-wuKDq... (flutter/flutter#183584)
2026-03-12 [email protected] Adding the SatelliteWindowController interface to `_window.dart` (flutter/flutter#182903)
2026-03-12 [email protected] Roll Skia from 0cab3e4ee34b to 46f41493ebf4 (17 revisions) (flutter/flutter#183553)
2026-03-12 [email protected] Roll Dart SDK from 8531f7c2bdae to 59be21f25f2d (4 revisions) (flutter/flutter#183547)
2026-03-12 [email protected] [ios][engine] Fix keyboard flicker when switching text fields (flutter/flutter#182661)
2026-03-11 [email protected] Rename hcpp opt in flag to `enable-hcpp` (flutter/flutter#183151)
2026-03-11 [email protected] Roll pub packages (flutter/flutter#183541)
2026-03-11 [email protected] Re-enable gpu_test.dart for opengles, but disable specific tests in the file (flutter/flutter#183531)
2026-03-11 [email protected] Use CLA-approved email and username for github workflow commits. (flutter/flutter#183540)
2026-03-11 [email protected] [integration_test]UIScene Migration (flutter/flutter#182631)
2026-03-11 [email protected] ci: Run orchestrator for windows_arm_host_engine on Linux  (flutter/flutter#181075)
2026-03-11 [email protected] [web] Prevent Firefox auto-updates (flutter/flutter#183330)
2026-03-11 [email protected] Add scrollCacheExtent to PageView (flutter/flutter#180411)
2026-03-11 [email protected] Remove redundant VS Code code/tests (flutter/flutter#183506)
2026-03-11 [email protected] Roll pub packages (flutter/flutter#183527)
2026-03-11 [email protected] Reapply "Make HCPP upgrading work for vd/tlhc (#181024)" (#183310) (flutter/flutter#183360)
2026-03-11 [email protected] Add awaits to dev/ callsites (flutter/flutter#183479)
2026-03-11 [email protected] Standardize review timeline guidance (flutter/flutter#183465)
2026-03-11 [email protected] Rename ExecutionModelToString to ExecutionModelToStringName. (flutter/flutter#183461)
2026-03-11 [email protected] Fix input mirroring in platform views when system language is RTL, and support is set in manifest. (flutter/flutter#183472)
2026-03-11 [email protected] Roll Packages from ee460d6 to ecace66 (10 revisions) (flutter/flutter#183517)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HCPP] Enable opting in to HCPP platform views with a feature flag

2 participants