[web] Prevent Firefox auto-updates#183330
Conversation
github-actions
bot
added
engine
mdebbar
force-pushed
the
firefox_auto_update
branch
6 times, most recently
from
57205c5 to
26bebe9
Compare
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request enhances Firefox browser management by adding a feature to print the browser's actual version upon launch and implementing a mechanism to disable automatic updates through a policies.json file. Review comments suggest improvements such as awaiting the asynchronous version printing call for predictable execution, adding a check to verify if the Firefox executable path is a symlink before resolving it, and refactoring the hardcoded JSON policy content into a Dart constant for better maintainability.
mdebbar
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
mdebbar
force-pushed
the
firefox_auto_update
branch
from
26bebe9 to
bc03132
Compare
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Awesome, great catch!!
mdebbar
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
flutter/flutter@3f400d7...9e36adb 2026-03-12 [email protected] Roll Fuchsia Linux SDK from QD887D4OanteB7UKM... to jJbpv4J_tjW-wuKDq... (flutter/flutter#183584) 2026-03-12 [email protected] Adding the SatelliteWindowController interface to `_window.dart` (flutter/flutter#182903) 2026-03-12 [email protected] Roll Skia from 0cab3e4ee34b to 46f41493ebf4 (17 revisions) (flutter/flutter#183553) 2026-03-12 [email protected] Roll Dart SDK from 8531f7c2bdae to 59be21f25f2d (4 revisions) (flutter/flutter#183547) 2026-03-12 [email protected] [ios][engine] Fix keyboard flicker when switching text fields (flutter/flutter#182661) 2026-03-11 [email protected] Rename hcpp opt in flag to `enable-hcpp` (flutter/flutter#183151) 2026-03-11 [email protected] Roll pub packages (flutter/flutter#183541) 2026-03-11 [email protected] Re-enable gpu_test.dart for opengles, but disable specific tests in the file (flutter/flutter#183531) 2026-03-11 [email protected] Use CLA-approved email and username for github workflow commits. (flutter/flutter#183540) 2026-03-11 [email protected] [integration_test]UIScene Migration (flutter/flutter#182631) 2026-03-11 [email protected] ci: Run orchestrator for windows_arm_host_engine on Linux (flutter/flutter#181075) 2026-03-11 [email protected] [web] Prevent Firefox auto-updates (flutter/flutter#183330) 2026-03-11 [email protected] Add scrollCacheExtent to PageView (flutter/flutter#180411) 2026-03-11 [email protected] Remove redundant VS Code code/tests (flutter/flutter#183506) 2026-03-11 [email protected] Roll pub packages (flutter/flutter#183527) 2026-03-11 [email protected] Reapply "Make HCPP upgrading work for vd/tlhc (#181024)" (#183310) (flutter/flutter#183360) 2026-03-11 [email protected] Add awaits to dev/ callsites (flutter/flutter#183479) 2026-03-11 [email protected] Standardize review timeline guidance (flutter/flutter#183465) 2026-03-11 [email protected] Rename ExecutionModelToString to ExecutionModelToStringName. (flutter/flutter#183461) 2026-03-11 [email protected] Fix input mirroring in platform views when system language is RTL, and support is set in manifest. (flutter/flutter#183472) 2026-03-11 [email protected] Roll Packages from ee460d6 to ecace66 (10 revisions) (flutter/flutter#183517) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Examples of previous tree closures caused by Firefox auto-updates:
Linux linux_web_engine_testsis failing somewhat consistently on Firefox #172713