[cp-stable] GitHub workflows to assist with releases.#183480
Conversation
This cherry-picks the new GitHub workflows for releases into the stable channel. This change has very little risk and doesn't require a changelog entry since it doesn't affect code that ships to customers. Note: this does not need to be merged until we actually plan to do a release. Currently, the CP queue is empty, so we don't really need to merge this until there is a reason to make a stable release.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the create_updated_flutter_deps.py script. A new command-line argument, --dart_revision, is added to allow specifying a Dart revision, with validation for the git hash format. The script's file processing logic is also refactored to fix bugs where lines were incorrectly written to the output file. My review includes one suggestion to align with the project's Python style guide.
| # No dart revision supplied. Leave as-is. | ||
| updatedfile.write(lines[i]) | ||
| else: | ||
| updatedfile.write(" 'dart_revision': '%s',\n" % args.dart_revision) |
There was a problem hiding this comment.
For consistency with other f-string usage in this file and to adhere to the Google Python Style Guide, it's recommended to use an f-string for formatting this line instead of the older % operator.
| updatedfile.write(" 'dart_revision': '%s',\n" % args.dart_revision) | |
| updatedfile.write(f" 'dart_revision': '{args.dart_revision}',\n") |
References
- The repository style guide specifies that Python code should follow the Google Python Style Guide. This guide recommends using f-strings or
str.format()for string formatting over the older%operator. (link)
eyebrowsoffire
added
the
autosubmit
auto-submit
bot
merged commit 22ba81c
into
flutter:flutter-3.41-candidate.0
2 participants
This cherry-picks the new GitHub workflows for releases into the stable channel.
This change has very little risk and doesn't require a changelog entry since it doesn't affect code that ships to customers.
Note: this does not need to be merged until we actually plan to do a release. Currently, the CP queue is empty, so we don't really need to merge this until there is a reason to make a stable release.