[CP-stable]Migrated circle sdf to euclidean 2d derivative#183526
Conversation
fixes flutter#182708 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
@gaaclarke please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
engine
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the circle signed distance field (SDF) shader to use a Euclidean 2D derivative for more accurate gradient calculation. The core change in circle.frag replaces fwidth() with length(vec2(dFdx(...), dFdy(...))). To support testing this change, a new interactive playground test DrawThinStrokedCircle is added, and an existing one is updated. The performance metrics in malioc.json are also updated to reflect the shader modification. I have one suggestion to correct a slider range in the new test.
| ImGui::SliderFloat("Stroked Radius", &stroked_radius, 0, 500); | ||
| ImGui::SliderFloat("Stroked Width", &stroke_width, 0, 500); | ||
| ImGui::SliderFloat("Stroked Width Fine", &stroke_width_fine, 0, 5); | ||
| ImGui::SliderFloat("Stroked Alpha", &stroked_alpha, 0, 10.0); |
There was a problem hiding this comment.
The slider range for "Stroked Alpha" is [0, 10.0], but stroked_alpha is initialized to 255.0 and is used with withAlpha, which expects a value in the range [0, 255]. This will cause the alpha to be clamped to 10, which is likely not the intended behavior for a full opacity option. The range should probably be [0, 255.0] to match the expected alpha range.
| ImGui::SliderFloat("Stroked Alpha", &stroked_alpha, 0, 10.0); | |
| ImGui::SliderFloat("Stroked Alpha", &stroked_alpha, 0, 255.0); |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
camsim99
added
the
autosubmit
auto-submit
bot
merged commit b65acc2
into
flutter:flutter-3.41-candidate.0
Added release notes for Flutter version 3.41.5 that includes: #183526 #183551 **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
4 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
#182708
Impact Description:
Bur artifacts in circles rendering at 45 degree angles for any platform using Impeller.
Changelog Description:
When drawing circles as strokes on Impeller, there are inconsistent line widths at 45 degree angles.
Workaround:
None.
Risk:
Test Coverage:
Validation Steps:
There is a golden test and was validated by users.