refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test#183562
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Mar 13, 2026
Conversation
github-actions
bot
added
framework
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors two test files, sliver_resizing_header_test.dart and sliver_prototype_item_extent_test.dart, to remove dependencies on the Material library by replacing MaterialApp and Scaffold with TestWidgetsApp. The check_tests_cross_imports.dart script is updated to remove sliver_resizing_header_test.dart from the allowlist, but an equivalent removal for sliver_prototype_item_extent_test.dart is missing, which will likely cause CI failure.
rkishan516
force-pushed
the
simple-cross-imports-1
branch
from
a94a516 to
0d4589e
Compare
navaronbracke
previously approved these changes
Mar 12, 2026
| slivers: <Widget>[ | ||
| SliverPrototypeExtentList.list( | ||
| prototypeItem: const TestItem(item: -1, height: 100.0), | ||
| children: <int>[ |
Contributor
There was a problem hiding this comment.
similar to the other tests in this PR? That makes it a little easier to read :)
Suggested change
| children: <int>[ | |
| SliverPrototypeExtentList.builder( | |
| prototypeItem: const TestItem(item: -1, height: 100.0), | |
| itemCount: 8, | |
| itemBuilder: (BuildContext context, int index) => TestItem(item: index), | |
| ) |
… sliver_prototype_item_extent_test
rkishan516
force-pushed
the
simple-cross-imports-1
branch
from
0d4589e to
1d7bfc2
Compare
justinmc
approved these changes
Mar 12, 2026
Comment on lines
+85
to
+86
| itemBuilder: (BuildContext context, int index) => TestItem(item: index), | ||
| itemCount: 8, |
Contributor
There was a problem hiding this comment.
Good call refactoring this as well.
rkishan516
added
the
autosubmit
github-project-automation
bot
moved this from In Progress
to Done
in Test cross-imports Review Queue
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2026
…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2026
…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2026
…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2026
…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 14, 2026
flutter/flutter@9e36adb...732e05d 2026-03-13 [email protected] Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 [email protected] Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 [email protected] Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 [email protected] Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 [email protected] Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 [email protected] Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 [email protected] refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 [email protected] Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 [email protected] Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 [email protected] ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 [email protected] Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 [email protected] Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 [email protected] [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 [email protected] Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 [email protected] Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 [email protected] Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 [email protected] Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 [email protected] Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 [email protected] Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 [email protected] Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes Material imports from sliver_resizing_header_test and sliver_prototype_item_extent_test.
part of: #177415
Pre-launch Checklist
///).