Merged
Conversation
This ensures it is destroyed when no object is using it. It was previously leaking. Fixes flutter#182192
github-actions
bot
added
engine
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a memory leak on Linux with Wayland by reusing a sibling framebuffer instead of creating a new one for each frame. This is implemented by adding a render_sibling member to FlCompositorOpenGL. To support this and correctly manage the lifecycle of the underlying EGL image, a new GObject wrapper, FlEGLImage, is introduced, which uses reference counting. The changes are well-structured and address the reported issue. I've found one critical memory leak in the constructor of the new FlEGLImage class that should be addressed.
Contributor
|
Merged and retested - I'm still getting black window contents when the window is resized. This does not occur in master. Have not investigated beyond that. |
Contributor
Author
|
@robert-ancell thank you for testing. I simplified the managing of the sibling, and I can't reproduce the black screen window. Could you give me some guidance how to reproduce the black screen and the system you are using (OS? GPU? Wayland?). |
Contributor
|
With the simplification it's working here, so this is now good to land. |
robert-ancell
approved these changes
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2026
robert-ancell
added a commit
to robert-ancell/flutter
that referenced
this pull request
Mar 19, 2026
This reverts commit ed5bda4.
Contributor
|
Further testing shows this breaking multi-window support: #183871 |
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 19, 2026
flutter/flutter@d117642...dd64978 2026-03-18 [email protected] Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 [email protected] Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 [email protected] Linux reuse sibling (flutter/flutter#183653) 2026-03-18 [email protected] Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 [email protected] fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 [email protected] (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 [email protected] Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 [email protected] Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 [email protected] Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 [email protected] Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 [email protected] Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 [email protected] [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 [email protected] Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 [email protected] Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 [email protected] Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 [email protected] fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 [email protected] Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 [email protected] Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 [email protected] Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 [email protected] Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 [email protected] Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 [email protected] fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 [email protected] [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 [email protected] [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
This reverts commit ed5bda4. When running the `examples/multiple_windows` and creating a regular window then closing it causes the content of the main window to stop being updated. The terminal shows: ``` GrGLGpu::flushRenderTargetNoColorWrites glCheckFramebufferStatus 8cd7 ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLGpu.cpp(2271) : Clear(clearMask) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(225) : DrawRangeElements(glPrimType, minIndexValue, maxIndexValue, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex)) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(203) : DrawArrays(glPrimType, baseVertex, vertexCount) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLTexture.cpp(192) : ObjectLabel(0x1702, fID, -1, label.c_str()) ```
robert-ancell
added a commit
to robert-ancell/flutter
that referenced
this pull request
Mar 19, 2026
This reverts commit ed5bda4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add reuse render_sibling to avoid memory leak. to @robert-ancell PR #183539
We observed a memory leak on Linux Desktop with Wayland on embedded ARM cpu and an OpenGL ES driver.
While the fix works in our environment, I'm not sure it's correct in all scenarios. Maybe someone with more experience in the Flutter Linux rendering can review and provide some feedback.
The memory leak seems related to issue mentioned below.
#182192
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.