fix(web): handle asynchronously disposed platform views#183666
fix(web): handle asynchronously disposed platform views#183666auto-submit[bot] merged 8 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
engine
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a potential crash when platform views are disposed asynchronously during rendering. The core change in PlatformViewEmbedder is the addition of a guard in compositeEmbeddedView that checks if a platform view is still known to the PlatformViewManager before proceeding with composition. To validate this fix, a new test file, async_rendering_test.dart, is introduced. This test simulates the specific race condition by disposing of a platform view within an artificial asynchronous gap in the rendering pipeline, and then confirms that the rendering process completes without crashing.
harryterkelsen
force-pushed
the
fix-async-frame-render-issues
branch
from
98757ce to
3fc6e2d
Compare
|
/gemini review |
Check if platform views still exist in PlatformViewManager before compositing to avoid crashes if they are disposed during async gaps in the rendering pipeline. Added test/ui/async_rendering_test.dart.
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a crash when a platform view is disposed asynchronously during the rendering pipeline. The fix involves checking if the view still exists before compositing and changing a debug assertion to a warning to handle the race condition gracefully. The new tests are well-written and verify the fix. I have one suggestion to reduce code duplication in the new test file.
engine/src/flutter/lib/web_ui/test/ui/async_rendering_test.dart
Outdated
Show resolved
Hide resolved
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing this quickly!
harryterkelsen
force-pushed
the
fix-async-frame-render-issues
branch
from
3fc6e2d to
b943f30
Compare
mdebbar
added
CICD
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/183666, because - The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
mdebbar
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
harryterkelsen
added
CICD
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM! Small question about whether or not to nag the user in release builds for this case (before this change we used to NOT nag users in release builds, only when asserts were enabled)
| debugInvalidViewIds ??= <int>[]; | ||
| debugInvalidViewIds.add(viewId); |
There was a problem hiding this comment.
Do we really want to "nag" the user in production with the invalid view warning? Should this be: "populate the debugInvalidViewIds array when asserts are enabled, but skip rendering an invalid viewId regardless"?
There was a problem hiding this comment.
Before this change we would crash in the case where we went to render a scene with a platform view where !PlatformViewManager.instance.knowsViewId(viewId). I think downgrading from crash to a warning is okay here. If it turns out that the warning is logged often in normally behaving apps, then we should reconsider and just have it print the warning in an assert or something.
flutter-dashboard
bot
removed
the
autosubmit
flutter/flutter@d117642...dd64978 2026-03-18 [email protected] Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 [email protected] Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 [email protected] Linux reuse sibling (flutter/flutter#183653) 2026-03-18 [email protected] Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 [email protected] fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 [email protected] (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 [email protected] Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 [email protected] Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 [email protected] Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 [email protected] Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 [email protected] Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 [email protected] [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 [email protected] Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 [email protected] Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 [email protected] Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 [email protected] fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 [email protected] Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 [email protected] Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 [email protected] Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 [email protected] Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 [email protected] Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 [email protected] fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 [email protected] [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 [email protected] [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
5 participants
Check if platform views still exist in PlatformViewManager before compositing to avoid crashes if they are disposed during async gaps in the rendering pipeline.
Added test/ui/async_rendering_test.dart.
Fixes #182844
Fixes #176299
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.